[Console] SymfonyStyle : fix blocks output is broken on windows cmd #14740
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -44,7 +44,7 @@ class SymfonyStyle extends OutputStyle | ||
| public function __construct(InputInterface $input, OutputInterface $output) | ||
| { | ||
| $this->input = $input; | ||
| $this->lineLength = min($this->getTerminalWidth(), self::MAX_LINE_LENGTH); | ||
| $this->lineLength = min($this->getTerminalWidth() - (int) (DIRECTORY_SEPARATOR === '\\'), self::MAX_LINE_LENGTH); |
There was a problem hiding this comment.
That probably deserves a small comment to indicate why there is such a "hack" here.
|
👍 |
| $this->bufferedOutput = new BufferedOutput($output->getVerbosity(), false, clone $output->getFormatter()); | ||
| // Windows cmd wraps lines as soon as the terminal width is reached, whether there are following chars or not. | ||
| // https://github.com/symfony/symfony/pull/14740 | ||
| $this->lineLength = min($this->getTerminalWidth() - (int) (DIRECTORY_SEPARATOR === '\\'), self::MAX_LINE_LENGTH); |
There was a problem hiding this comment.
@fabpot : Is it sufficient ?
There was a problem hiding this comment.
Can you remove the github reference, there is no need for that as the merge commit already contains everything we need to know.
|
Thank you @ogizanagi. |
fabpot
added a commit
that referenced
this pull request
Jun 8, 2015
…ndows cmd (ogizanagi) This PR was merged into the 2.7 branch. Discussion ---------- [Console] SymfonyStyle : fix blocks output is broken on windows cmd | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Using `SymfonyStyle::block` method, output is broken on windows cmd:  Windows cmd seems to wrap lines as soon as the terminal width is reached, whether there are following characters or not. I've encountered this behavior with multiple command prompts available on Windows, like Console2, ConEmu, Cmdr, ... But as most of them are simple cmd wrappers, the output is identic. The only good fellow in there is Cygwin which provides an Unix-like env and command-line interface. This PR solves this issue by assuming that the lineLength (not the terminal width), used to wrap lines internally within the `SymfonyStyle::block` method, should be the terminal width - 1. Commits ------- ea3d768 [Console] SymfonyStyle : Fix blocks output is broken on windows cmd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
SymfonyStyle::blockmethod, output is broken on windows cmd:Windows cmd seems to wrap lines as soon as the terminal width is reached, whether there are following characters or not.
I've encountered this behavior with multiple command prompts available on Windows, like Console2, ConEmu, Cmdr, ... But as most of them are simple cmd wrappers, the output is identic. The only good fellow in there is Cygwin which provides an Unix-like env and command-line interface.
This PR solves this issue by assuming that the lineLength (not the terminal width), used to wrap lines internally within the
SymfonyStyle::blockmethod, should be the terminal width - 1.