[Console] SymfonyStyle : fix blocks wordwrapping #14739
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a unit test for this? |
Allow to print strings with a length greater than the terminal length in a block by allowing to cut words.
|
Test added. |
|
Thank you @ogizanagi. |
fabpot
added a commit
that referenced
this pull request
Jun 9, 2015
This PR was merged into the 2.7 branch.
Discussion
----------
[Console] SymfonyStyle : fix blocks wordwrapping
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
Allow to print strings with a length greater than the terminal length in a block by allowing to cut words.
Indeed, currently such code won't work:
```php
//Terminal is 80 chars wide
$sfStyle->caution(str_repeat('#', 78)); //Caution uses 3 chars as prefix (' ! ')
```
> [Symfony\Component\Debug\Exception\ContextErrorException]
Warning: str_repeat(): Second argument has to be greater than
or equal to 0
Of course, this is only a foolish example. But there is no reason the command should fail when trying to output a long word (as we could imagine it could be a FQCN, absolute path or anything else), nor just because the terminal width is too small.
Commits
-------
58f2fad [Console] SymfonyStyle : Fix blocks wordwrapping
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to print strings with a length greater than the terminal length in a block by allowing to cut words.
Indeed, currently such code won't work:
Of course, this is only a foolish example. But there is no reason the command should fail when trying to output a long word (as we could imagine it could be a FQCN, absolute path or anything else), nor just because the terminal width is too small.