Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[TranslationDebugCommand] fixed failing tests. #14611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 12, 2015
Merged

[TranslationDebugCommand] fixed failing tests. #14611

merged 1 commit into from
May 12, 2015

Conversation

aitboudad
Copy link
Contributor

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets #14523
Tests pass? yes
License MIT

@aitboudad aitboudad force-pushed the translation_update_cmd_2.7 branch from 0455de1 to 791a294 Compare May 11, 2015 17:54
xabbuh
xabbuh reviewed May 11, 2015
View reviewed changes
src/Symfony/Bundle/FrameworkBundle/Tests/Command/TranslationDebugCommandTest.php
/**
* @expectedException \InvalidArgumentException
*/
public function testDebugUnvalidDirectory()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testDebugInvalidDirectory()

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@aitboudad aitboudad force-pushed the translation_update_cmd_2.7 branch from 791a294 to 028b118 Compare May 11, 2015 18:15
@aitboudad aitboudad force-pushed the translation_update_cmd_2.7 branch from 028b118 to f75790a Compare May 11, 2015 18:17
@nicolas-grekas
Copy link
Member

👍

1 similar comment
@xabbuh
Copy link
Member

xabbuh commented May 12, 2015

👍

@aitboudad aitboudad merged commit f75790a into symfony:2.7 May 12, 2015
aitboudad added a commit that referenced this pull request May 12, 2015
@aitboudad
minor #14611 [TranslationDebugCommand] fixed failing tests. (aitboudad)
2815ae8 
This PR was merged into the 2.7 branch.

Discussion
----------

[TranslationDebugCommand] fixed failing tests.

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Fixed tickets  | #14523
| Tests pass?   | yes
| License       | MIT

Commits
-------

f75790a [TranslationDebugCommand] fixed failing tests.
@aitboudad aitboudad deleted the translation_update_cmd_2.7 branch May 12, 2015 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aitboudad @nicolas-grekas @xabbuh
Morty Proxy This is a proxified and sanitized view of the page, visit original site.