[Yaml] Match signature of Yaml::parse() with Parser->parse() #14412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
remi-blaise
commented
Apr 19, 2015
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | |
| License | MIT |
| Doc PR |
|
👍 |
|
@Zzortell Could you please also rebase and add a test for this feature? |
|
I integrate this commit in #14420 so you can close this one. |
|
@Zzortell These are separate things. I think there should be two PRs. It's easier to review this way. |
|
@xabbuh What do you mean when you say rebase ? Because I rebased it when I pushed it |
|
@Zzortell Never mind, I must have looked at the wrong Travis build. So everything is fine. 👍 |
|
Travais failed because of errors in Process and Debug components. Nothing to do with this PR. Let's merge ! |
|
Thank you @Zzortell. |
fabpot
added a commit
that referenced
this pull request
Apr 27, 2015
…se() (Zzortell) This PR was merged into the 2.7 branch. Discussion ---------- [Yaml] Match signature of Yaml::parse() with Parser->parse() | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Commits ------- 238589d Add $objectForMap as argument of Yaml::parse()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.