[2.7][Translation] avoid freshness check based on content *inside* the cache #14281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c6b37cb to
162b07c
Compare
162b07c to
f9939d8
Compare
|
any thought, before I merge ? |
aitboudad
added a commit
that referenced
this pull request
Apr 9, 2015
…t *inside* the cache (mpdude, aitboudad) This PR was merged into the 2.7 branch. Discussion ---------- [2.7][Translation] avoid freshness check based on content *inside* the cache | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Fixed tickets | ~ | Tests pass? | yes | License | MIT it's mainly based on #14268 Commits ------- f9939d8 [Translation] avoid freshness check based on content *inside* the cache. f666657 [Translator] Cache does not take fallback locales into consideration
|
|
| return ''; | ||
| } | ||
| $catalogueHash = sha1(serialize(array( | ||
| 'resources' => isset($this->resources[$locale]) ? $this->resources[$locale] : array(), |
There was a problem hiding this comment.
@aitboudad While backporting the Translator test case refactorings to the 2.6 branch, I noticed that the test for this fails because we don't have that fix on 2.6 yet (different resources still use same cache).
Is that something you would want to fix on 2.6 as well?
There was a problem hiding this comment.
no IMO it's a new feature.
aitboudad
added a commit
that referenced
this pull request
Apr 25, 2015
…r the Translator class (mpdude) This PR was merged into the 2.7 branch. Discussion ---------- [Translator]Test case refactoring and simplifications for the Translator class | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Fixed tickets | ~ | Tests pass? | yes | License | MIT Also see #14280 and #14281. This also tests for the fix in [b5da2ae](b5da2ae#diff-3126bfacb25e1e304b8cc720e8527a19) Commits ------- c0300f5 Remaining tweaks for translator tests on 2.7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it's mainly based on #14268