[Form] Moved deprecation notice triggers to file level #14201
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 3, 2015
262d60b to
c3adce6
Compare
Contributor
Author
|
ping @symfony/deciders |
Member
|
👍 |
Contributor
|
Isnt this not psr2 compilant? |
Member
|
@webmozart You must fix the tests first: currently, there are 2 deprecation notices that are not silenced, making the tests fail: |
Member
|
@staabm we are doing it in many places already. The advantage is that it triggers the deprecation only once even if you create 10 instances (avoiding to spam your logs) and it is triggered even if you overwrite the constructor without calling the parent one. |
c3adce6 to
cd41596
Compare
Contributor
Author
|
@fabpot Thanks for the heads up. This should be fixed now. ping @symfony/deciders |
cd41596 to
de460b9
Compare
Member
|
👍 (rebase needed) |
Contributor
|
we also need another PR solving this too right? DEPRECATED - The FormTypeExtensionInterface::setDefaultOptions()
method is deprecated since version 2.7 and will be removed in 3.0. Use
configureOptions() instead. This method will be added to the FormTypeExtensionInterface
with Symfony 3.0. |
Member
|
ping @webmozart |
Member
|
Closing in favor of #14406 |
fabpot
added a commit
that referenced
this pull request
Apr 19, 2015
This PR was merged into the 2.7 branch. Discussion ---------- Issue4067 class triggers | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - This is #14201 rebased on latest 2.7. This PR moves the deprecation notice triggers introduced in #14050 to file level, as [suggested](#14050 (comment)) by @stof. Commits ------- a3917fc [Form] Removed remaining deprecation notices in the test suite 8f297c1 [Form] Moved deprecation notice triggers to file level
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the deprecation notice triggers introduced in #14050 to file level, as suggested by @stof.