[FrameworkBundle] Move lint commands to lint namespace. #14116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
aitboudad
commented
Mar 30, 2015
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Fixed tickets | ~ |
| Tests pass? | yes |
| License | MIT |
| @@ -35,7 +35,7 @@ class LintCommand extends Command | ||
| /** | ||
| * {@inheritdoc} | ||
| */ | ||
| public function __construct($name = 'twig:lint') | ||
| public function __construct($name = 'lint:twig') |
There was a problem hiding this comment.
Without an alias, this will break now for people relying on the old name.
|
This makes sense to me, just like we grouped the debug commands |
|
@aitboudad You should also trigger a deprecation notice when the old name is used (we've done that already for the debug:* commands). |
|
@fabpot done |
|
Thank you @aitboudad. |
fabpot
added a commit
that referenced
this pull request
Apr 2, 2015
…. (aitboudad) This PR was merged into the 2.7 branch. Discussion ---------- [FrameworkBundle] Move lint commands to lint namespace. | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Fixed tickets | ~ | Tests pass? | yes | License | MIT Commits ------- 8f72338 [FrameworkBundle] Move lint commands to lint namespace.
|
@aitboudad This one broke the tests :( Can you have a look at that ASAP? Thanks. |
|
ok |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.