[DomCrawler] Improve namespace discovery performance #14012
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Up until now xpath axes (child::*, descendant-or-self::** etc) were considered namespaces. As a result, far too many xpath queries were being executed while namespace discovery.
|
Nice! 👍 |
|
👍 @jakzal can it be applied to 2.3 easily ? |
|
💐 |
|
wow, nice |
|
👍 |
1 similar comment
|
👍 |
|
This worked wonders on my script, glad I was of (some) help. 👍 |
|
@stof it doesn't affect 2.3. Namespace discovery was introduced later. |
|
Thank you @jakzal. |
fabpot
added a commit
that referenced
this pull request
Mar 23, 2015
This PR was merged into the 2.6 branch. Discussion ---------- [DomCrawler] Improve namespace discovery performance | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #12298 | License | MIT | Doc PR | - Before this quick-fix, xpath axes like `child::*` or `descendant-or-self::*` were considered namespaces. As a result, far too many xpath queries were being executed during namespace discovery. Here's a full blackfire before/after comparision of @salaman's script: https://blackfire.io/profiles/compare/a80b9e77-8e55-45d3-a348-7d34a51053b6/graph  Commits ------- b6af002 [DomCrawler] Improve namespace discovery performance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this quick-fix, xpath axes like
child::*ordescendant-or-self::*were considered namespaces. As a result, far too many xpath queries were being executed during namespace discovery.Here's a full blackfire before/after comparision of @salaman's script: https://blackfire.io/profiles/compare/a80b9e77-8e55-45d3-a348-7d34a51053b6/graph