Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[2.7] Changed visibility of setUp() and tearDown to protected #13903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 13, 2015
Merged

[2.7] Changed visibility of setUp() and tearDown to protected #13903

merged 1 commit into from
Mar 13, 2015

Conversation

saro0h
Copy link
Contributor

@saro0h saro0h commented Mar 11, 2015

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets ~
License MIT
Doc PR ~

@stof
Copy link
Member

stof commented Mar 12, 2015

This should include only the changes specific to the 2.7 branch, not all methods already fixed for the 2.3 or 2.6 branches

@saro0h saro0h force-pushed the change-visibility-teardown-setup branch from 133bb6f to 9ad6bb1 Compare March 13, 2015 09:49
@saro0h saro0h force-pushed the change-visibility-teardown-setup branch from 9ad6bb1 to a818ab2 Compare March 13, 2015 10:00
@nicolas-grekas
Copy link
Member

Thank you @saro0h.

@nicolas-grekas nicolas-grekas merged commit a818ab2 into symfony:2.7 Mar 13, 2015
nicolas-grekas added a commit that referenced this pull request Mar 13, 2015
@nicolas-grekas
minor #13903 [2.7] Changed visibility of setUp() and tearDown to prot…
de658e7 
…ected (saro0h)

This PR was merged into the 2.7 branch.

Discussion
----------

[2.7] Changed visibility of setUp() and tearDown to protected

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | ~
| License       | MIT
| Doc PR        | ~

Commits
-------

a818ab2 Changed visibility of setUp() and tearDown to protected
@saro0h saro0h deleted the change-visibility-teardown-setup branch March 13, 2015 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saro0h @stof @nicolas-grekas
Morty Proxy This is a proxified and sanitized view of the page, visit original site.