Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

@Tobion
Copy link
Contributor

@Tobion Tobion commented Feb 27, 2015

Q A
Bug fix? no
New feature? no
BC breaks? yes
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR -

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to add trigger errors for that in 2.7 which has been forgotten

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done #13809

@stof
Copy link
Member

stof commented Feb 28, 2015

You forgot to remove the OptionsResolverInterface here

@Tobion
Copy link
Contributor Author

Tobion commented Feb 28, 2015

@stof it has already been removed by another PR

@Tobion Tobion force-pushed the options-resolver-remove-deprecations branch from e746b2a to 295bba2 Compare March 2, 2015 10:30
@Tobion Tobion merged commit 295bba2 into symfony:master Mar 2, 2015
Tobion added a commit that referenced this pull request Mar 2, 2015
…bion)

This PR was merged into the 3.0-dev branch.

Discussion
----------

[OptionsResolver] removed deprecated functionality

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | yes
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        | -

Commits
-------

295bba2 [OptionsResolver] removed deprecated functionality
@Tobion Tobion deleted the options-resolver-remove-deprecations branch March 2, 2015 11:07
@fabpot fabpot mentioned this pull request Nov 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.