[CssSelector] Use the correct cssselect library name in docblocks. #13132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original python library is called cssselect, not cssselector.
The last rewrite is based on the cssselect which is no longer part of lxml, but was extracted as an independent library.
|
Thank you @jakzal. |
fabpot
added a commit
that referenced
this pull request
Dec 27, 2014
…docblocks. (jakzal) This PR was merged into the 2.3 branch. Discussion ---------- [CssSelector] Use the correct cssselect library name in docblocks. | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | no | Fixed tickets | #11894 | License | MIT | Doc PR | - As suggested in #11894, the original python library is called [cssselect](https://github.com/SimonSapin/cssselect), not cssselector. I also updated the README, as the cssselect was extracted as an independent library and it's no longer part of lxml. Commits ------- 55f0d9e Update the note about origins of the CssSelector component. 1997b12 Use the correct cssselect library name in docblocks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in #11894, the original python library is called cssselect, not cssselector.
I also updated the README, as the cssselect was extracted as an independent library and it's no longer part of lxml.