[3.0][Form] Removed depracted events PRE_BIND, BIND and POST_BIND #13122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
saro0h
commented
Dec 26, 2014
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | yes |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | ~ |
| License | MIT |
| Doc PR | ~ |
896f1ce to
a430ff9
Compare
|
👍 |
| })); | ||
|
|
||
| $config = new FormConfigBuilder('name', null, $this->dispatcher); | ||
| $config->addEventListener(FormEvents::PRE_BIND, array($mock, 'preBind')); |
There was a problem hiding this comment.
This test should not be removed. It should simply use the new constant (and changing the constant being used should be done in older branches actually)
83d00c9 to
b2a93b0
Compare
| @@ -118,23 +118,23 @@ public function testDataIsInitializedFromSubmit() | ||
| $form->submit('foobar'); | ||
| } | ||
|
|
||
| // https://github.com/symfony/symfony/pull/7789 | ||
| // https://github.com/symfony/symfony/pull/7789 |
b2a93b0 to
a7fe849
Compare
|
Changes have been made. |
|
Can you rebase to re-run the tests? |
6b1845d to
cce7d94
Compare
cce7d94 to
1cdb655
Compare
|
Done. The tests do not pass because of that: https://travis-ci.org/symfony/symfony/jobs/45787598#L2208 |
|
Thank you @saro0h. |
fabpot
added a commit
that referenced
this pull request
Jan 3, 2015
…d POST_BIND (saro0h) This PR was merged into the 3.0-dev branch. Discussion ---------- [3.0][Form] Removed depracted events PRE_BIND, BIND and POST_BIND | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | yes | Deprecations? | no | Tests pass? | yes | Fixed tickets | ~ | License | MIT | Doc PR | ~ Commits ------- 1cdb655 [Form] Removed depracted events PRE_BIND, BIND and POST_BIND
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.