Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[Console] Removed DialogHelper, ProgressHelper and TableHelper #13121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 30, 2014

Conversation

saro0h
Copy link
Contributor

@saro0h saro0h commented Dec 26, 2014

Q A
Bug fix? no
New feature? no
BC breaks? yes
Deprecations? no
Tests pass? yes
Fixed tickets ~
License MIT
Doc PR ~
  • Adapt output in fixtures according to the standard display with table.

@saro0h saro0h force-pushed the remove-console-helper branch 6 times, most recently from ce13d98 to 74c258d Compare December 26, 2014 13:37
@saro0h saro0h force-pushed the remove-console-helper branch from 74c258d to dfb9706 Compare December 26, 2014 13:45
@saro0h
Copy link
Contributor Author

saro0h commented Dec 26, 2014

@nicolas-grekas : The tests are ok, but not ok :/ Do you have an idea why travis is saying that the tests are not ok ?

@nicolas-grekas
Copy link
Member

Green tests are only for 2.x branches. master is not ready to be worked on...

@saro0h
Copy link
Contributor Author

saro0h commented Dec 26, 2014

Yep I saw, but we are almost there! :) Look at that https://travis-ci.org/symfony/symfony/builds/45150843

Don't you think we could deactivate tests for 3.x in php 5.3 ?

@stof
Copy link
Member

stof commented Dec 29, 2014

@saro0h 5.3 and 5.4 were disabled previously because of the new minimum version, but this got lost because of the config refactoring done by @nicolas-grekas

@fabpot
Copy link
Member

fabpot commented Dec 30, 2014

Thank you @saro0h.

@fabpot fabpot merged commit dfb9706 into symfony:master Dec 30, 2014
fabpot added a commit that referenced this pull request Dec 30, 2014
…leHelper (saro0h)

This PR was merged into the 3.0-dev branch.

Discussion
----------

[Console] Removed DialogHelper, ProgressHelper and TableHelper

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | yes
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | ~
| License       | MIT
| Doc PR         | ~

- [X]  Adapt output in fixtures according to the standard display with table.

Commits
-------

dfb9706 [Console] Removed DialogHelper, ProgressHelper and TableHelper
@saro0h saro0h deleted the remove-console-helper branch January 1, 2015 22:14
fabpot added a commit that referenced this pull request Jan 6, 2015
…aro0h)

This PR was merged into the 2.7 branch.

Discussion
----------

[2.7][FrameworkBundle] Removed the use of TableHelper

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | ~
| License       | MIT
| Doc PR        | ~

The PR #13121 on 3.0 removed the ``TableHelper `` class. Now the tests don't pass when using ``components=high`` version of dependencis, because of the use of the deprecated TableHelper.

This one removes the use of ``TableHelper`` without the removal of the ``TableHelper`` class, and adapt the existing code to use the Table class instead.

Commits
-------

08a5b5a [FrameworkBundle] Removed the use of TableHelper
@fabpot fabpot mentioned this pull request Nov 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.