[Console] Removed DialogHelper, ProgressHelper and TableHelper #13121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
saro0h
commented
Dec 26, 2014
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | yes |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | ~ |
| License | MIT |
| Doc PR | ~ |
- Adapt output in fixtures according to the standard display with table.
ce13d98 to
74c258d
Compare
74c258d to
dfb9706
Compare
|
@nicolas-grekas : The tests are ok, but not ok :/ Do you have an idea why travis is saying that the tests are not ok ? |
|
Green tests are only for 2.x branches. master is not ready to be worked on... |
|
Yep I saw, but we are almost there! :) Look at that https://travis-ci.org/symfony/symfony/builds/45150843 Don't you think we could deactivate tests for 3.x in php 5.3 ? |
|
@saro0h 5.3 and 5.4 were disabled previously because of the new minimum version, but this got lost because of the config refactoring done by @nicolas-grekas |
|
Thank you @saro0h. |
fabpot
added a commit
that referenced
this pull request
Dec 30, 2014
…leHelper (saro0h) This PR was merged into the 3.0-dev branch. Discussion ---------- [Console] Removed DialogHelper, ProgressHelper and TableHelper | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | yes | Deprecations? | no | Tests pass? | yes | Fixed tickets | ~ | License | MIT | Doc PR | ~ - [X] Adapt output in fixtures according to the standard display with table. Commits ------- dfb9706 [Console] Removed DialogHelper, ProgressHelper and TableHelper
fabpot
added a commit
that referenced
this pull request
Jan 6, 2015
…aro0h) This PR was merged into the 2.7 branch. Discussion ---------- [2.7][FrameworkBundle] Removed the use of TableHelper | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | ~ | License | MIT | Doc PR | ~ The PR #13121 on 3.0 removed the ``TableHelper `` class. Now the tests don't pass when using ``components=high`` version of dependencis, because of the use of the deprecated TableHelper. This one removes the use of ``TableHelper`` without the removal of the ``TableHelper`` class, and adapt the existing code to use the Table class instead. Commits ------- 08a5b5a [FrameworkBundle] Removed the use of TableHelper
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.