[Translation] Refresh catalogues when resources change #13074
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 Btw. Test are missing. |
|
👍 |
| $this->catalogues[$locale] = include $cache; | ||
| list($catalogue, $resourcesHash) = include $cache; | ||
|
|
||
| if ($this->debug && ($resourcesHash !== $this->getResourcesHash($locale))) { |
There was a problem hiding this comment.
parenthesis on the second condition are not needed and should be removed.
832e3f2 to
8659ab9
Compare
8659ab9 to
1113999
Compare
|
Added unit test |
|
Thank you @iamluc. |
fabpot
added a commit
that referenced
this pull request
Feb 5, 2015
… (iamluc) This PR was merged into the 2.7 branch. Discussion ---------- [Translation] Refresh catalogues when resources change | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #11530 | License | MIT | Doc PR | no When a translation file is added in a bundle, the container is refreshed thanks to a DirectoryResource watching for changes. But the translator has his own cache that is not refreshed. This PR adds a hash check when cached is used. Commits ------- 1113999 Refresh catalogues when resources change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a translation file is added in a bundle, the container is refreshed thanks to a DirectoryResource watching for changes.
But the translator has his own cache that is not refreshed.
This PR adds a hash check when cached is used.