Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[Form][WebProfiler] Fixed issue#10054 : cannot report form data when "allow_add" is true in a field #12889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

[Form][WebProfiler] Fixed issue#10054 : cannot report form data when "allow_add" is true in a field #12889

wants to merge 5 commits into from

Conversation

HeahDude
Copy link
Contributor

@HeahDude HeahDude commented Dec 7, 2014

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #10054
License MIT
Doc PR @WebProfilerBundle:Collector:form.html.twig, without checking if data.type is defined on line 423, web profiler crash to report form data when "allow_add" is true.

@HeahDude
Update form.html.twig
166e1b5 
{% if data.type is defined and data.type is not empty %}

Without check if defined web profiler crash to report form data on line 423.

check the topic symfony#10054
@fabpot fabpot added the Form label Dec 7, 2014
@HeahDude HeahDude closed this Dec 8, 2014
@HeahDude HeahDude reopened this Dec 8, 2014
@HeahDude HeahDude closed this Dec 8, 2014
@jakzal
Copy link
Contributor

jakzal commented Dec 8, 2014

@HeahDude why did you close?

@HeahDude
Copy link
Contributor Author

HeahDude commented Dec 8, 2014

@jakzal I'm trying to follow these instructions first cause I'm having errors. Sorry I'm new to symfony, I discovered it 3 weeks ago and I really enjoy developing my first project with it. I'm reading GitHub documentation and once I've managed to do it right I will reopen it.

@HeahDude HeahDude reopened this Dec 8, 2014
@HeahDude HeahDude changed the title Update form.html.twig bug fixed : #10054 with update @WebProfilerBundle:Collector:form.html.twig Dec 8, 2014
@HeahDude HeahDude changed the title bug fixed : #10054 with update @WebProfilerBundle:Collector:form.html.twig bug_fixed_#10054 Dec 8, 2014
@jakzal
Copy link
Contributor

jakzal commented Dec 8, 2014

@HeahDude no problem, don't forget to include the table from http://symfony.com/fr/doc/current/contributing/code/patches.html#faites-une-pull-request (edit the description of this PR)

Would be also good if you described how web profiler fails (paste the stack trace perhaps).

@HeahDude HeahDude changed the title bug_fixed_#10054 [Form][WebProfiler] cannot report form data when "allow_add" is true in a field Dec 8, 2014
@HeahDude HeahDude changed the title [Form][WebProfiler] cannot report form data when "allow_add" is true in a field [Form][WebProfiler] Fixed : cannot report form data when "allow_add" is true in a field Dec 8, 2014
@HeahDude HeahDude changed the title [Form][WebProfiler] Fixed : cannot report form data when "allow_add" is true in a field [Form][WebProfiler] Fixed : cannot report form data when "allow_add" is true in a field issue#10054 Dec 8, 2014
@HeahDude HeahDude changed the title [Form][WebProfiler] Fixed : cannot report form data when "allow_add" is true in a field issue#10054 [Form][WebProfiler] Fixed issue#10054 : cannot report form data when "allow_add" is true in a field Dec 8, 2014
@xabbuh xabbuh mentioned this pull request Dec 10, 2014
Closed
@HeahDude
[2.6][Form][WebProfiler] Fixed issue#10054
f8393bf 
| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | symfony#10054
| License       | MIT
| Doc PR        | @WebProfilerBundle:Collector:form.html.twig, without
checking if data.type is defined on line 423, web profiler crash to
report form data when "allow_add" is true.
@HeahDude
[2.6][Form][WebProfiler] Fixed issue#10054"
8a51223 
This reverts commit f8393bf.
@xabbuh xabbuh mentioned this pull request Dec 11, 2014
Closed
@HeahDude
[Form][WebProfiler] Fixed bug for symfony#12949
4faf9ec 
| Q             | A
| ------------- | ---
| Fixed tickets | symfony#12949
| License       | MIT
@xabbuh
Copy link
Member

xabbuh commented Dec 12, 2014

@HeahDude Looking at #12950, it seems that you also need to update lines 440 and 545.

@HeahDude
Copy link
Contributor Author

@xabbuh there is a comment from @stof suggesting that it could be wrong to have the same id in multiple <div>

@xabbuh
Copy link
Member

xabbuh commented Dec 12, 2014

@HeahDude That's right, but you can avoid this by putting the condition around the complete id attribute like this:

{% if data.id is defined %} id="{{ data.id }}-details"{% endif %}

@xabbuh
Copy link
Member

xabbuh commented Dec 12, 2014

@HeahDude Never mind, I just noticed that this is how the code actually looks like.

@xabbuh
Copy link
Member

xabbuh commented Dec 12, 2014

But it's needed in line 545.

@HeahDude
Copy link
Contributor Author

@xabbuh noted :) thanks

@fabpot
Copy link
Member

fabpot commented Dec 21, 2014

Closing in favor of #13027

@fabpot fabpot closed this Dec 21, 2014
@xabbuh xabbuh mentioned this pull request Dec 30, 2014
Merged
@HeahDude HeahDude deleted the patch-1 branch January 5, 2015 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Form
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@HeahDude @jakzal @xabbuh @fabpot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.