Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[HttpKernel] Fix UriSigner::check when _hash is not at the end of the uri #12574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from
Closed

[HttpKernel] Fix UriSigner::check when _hash is not at the end of the uri #12574

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
6168de1
Fix UriSigner::check when _hash is not at the end of the uri
nyroDev Nov 25, 2014
6853d5f
Remove tab space into spaces
nyroDev Nov 25, 2014
1137c84
Use empty intead of isset
nyroDev Nov 25, 2014
116c6df
Remove empty spaces at end of lines
nyroDev Nov 25, 2014
0093235
Remove empty spaces at end of lines
nyroDev Nov 25, 2014
7cd4ec8
Change sign function and check function in order to order parameters …
nyroDev Nov 26, 2014
969f45f
Remove unusuful whitespace
nyroDev Nov 26, 2014
8a46d7b
Remove unusuful whitespace
nyroDev Nov 26, 2014
8aac229
Naturally sort paramaters to follow amazon AWS ordering rule
nyroDev Nov 27, 2014
bc34dc5
Remove SORT_NATURAL as it's seems to be the default order anyway and …
nyroDev Nov 27, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove empty spaces at end of lines
  • Loading branch information
@nyroDev
nyroDev committed Nov 25, 2014
commit 116c6dfa772798200c9af9a0cd03ac441a026f00
16 changes: 8 additions & 8 deletions 16 src/Symfony/Component/HttpKernel/UriSigner.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,15 +74,15 @@ public function check($uri)

$url['query'] = http_build_query($params);

$scheme = isset($url['scheme']) ? $url['scheme'] . '://' : '';
$scheme = isset($url['scheme']) ? $url['scheme'].'://' : '';
$host = isset($url['host']) ? $url['host'] : '';
$port = isset($url['port']) ? ':' . $url['port'] : '';
$user = isset($url['user']) ? $url['user'] : '';
$pass = isset($url['pass']) ? ':' . $url['pass'] : '';
$pass = ($user || $pass) ? "$pass@" : '';
$path = isset($url['path']) ? $url['path'] : '';
$query = isset($url['query']) && $url['query'] ? '?' . $url['query'] : '';
$fragment = isset($url['fragment']) ? '#' . $url['fragment'] : '';
$port = isset($url['port']) ? ':'.$url['port'] : '';
$user = isset($url['user']) ? $url['user'] : '';
$pass = isset($url['pass']) ? ':'.$url['pass'] : '';
$pass = ($user || $pass) ? "$pass@" : '';
$path = isset($url['path']) ? $url['path'] : '';
$query = isset($url['query']) && $url['query'] ? '?'.$url['query'] : '';
$fragment = isset($url['fragment']) ? '#'.$url['fragment'] : '';
$testUrl = $scheme.$user.$pass.$host.$port.$path.$query.$fragment;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could use http_build_url to generate the URL

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its only available as an extension


return $this->computeHash($testUrl) === $hash;
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.