Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[Validator] Added missing error codes and turned codes into UUIDs #12388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 22 commits into from
Closed
Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
0642911
[FrameworkBundle] Add a doctrine cache service definition for validat…
jakzal Apr 21, 2015
b93bcc1
Fixed colspan issues with multiple render() calls
jaytaph Jun 14, 2015
f42c777
[Form] moved data trimming logic of TrimListener into StringUtil
issei-m Jun 20, 2015
3151614
feature #14660 [Form] moved data trimming logic of TrimListener into …
webmozart Jun 22, 2015
9f86195
feature #14991 [Console][Table] allow multiple render() calls. (jaytaph)
fabpot Jun 22, 2015
dd7583d
feature #14429 [FrameworkBundle] Add a doctrine cache service definit…
fabpot Jun 23, 2015
f360758
[Debug] Allow throwing from __toString() with `return trigger_error($…
nicolas-grekas Jun 22, 2015
6c4a676
Add "shared" flag and deprecate scopes concept
dosten Jun 15, 2015
50e752b
feature #14984 [DependencyInjection] Deprecate scope concept (dosten)
fabpot Jun 24, 2015
b7030cc
Make service not shared when prototype scope is set
wouterj Jun 24, 2015
bd66434
minor #15091 [2.8] Make service not shared when prototype scope is se…
Tobion Jun 24, 2015
93e69e4
feature #15076 [Debug] Allow throwing from __toString() with `return …
nicolas-grekas Jun 25, 2015
d144dbb
[DependencyInjection] improve deprecation messages
xabbuh Jun 26, 2015
03e96d2
minor #15113 [2.8][DependencyInjection] improve deprecation messages …
fabpot Jun 27, 2015
1583fad
add option to force web server startup
xabbuh Jun 28, 2015
1df4ebe
added remove option to ignoreExtraKeys
Apr 6, 2015
674b124
feature #14238 [config] added remove option to ignoreExtraKeys (twifty)
fabpot Jun 28, 2015
268210b
fixed CS
fabpot Jun 28, 2015
ffed0ce
feature #15134 [FrameworkBundle] add option to force web server start…
fabpot Jun 30, 2015
96cce38
Warmup twig templates in non-standard paths (closes #12507)
kbond May 27, 2015
cad16ac
feature #14764 [TwigBundle] Warmup twig templates in non-standard pat…
fabpot Jun 30, 2015
cb9c069
[Validator] Added missing error codes and turned codes into UUIDs
webmozart Nov 3, 2014
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions 4 src/Symfony/Component/DependencyInjection/Definition.php
Original file line number Diff line number Diff line change
Expand Up @@ -649,6 +649,10 @@ public function setScope($scope, $triggerDeprecationError = true)
@trigger_error('The '.__METHOD__.' method is deprecated since version 2.8 and will be removed in 3.0.', E_USER_DEPRECATED);
}

if (ContainerInterface::SCOPE_PROTOTYPE === $scope) {
$this->setShared(false);
}

$this->scope = $scope;

return $this;
Expand Down
13 changes: 13 additions & 0 deletions 13 src/Symfony/Component/DependencyInjection/Tests/DefinitionTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
namespace Symfony\Component\DependencyInjection\Tests;

use Symfony\Component\DependencyInjection\Definition;
use Symfony\Component\DependencyInjection\ContainerInterface;

class DefinitionTest extends \PHPUnit_Framework_TestCase
{
Expand Down Expand Up @@ -139,6 +140,18 @@ public function testSetIsShared()
$this->assertFalse($def->isShared(), '->isShared() returns false if the instance must not be shared');
}

/**
* @group legacy
*/
public function testPrototypeScopedDefinitionAreNotShared()
{
$def = new Definition('stdClass');
$def->setScope(ContainerInterface::SCOPE_PROTOTYPE);

$this->assertFalse($def->isShared());
$this->assertEquals(ContainerInterface::SCOPE_PROTOTYPE, $def->getScope());
}

/**
* @covers Symfony\Component\DependencyInjection\Definition::setScope
* @covers Symfony\Component\DependencyInjection\Definition::getScope
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,6 @@
<configurator class="%baz_class%" method="configureStatic1"/>
</service>
<service id="factory_service" class="Bar" factory-method="getInstance" factory-service="foo.baz"/>
<service id="foo_bar" class="%foo_class%" scope="prototype"/>
<service id="foo_bar" class="%foo_class%" shared="false" scope="prototype"/>
</services>
</container>
Original file line number Diff line number Diff line change
Expand Up @@ -29,4 +29,5 @@ services:
factory_service: foo.baz
foo_bar:
class: %foo_class%
shared: false
scope: prototype
Morty Proxy This is a proxified and sanitized view of the page, visit original site.