Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[Form] Remove timezone options from DateType and TimeType #12380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

jakzal
Copy link
Contributor

@jakzal jakzal commented Nov 2, 2014

Q A
Bug fix? yes
New feature? no
BC breaks? yes
Deprecations? no
Tests pass? yes
Fixed tickets #12239
License MIT
Doc PR todo

I'm not sure if this should actually go to 2.3.

@jakzal jakzal added the Form label Nov 2, 2014
@Tobion
Copy link
Contributor

Tobion commented Nov 2, 2014

We don't merge bc breaks into maintanance braches.

@webmozart
Copy link
Contributor

@jakzal Thanks for that PR! Could you please rebase it onto master?

@webmozart webmozart changed the title Remove timezone options from DateType and TimeType [Form] Remove timezone options from DateType and TimeType Nov 3, 2014
@jakzal
Copy link
Contributor Author

jakzal commented Nov 3, 2014

Sorry, I thought you'll be able to merge it to master anyway. Rebase on its way! :)

@jakzal jakzal closed this Nov 3, 2014
@jakzal jakzal deleted the remove-timezone-options branch November 3, 2014 20:42
fabpot added a commit that referenced this pull request Nov 16, 2014
…ype (jakzal)

This PR was submitted for the master branch but it was merged into the 2.6 branch instead (closes #12404).

Discussion
----------

[Form] Remove timezone options from DateType and TimeType

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | yes
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #12239
| License       | MIT
| Doc PR        | symfony/symfony-docs#4417

replaces #12380

Commits
-------

849fb29 Drop support for model_timezone and view_timezone options in TimeType and DateType.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.