Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[VarDumper] add meta-data on hover #12256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 21, 2014
Merged

Conversation

nicolas-grekas
Copy link
Member

Q A
Bug fix? yes
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

This PR adds meta-data on hover to HTML dumps:

  • strings length
  • constants value
  • control chars code
  • local refs count

@xabbuh
Copy link
Member

xabbuh commented Oct 19, 2014

HtmlDumperTest::testGet() seems to need some more modifications: https://travis-ci.org/symfony/symfony/jobs/38420159#L832

@nicolas-grekas
Copy link
Member Author

Fixed thanks

@nicolas-grekas nicolas-grekas force-pushed the meta-titles branch 2 times, most recently from da2d16a to 0152a4f Compare October 20, 2014 08:14
@fabpot
Copy link
Member

fabpot commented Oct 20, 2014

screenshot?

@nicolas-grekas
Copy link
Member Author

dumper-hover

@fabpot
Copy link
Member

fabpot commented Oct 21, 2014

Thank you @nicolas-grekas.

@fabpot fabpot merged commit bef48b3 into symfony:master Oct 21, 2014
fabpot added a commit that referenced this pull request Oct 21, 2014
This PR was merged into the 2.6-dev branch.

Discussion
----------

[VarDumper] add meta-data on hover

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

This PR adds meta-data on hover to HTML dumps:
- strings length
- constants value
- control chars code
- local refs count

Commits
-------

bef48b3 [VarDumper] add meta-data on hover
@nicolas-grekas nicolas-grekas deleted the meta-titles branch October 22, 2014 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.