#11652 [HttpKernel] Remove unused method Kernel::isClassInActiveBundle #11869
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hacfi
commented
Sep 6, 2014
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | yes, deprecation targets 3.0 |
| Deprecations? | yes |
| Tests pass? | yes |
| Fixed tickets | #11652 |
| License | MIT |
| Doc PR | - (Not mentioned in the docs) |
| */ | ||
| public function isClassInActiveBundle($class) | ||
| { | ||
| trigger_error('isClassInActiveBundle is deprecated since version 2.6 and will be removed in 3.0.', E_USER_DEPRECATED); |
There was a problem hiding this comment.
We don't add trigger_error yet. We will add it only in the last 2.x release
|
you should not remove the tests even if the method is deprecated |
|
Thanks for the feedback @stof ! Updated. |
|
👍 |
| @@ -13,6 +13,9 @@ | ||
|
|
||
| use Symfony\Component\HttpKernel\Bundle\Bundle; | ||
|
|
||
| /** | ||
| * @deprecated Deprecated since version 2.6, to be removed in 3.0. |
There was a problem hiding this comment.
we don't deprecate fixtures. It is not needed as this is not part of the public codebase but of the testsuite
|
@stof Thanks - updated! I thought it would be good to mark them so they aren’t forgotten when removing the code. |
|
👍 |
|
Thank you @hacfi. |
fabpot
added a commit
that referenced
this pull request
Sep 8, 2014
…ssInActiveBundle (hacfi) This PR was squashed before being merged into the 2.6-dev branch (closes #11869). Discussion ---------- #11652 [HttpKernel] Remove unused method Kernel::isClassInActiveBundle | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | yes, deprecation targets 3.0 | Deprecations? | yes | Tests pass? | yes | Fixed tickets | #11652 | License | MIT | Doc PR | - (Not mentioned in the docs) Commits ------- 86873f2 #11652 [HttpKernel] Remove unused method Kernel::isClassInActiveBundle
fabpot
added a commit
that referenced
this pull request
Sep 8, 2014
…ssInActiveBundle (hacfi) This PR was squashed before being merged into the 2.6-dev branch (closes #11869). Discussion ---------- #11652 [HttpKernel] Remove unused method Kernel::isClassInActiveBundle | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | yes, deprecation targets 3.0 | Deprecations? | yes | Tests pass? | yes | Fixed tickets | #11652 | License | MIT | Doc PR | - (Not mentioned in the docs) Commits ------- a777fd7 #11652 [HttpKernel] Remove unused method Kernel::isClassInActiveBundle
hacfi
added a commit
to hacfi/symfony
that referenced
this pull request
Dec 4, 2014
hacfi
added a commit
to hacfi/symfony
that referenced
this pull request
Dec 7, 2014
fabpot
added a commit
that referenced
this pull request
Dec 8, 2014
…tiveBundle() (hacfi) This PR was merged into the 2.7 branch. Discussion ---------- [HttpKernel] Add deprecation log for Kernel::isClassInActiveBundle() | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | #11652 | License | MIT | Doc PR | - (Not mentioned in the docs) See #11869 and #12854 Commits ------- 5ba6d1f [HttpKernel] Add deprecation log for Kernel::isClassInActiveBundle()
fabpot
added a commit
that referenced
this pull request
Dec 20, 2014
…InActiveBundle (hacfi) This PR was merged into the 3.0-dev branch. Discussion ---------- [3.0][HttpKernel] Remove unused method Kernel::isClassInActiveBundle | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | yes, if using isClassInActiveBundle (not used by Symfony itself) | Deprecations? | yes | Tests pass? | yes | Fixed tickets | #11652 | License | MIT | Doc PR | - (Not mentioned in the docs) Follow-up of #11869 Commits ------- 91dcca4 [HttpKernel] Remove unused method Kernel::isClassInActiveBundle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.