Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

bug #10675 [Validator] Fix constraint violation message parameterization #10677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

dnohales
Copy link
Contributor

@dnohales dnohales commented Apr 9, 2014

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #10675
License MIT

This PR fixes an error during the constraint violation message parametrization, more information on the related ticket.

@mayeco
Copy link
Contributor

mayeco commented Apr 9, 2014

I don't think the BC will break, you should put no

@stloyd
Copy link
Contributor

stloyd commented Apr 10, 2014

@eagleoneraptor You need to update tests, as all of them looks to be bugged (see Travis moans =))

Also this should go to 2.3 as this issue occurs there too.

@stof stof added the Validator label Apr 10, 2014
@dnohales
Copy link
Contributor Author

Sorry, @stloyd, this is what happen when one make a patch on the run with the GitHub editor :( , working on that right now.

@dnohales
Copy link
Contributor Author

So, this pull request should go in 2.3 and you later merge into master and 2.4or do I need to create multiple PR?

@stof
Copy link
Member

stof commented Apr 10, 2014

you don't create multiple PRs. We will merge it in 2.3, and then it will propagate to newer versions (this generally requires approximately 1 week).
If there is no conflcit when trying to apply the patch to 2.3 (or if they are easy to resolve), @fabpot will simply change the target of this PR when merging

@webmozart
Copy link
Contributor

Thanks for the PR! I added some more commits and completed the PR in #10687.

@webmozart webmozart closed this Apr 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.