[HttpFoundation][Tests] Add expression request matcher tests #10322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
inelgnu
commented
Feb 24, 2014
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | n/a |
| License | MIT |
| Doc PR | n/a |
|
|
||
| $expressionRequestMatcher->setExpression(new ExpressionLanguage(), 'request.getMethod() != method && request.getPathInfo() == path && request.getHost() == host && request.getClientIp() == ip && request.attributes.all() == attributes'); | ||
| $this->assertFalse($expressionRequestMatcher->matches($request)); | ||
|
|
|
@cordoval i have add data providers. |
| $expressionRequestMatcher->matches(new Request()); | ||
| } | ||
|
|
||
| public function MatchingExpressions() |
|
tres bien 👍 |
| $this->assertFalse($expressionRequestMatcher->matches($request)); | ||
| } | ||
|
|
||
| public function getExpressions() |
There was a problem hiding this comment.
you are not only getting Expressions now but a vector of expressions and their expected matching result so adapt the name accordingly
There was a problem hiding this comment.
provideExpressionData() ?
There was a problem hiding this comment.
I think provideExpressions() would be fine.
There was a problem hiding this comment.
@jakzal done, thank you.
| $expressionRequestMatcher = new ExpressionRequestMatcher(); | ||
|
|
||
| $expressionRequestMatcher->setExpression(new ExpressionLanguage(), $expression); | ||
| $this->assertEquals($expressionRequestMatcher->matches($request), $expected); |
There was a problem hiding this comment.
Wrong order of the arguments for all assertions.
There was a problem hiding this comment.
should be same as $expected is a Boolean.
fabpot
added a commit
that referenced
this pull request
Mar 3, 2014
…ests (inalgnu) This PR was submitted for the 2.4-dev branch but it was merged into the 2.4 branch instead (closes #10322). Discussion ---------- [HttpFoundation][Tests] Add expression request matcher tests | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Commits ------- 76fe21d [HttpFoundation][Tests] add expression request matcher tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.