[Form] Fixed bug that incorrectly causes the "required" attribute to be ... #10089
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…be omitted from select even though it contains the "multiple" attribute
|
@NickStemerdink Can you make the same change in the PHP template and add some unit tests to cover this case? Thanks. |
added 2 commits
January 25, 2014 15:53
- Updated unit tests (also added the "required" attribute to make it more obvious that the form is required)
|
@fabpot Done |
|
ping @fabpot @webmozart |
|
merged via #10491 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...omitted from select even though it contains the "multiple" attribute.
According to the HTML5 specification the required attribute should be allowed in this case: "A select element with a required attribute and without a multiple attribute, and whose size is “1”, must have a child option element."
Related PR: #9030