Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Streamline one more exception for the bridges regarding option classes #59120

Copy link
Copy link
Closed
@OskarStark

Description

@OskarStark
Issue body actions

Take for example the GoIpTransport, it contains the following lines:

if (($options = $message->getOptions()) && !$options instanceof GoIpOptions) {
throw new LogicException(\sprintf('The "%s" transport only supports an instance of the "%s" as an option class.', __CLASS__, GoIpOptions::class));
}

I would like to have a dedicated exception class UnsupportedOptionsException, basically the same as I did in

This could be done for all bridges which already use options.

Note

It is important to also raise the notifier version to 7.3 in the composer.json files where this new exception is used.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Good first issueIdeal for your first contribution! (some Symfony experience may be required)Ideal for your first contribution! (some Symfony experience may be required)Hack DayNotifier

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Morty Proxy This is a proxified and sanitized view of the page, visit original site.