Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[Notifier] Some Transport aren't using event dispatcher #52997

Copy link
Copy link
Closed
@rdavaillaud

Description

@rdavaillaud
Issue body actions

Symfony version(s) affected

5.4, 6.4, 7.x

Description

Some Notifier transport factories are redefining the class constructor, but aren't passing the HttpClient nor the EventDispatcher.
As a result, those transports are not providing Notifier event hooks.
I think they should in order to act the same as other.

  • MercureTransportFactory
  • FakeSmsTransportFactory
  • FakeChatTransportFactory

How to reproduce

Use FakeSms bridge, and add an event listener on MessageEvent::class.

Possible Solution

PR added

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Morty Proxy This is a proxified and sanitized view of the page, visit original site.