Closed
Description
Hello,
Since #41163 and #43133 I think #40761 is not needed anymore.
TL;DR:
- [Mesenger] Add support for reseting container services between 2 messages #41163 In Symfony 5.4 a new system could reset the container between each (AMQP, redis, etc) message. This works by using ServiceResetter between each message (in a worker only)
- [Messenger] Move container resetting after receiver acknowledging #43133 In symfony 5.4, a deprecation notice appear to force user to enable
reset_on_message
(disabled by default to be BC). - In symfony 6.0 the value will be true
- [MonologBridge] Reset loggers on workers #40761 Introduce a way to reset monolog between each message
- Everything has been introduced in SF 5.4 (not released, so it's now or never)
=> The first feature embrace the the last one, and will be shipped by default.
That's why I propose to remove all code related to #40761.
@l-vo I'm deeply sorry for trying to remove your code. I know it's really unpleasant when someone want to remove our code. But in this case, I think it's legit. It simplifies the Symfony code base, project configuration, and documentation.
If everyone is OK, I'll work on a PR.
Metadata
Metadata
Assignees
Labels
RFC = Request For Comments (proposals about features that you want to be discussed)RFC = Request For Comments (proposals about features that you want to be discussed)