Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[DependencyInjection] [Routing] BC break: router.request_context.base_url with key:path:url: doesn't work anymore in configuration since 5.2.7 #43258

Copy link
Copy link
Closed
@amouhzi

Description

@amouhzi
Issue body actions

Symfony version(s) affected: ^4.4.22, ^5.2.7 and ^5.3.0

Description
Since the commit 2876c we can no longer use URL Env Var Processor functionality to fill router.request_context.base_url in the configuration, because the method Symfony\Component\Routing\RequestContext::fromUri does not accept null.

How to reproduce
To reproduce this we can set an environment variable: ROUTER_REQUEST_CONTEXT_URL with a url like: https://symfony.com with nothing as a path, then set some parameters like:

parameters:
    router.request_context.host: '%env(string:key:host:url:ROUTER_REQUEST_CONTEXT_URL)%'
    router.request_context.scheme: '%env(string:key:scheme:url:ROUTER_REQUEST_CONTEXT_URL)%'
    router.request_context.base_url: '%env(string:key:path:url:ROUTER_REQUEST_CONTEXT_URL)%'

Possible Solution
Two possible solutions:

  • Rollback the commit
  • Make Symfony\Component\Routing\RequestContext::fromUr accepts null.

Error as shown in console

CRITICAL  [php] Uncaught Error: Symfony\Component\Routing\RequestContext::fromUri(): Argument #1 ($uri) must be of type
string, null given, called in /home/me/myProject/var/cache/dev/ContainerXfMbE5x/App_KernelDevDebugContainer.php on line
2098

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Morty Proxy This is a proxified and sanitized view of the page, visit original site.