Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[Notifier] Extend FakeSms & FakeChat notifierΒ #40625

Copy link
Copy link
Closed
@OskarStark

Description

@OskarStark
Issue body actions

Based on this comment

  • fakesms+email should receive a mailer service id βœ… see initial PR [Notifier] [FakeSms] Add the bridgeΒ #39949
  • fakesms+logger should receive a logger service id + an optional channel ?? πŸ€”
  • fakesms+database should receive an entity manager service id + options ?? πŸ€”

And we end up with one Factory (like https://github.com/symfony/symfony/blob/5.x/src/Symfony/Component/Mailer/Bridge/Amazon/Transport/SesTransportFactory.php) and 6 transports

As another follow up we could create a symfony/fake-chat-notifier:

@JamesHemery @noniagriconomie @ke20 anybody? πŸ˜„

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Morty Proxy This is a proxified and sanitized view of the page, visit original site.