Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Performance regression of Symfony DI since v5.0.2 #37401

Copy link
Copy link
Closed
@kocsismate

Description

@kocsismate
Issue body actions

Symfony version affected: 5.1.2

Description

I noticed that there is a huge performance regression of Symfony DI since 5.0.2 according to my benchmarks (https://github.com/kocsismate/php-di-container-benchmarks). The last time I generated the results, Symfony was the clear winner in most of the tests, but now, half a year later, Symfony's performance decreased dramatically, while the results of the other contenders didn't change significantly.

The difference can be observed by looking at the last two benchmark reports:

How to reproduce

You can run the test suite, following the steps detailed in the project's readme.

Possible Solution

Container as well as infrastructure configuration didn't change much since the two benchmark runs, so I would search for the source of issue somewhere else. After a quick look of the generated containers, I noticed that include_once invocations changed place in the meanwhile, and now they are always performed when a service is retrieved. Maybe this can be blamed for the regression?

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Morty Proxy This is a proxified and sanitized view of the page, visit original site.