Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Allow returning null from NormalizerInterface::normalize #34340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fabpot merged 1 commit into from
Nov 13, 2019
Merged

Allow returning null from NormalizerInterface::normalize #34340

fabpot merged 1 commit into from
Nov 13, 2019

Conversation

@teohhanhui
Copy link
Contributor

@teohhanhui teohhanhui commented Nov 12, 2019

Q A
Branch? 3.4
Bug fix? yes?
New feature? no
Deprecations? no
Tickets N/A
License MIT
Doc PR N/A

Looking at the code, it seems that a normalizer might be called with a null value for $data, and thus it's only sensible that it be allowed to return null too:

symfony/src/Symfony/Component/Serializer/Serializer.php

Lines 141 to 148 in 7064ff3

// If a normalizer supports the given data, use it
if ($normalizer = $this->getNormalizer($data, $format, $context)) {
return $normalizer->normalize($data, $format, $context);
}
if (null === $data || is_scalar($data)) {
return $data;
}

Updating the phpdoc to match.

@teohhanhui teohhanhui requested a review from dunglas as a code owner November 12, 2019 17:56
@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Nov 13, 2019
fabpot pushed a commit that referenced this pull request Nov 13, 2019
@nicolas-grekas
minor #34340 Allow returning null from NormalizerInterface::normalize…
53dc781 
… (teohhanhui)

This PR was merged into the 3.4 branch.

Discussion
----------

Allow returning null from NormalizerInterface::normalize

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes?
| New feature?  | no
| Deprecations? | no
| Tickets       | N/A
| License       | MIT
| Doc PR        | N/A

Looking at the code, it seems that a normalizer might be called with a `null` value for `$data`, and thus it's only sensible that it be allowed to return `null` too:

https://github.com/symfony/symfony/blob/7064ff35f2539e2c915257a50eb37839b485dbeb/src/Symfony/Component/Serializer/Serializer.php#L141-L148

Updating the phpdoc to match.

Commits
-------

1c8edc5 Allow returning null from NormalizerInterface::normalize
@fabpot fabpot merged commit 1c8edc5 into symfony:3.4 Nov 13, 2019
@nicolas-grekas
Copy link
Member

nicolas-grekas commented Nov 13, 2019

Thank you @teohhanhui

@teohhanhui teohhanhui deleted the patch-3 branch November 13, 2019 08:48
@dependabot dependabot bot mentioned this pull request Mar 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@dunglas dunglas Awaiting requested review from dunglas dunglas is a code owner

Assignees

No one assigned

Labels

Bug Status: Reviewed

Projects

None yet

Milestone

3.4

Development

Successfully merging this pull request may close these issues.

4 participants

@teohhanhui @nicolas-grekas @fabpot @carsonbot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.