Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Issues with AbstractTagAwareAdapter #33924

Copy link
Copy link
Closed
@nicolas-grekas

Description

@nicolas-grekas
Issue body actions

I'm having a closer look at the implementation of AbstractTagAwareAdapter. Here are some notes for discussion (/cc @andrerom as the original author):

  • deleteItems() calls doFetch() to get access to the tags stored next to an item. Because the values are stored as ['value' => $item->value, 'tags' => [...]], it means the value is actually unserialized when only the tags are needed. This can be problematic (perf-wise at least).
    That's the reason why TagAwareAdapter stores them under separate keys in the storage. Can we do the same here?
  • doClear($namespace) doesn't clear the tags related to the items found in the namespace when one is provided. For FilesystemTagAwareAdapter that looks fixable. For RedisTagAwareAdapter I'm not sure how involving it could be. We could also consider this not worth fixing: the only side effect is that a value might be invalidated while it shouldn't (because it doesn't have the tag anymore).
  • why use symlinks in FilesystemTagAwareAdapter instead of a single file that lists all item files? Using files would allow fixing doInvalidate, which leaks inodes right now.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Morty Proxy This is a proxified and sanitized view of the page, visit original site.