Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[OptionsResolver] Options not provided by user triggers deprecation #28848

New issue
Copy link
New issue
Copy link
Closed
Closed
[OptionsResolver] Options not provided by user triggers deprecation#28848
Copy link
Labels
OptionsResolver
@ro0NL

Description

@ro0NL
ro0NL
opened on Oct 13, 2018
Issue body actions

Description
Since 4.2 OptionsResolver can deprecate options, however the deprecation is triggered from offsetGet()

symfony/src/Symfony/Component/OptionsResolver/OptionsResolver.php

Line 943 in 9bec1fc

@trigger_error(strtr($deprecationMessage, array('%name%' => $option)), E_USER_DEPRECATED);

Im not sure about this, it causes the deprecation to trigger without even being provided by the user (i.e. when accessing the default value). Shouldnt it be moved to resolve() instead?

ref #27277 cc @yceruto

Metadata

Metadata

Assignees

No one assigned

    Labels

    OptionsResolver

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions
      Morty Proxy This is a proxified and sanitized view of the page, visit original site.