Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[RFC][Profiler] Enhance the performances panel & time collector #27262

Copy link
Copy link
Closed
@ogizanagi

Description

@ogizanagi
Issue body actions

Description

I feel like this panel could benefits from some improvements.
Some of these are actionable right now, but there are some that could be discussed before sending PRs.

For instance:

  • 1. The panel currently shows a set of categories hard-coded in the time.html.twig template, even if no stopwatch event for these occurred (e.g: propel). The event_listener_loading one isn't even used since 2.3:
    capture d ecran 2018-05-14 a 17 05 21
    The time collector could provide the list of categories actually used during the request, so the template would only show them.

  • 2. [HttpKernel] Added support for timings in ArgumentValueResolvers #26833 traces controller argument resolvers since 4.1. But this is not easily identifiable in the panel. We could add a category for it:
    capture d ecran 2018-05-14 a 17 05 39

    👷🚧 Part of this is started in [Messenger][Profiler] Trace middleware execution #27321

  • 3. Disabling some categories by clicking on it would be useful:
    capture d ecran 2018-05-14 a 17 09 35

  • 4. Rendering the graph using a canvas has some drawbacks:

    • no interactivity allowed
    • no text selection allowed
    • we can't use the browser search input to quickly jump to an event
    • the graph has a fixed size, which sometimes leads to truncated events (when the event is a long FQCN like the resolvers ones for instance)

    Perhaps we could switch to an SVG version to solve these limitations.

Do you think these kind of improvements are worth it? Do you have some others in mind?

Metadata

Metadata

Assignees

No one assigned

    Labels

    RFCRFC = Request For Comments (proposals about features that you want to be discussed)RFC = Request For Comments (proposals about features that you want to be discussed)WebProfilerBundle

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Morty Proxy This is a proxified and sanitized view of the page, visit original site.