Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[Cache] CachePoolPrunerPass uses wrong service id in 3.4 #27134

Copy link
Copy link
Closed
@DemonTPx

Description

@DemonTPx
Issue body actions
Q A
Bug report? yes
Feature request? no
BC Break report? no
RFC? no
Symfony version 3.4.9

I was running the cache:pool:prune command and nothing was pruned. I discovered that no pools were added to the command even though I have about 6 of them in my application.

The CachePoolPrunerPass is responsible for adding the pools to the command, but uses the class name of the command to find its service. This might be fine for Symfony 4, but in my 3.4 application it cannot find the service. After I changed the service id to console.command.cache_pool_prune the compiler pass worked correctly again and I could prune my cache pools.

I could make a PR for this, but I think it might break it on Symfony 4. What would be the best way to proceed with this?

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Morty Proxy This is a proxified and sanitized view of the page, visit original site.