Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[filesystem] copy_on_windows option for mirror() is misleading #25798

Copy link
Copy link
Open
@SamMousa

Description

@SamMousa
Issue body actions
Q A
Bug report? yes
Feature request? no
BC Break report? no
RFC? no
Symfony version ^4.0

The option copy_on_windows suggests the option is either Windows only or behaves differently for Windows.
As far as I can tell all the option does is enable symlink traversal. Symlink traversal can make sense on other OSes as well:

  • The symlink might contain a relative path, in which case ignorantly copying it will break stuff.
  • I might be copying to a different drive (for example copying something to an USB drive), in which case I'd not be happily surprised that all I got is a pointer to the location of the data on the original machine.
  • I might be preparing a docker context which does not support symlinks.

I think the option should be called follow_symlinks. I propose changing the name of the argument and updating the documentation. The old option can still be supported for BC but should be marked deprecated and be removed in a future BC break.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Morty Proxy This is a proxified and sanitized view of the page, visit original site.