Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[HttpKernel] not checking if session is started breaks test #24861

Copy link
Copy link
Closed
@kbond

Description

@kbond
Issue body actions
Q A
Bug report? yes
Feature request? no
BC Break report? yes
RFC? no
Symfony version 3.4.0-BETA3

This PR (#24774), specifically, this change (https://github.com/symfony/symfony/pull/24774/files#diff-e8f5b14fbfbbeac60fc9f3abe310c3b0L318) is causing an issue in a functional test.

My test logs a user in, ensures they are logged in, then expires the session via $client->getCookieJar()->expire('MOCKSESSID'). I then visit another page and ensure the user is not logged in. It worked as expected without this change but the user is still logged in after this change.

My test env is using MockFileSessionStorage and I am using $client->disableReboot().

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Morty Proxy This is a proxified and sanitized view of the page, visit original site.