Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[TwigBridge] Bootstrap 3 horizontal layout not renders correctly the checkbox #24702

Copy link
Copy link
Closed
@antalaron

Description

@antalaron
Issue body actions
Q A
Bug report? yes
Feature request? no
BC Break report? no
RFC? no
Symfony version 3.4.0-BETA1

In 3.4.0-BETA and probably in 4.0.0-BETA, because of the refactorization, and extension of Bootstrap form themes in #21751 the checkbox render is failing for Bootstrap 3.

3.3.10 (good):
kepernyofoto 2017-10-26 - 21 58 37

3.4.0-BETA (bad, the placeholder for the label is missing):
kepernyofoto 2017-10-26 - 21 58 06

Here is a sample reproduction with 2 branches (stable, beta):
https://github.com/antalaron/symfony-issue-checkbox

I checked, if re-include the original code for checkboxes to bootstrap_3_horizontal_layout.html.twig, it's ok:

{% block checkbox_row -%}
    {{- block('checkbox_radio_row') -}}
{%- endblock checkbox_row %}

{% block checkbox_radio_row -%}
{% spaceless %}
    <div class="form-group{% if not valid %} has-error{% endif %}">
        <div class="{{ block('form_label_class') }}"></div>
        <div class="{{ block('form_group_class') }}">
            {{ form_widget(form) }}
            {{ form_errors(form) }}
        </div>
    </div>
{% endspaceless %}
{%- endblock checkbox_radio_row %}

But I don't know if it breaks anything else.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Morty Proxy This is a proxified and sanitized view of the page, visit original site.