Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Prevent test extending #21266

Copy link
Copy link
Closed
Closed
Copy link
@keradus

Description

@keradus
Issue body actions
Q A
Bug report? no
Feature request? no
BC Break report? no
RFC? yes
Symfony version n/a

Somehow related to #20493 (cc @nicolas-grekas).

Symfony project treats (which is good) it tests as internal code that should serve only this repo purposes.
It's not common, but I do saw very edge case when someone actually extend concrete Foo...TestCase of Symfony unittests. I would like to propose marking all utests as @internal and @final (or maybe even final class on class-syntax level, not docs) - to prevent that kind of situations.
In the case I describe the exotic project tests crashed after updating Symfony becouse of BC breaks on Foo...TestCase class.

If agreed, I could prepare a PR.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Morty Proxy This is a proxified and sanitized view of the page, visit original site.