Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix binary check in binary dumper #18241

Copy link
Copy link
Closed
@geek-merlin

Description

@geek-merlin
Issue body actions

In #17863 a binary check is introduced like
preg_match('/[^\x09-\x0d\x20-\xff]/', $value)

This is not specific, in the sense that some invalid utf8 won't be recognized as binary.

The recognition is nontrivial iterating a byte sequence, but PHP has some simple one-liners to do it like
$isUTF8 = preg_match('//u', $string);

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Morty Proxy This is a proxified and sanitized view of the page, visit original site.