Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Profiler save profiles when any exception throwed. #10375

Copy link
Copy link
Closed
@stephpy

Description

@stephpy
Issue body actions

Hi,

Symfony documentation says only 500 pages are profiled if only_exception is set.

But it's wrong. All exceptions are stored, it don't take status_code in consideration to profile and i would like to know if it's a valid use case (btw i'll make a pr on symfony-docs) or a bug.

If it's a bug i can make a PR to fix it.

In this method

https://github.com/symfony/symfony/blob/master/src/Symfony/Component/HttpKernel/EventListener/ProfilerListener.php#L89 we could check for $event->getResponse()->getStatusCode() and store only 5xx

OR

To stay BC, introduce a status_codes into framework.profiler configuration.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Morty Proxy This is a proxified and sanitized view of the page, visit original site.