From 4d120b8488491e5527a2a14b277fd69c88ce7329 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jib=C3=A9=20Barth?= Date: Mon, 4 Mar 2024 11:56:55 +0100 Subject: [PATCH 01/81] [HttpClient] Preserve float in JsonMockResponse --- .../HttpClient/Response/JsonMockResponse.php | 2 +- .../Tests/Response/JsonMockResponseTest.php | 16 ++++++++++++++++ 2 files changed, 17 insertions(+), 1 deletion(-) diff --git a/src/Symfony/Component/HttpClient/Response/JsonMockResponse.php b/src/Symfony/Component/HttpClient/Response/JsonMockResponse.php index 66372aa8a8149..9372dbe5a0b0d 100644 --- a/src/Symfony/Component/HttpClient/Response/JsonMockResponse.php +++ b/src/Symfony/Component/HttpClient/Response/JsonMockResponse.php @@ -21,7 +21,7 @@ class JsonMockResponse extends MockResponse public function __construct(mixed $body = [], array $info = []) { try { - $json = json_encode($body, \JSON_THROW_ON_ERROR); + $json = json_encode($body, \JSON_THROW_ON_ERROR | \JSON_PRESERVE_ZERO_FRACTION); } catch (\JsonException $e) { throw new InvalidArgumentException('JSON encoding failed: '.$e->getMessage(), $e->getCode(), $e); } diff --git a/src/Symfony/Component/HttpClient/Tests/Response/JsonMockResponseTest.php b/src/Symfony/Component/HttpClient/Tests/Response/JsonMockResponseTest.php index b371c08cf4241..768353b04abd1 100644 --- a/src/Symfony/Component/HttpClient/Tests/Response/JsonMockResponseTest.php +++ b/src/Symfony/Component/HttpClient/Tests/Response/JsonMockResponseTest.php @@ -59,6 +59,22 @@ public function testJsonEncodeString() $this->assertSame('application/json', $response->getHeaders()['content-type'][0]); } + public function testJsonEncodeFloat() + { + $client = new MockHttpClient(new JsonMockResponse([ + 'foo' => 1.23, + 'ccc' => 1.0, + 'baz' => 10., + ])); + $response = $client->request('GET', 'https://symfony.com'); + + $this->assertSame([ + 'foo' => 1.23, + 'ccc' => 1., + 'baz' => 10., + ], $response->toArray()); + } + /** * @dataProvider responseHeadersProvider */ From 9b03f270338c0b9c910c0e174cb14d7cdb0eca76 Mon Sep 17 00:00:00 2001 From: Fabien Potencier Date: Mon, 4 Mar 2024 21:55:34 +0100 Subject: [PATCH 02/81] Update CHANGELOG for 5.4.37 --- CHANGELOG-5.4.md | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/CHANGELOG-5.4.md b/CHANGELOG-5.4.md index 43c657cae08c7..925da452b692e 100644 --- a/CHANGELOG-5.4.md +++ b/CHANGELOG-5.4.md @@ -7,6 +7,12 @@ in 5.4 minor versions. To get the diff for a specific change, go to https://github.com/symfony/symfony/commit/XXX where XXX is the change hash To get the diff between two versions, go to https://github.com/symfony/symfony/compare/v5.4.0...v5.4.1 +* 5.4.37 (2024-03-04) + + * bug #54102 [HttpClient] Fix deprecation on PHP 8.3 (nicolas-grekas) + * bug #54081 [DoctrineBridge] Safeguard dynamic access to Doctrine metadata properties (derrabus) + * bug #54080 [Routing] Enhance error handling in StaticPrefixCollection for compatibility with libpcre2-10.43 (Lustmored) + * 5.4.36 (2024-02-27) * bug #54045 [Config][Messenger][Security] Don't turn deprecations into exceptions when unserializing (nicolas-grekas) From 8d1867da308a24c8883ea55e987728d7e660d157 Mon Sep 17 00:00:00 2001 From: Fabien Potencier Date: Mon, 4 Mar 2024 21:55:44 +0100 Subject: [PATCH 03/81] Update CONTRIBUTORS for 5.4.37 --- CONTRIBUTORS.md | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/CONTRIBUTORS.md b/CONTRIBUTORS.md index c4a195380c0a3..f676651321bef 100644 --- a/CONTRIBUTORS.md +++ b/CONTRIBUTORS.md @@ -80,11 +80,11 @@ The Symfony Connect username in parenthesis allows to get more information - Mathieu Santostefano (welcomattic) - Alexander Schranz (alexander-schranz) - Vasilij Duško (staff) + - Simon André (simonandre) - Sarah Khalil (saro0h) - Laurent VOULLEMIER (lvo) - Konstantin Kudryashov (everzet) - Tomasz Kowalczyk (thunderer) - - Simon André (simonandre) - Guilhem N (guilhemn) - Bilal Amarni (bamarni) - Eriksen Costa @@ -97,10 +97,10 @@ The Symfony Connect username in parenthesis allows to get more information - David Buchmann (dbu) - Andrej Hudec (pulzarraider) - Jáchym Toušek (enumag) + - Ruud Kamphuis (ruudk) - Christian Raue - Eric Clemmons (ericclemmons) - Denis (yethee) - - Ruud Kamphuis (ruudk) - Michel Weimerskirch (mweimerskirch) - Issei Murasawa (issei_m) - Douglas Greenshields (shieldo) @@ -129,8 +129,8 @@ The Symfony Connect username in parenthesis allows to get more information - Bart van den Burg (burgov) - Vasilij Dusko | CREATION - Jordan Alliot (jalliot) - - John Wards (johnwards) - Phil E. Taylor (philetaylor) + - John Wards (johnwards) - Théo FIDRY - Antoine Hérault (herzult) - Konstantin.Myakshin @@ -177,6 +177,7 @@ The Symfony Connect username in parenthesis allows to get more information - Maxime Helias (maxhelias) - Robert Schönthal (digitalkaoz) - Smaine Milianni (ismail1432) + - Michael Babker (mbabker) - François-Xavier de Guillebon (de-gui_f) - Maximilian Beckers (maxbeckers) - noniagriconomie @@ -188,7 +189,6 @@ The Symfony Connect username in parenthesis allows to get more information - Jhonny Lidfors (jhonne) - Juti Noppornpitak (shiroyuki) - Gregor Harlan (gharlan) - - Michael Babker (mbabker) - Anthony MARTIN - Sebastian Hörl (blogsh) - Tigran Azatyan (tigranazatyan) @@ -231,6 +231,7 @@ The Symfony Connect username in parenthesis allows to get more information - George Mponos (gmponos) - Richard Shank (iampersistent) - Thomas Landauer (thomas-landauer) + - Roland Franssen :) - Romain Monteil (ker0x) - Sergey (upyx) - Marco Pivetta (ocramius) @@ -257,7 +258,6 @@ The Symfony Connect username in parenthesis allows to get more information - Artur Kotyrba - Wouter J - Tyson Andre - - Roland Franssen :) - GDIBass - Samuel NELA (snela) - Vincent AUBERT (vincent) @@ -733,6 +733,7 @@ The Symfony Connect username in parenthesis allows to get more information - Vadim Borodavko (javer) - Tavo Nieves J (tavoniievez) - Luc Vieillescazes (iamluc) + - Stiven Llupa (sllupa) - Erik Saunier (snickers) - François Dume (franek) - Jerzy Lekowski (jlekowski) @@ -1043,7 +1044,6 @@ The Symfony Connect username in parenthesis allows to get more information - Florian Pfitzer (marmelatze) - Ivan Grigoriev (greedyivan) - Johann Saunier (prophet777) - - Stiven Llupa (sllupa) - Kevin SCHNEKENBURGER - Fabien Salles (blacked) - Andreas Erhard (andaris) @@ -2117,6 +2117,7 @@ The Symfony Connect username in parenthesis allows to get more information - Sébastien HOUZÉ - Mbechezi Nawo - wivaku + - Markus Reinhold - Jingyu Wang - steveYeah - Asrorbek (asrorbek) @@ -2523,6 +2524,7 @@ The Symfony Connect username in parenthesis allows to get more information - Roy de Vos Burchart - John Stevenson - everyx + - Richard Heine - Francisco Facioni (fran6co) - Stanislav Gamaiunov (happyproff) - Iwan van Staveren (istaveren) @@ -3193,6 +3195,7 @@ The Symfony Connect username in parenthesis allows to get more information - Daniele Cesarini (ijanki) - Ismail Asci (ismailasci) - Jeffrey Moelands (jeffreymoelands) + - Jakub Caban (lustmored) - Ondřej Mirtes (mirtes) - Paulius Jarmalavičius (pjarmalavicius) - Ramon Ornelas (ramonornela) @@ -3615,6 +3618,7 @@ The Symfony Connect username in parenthesis allows to get more information - Konrad - Kovacs Nicolas - eminjk + - Gálik Pál - craigmarvelley - Stano Turza - Antoine Leblanc From 3e403191b33aaa70fd971e5985a868682b5c6ba8 Mon Sep 17 00:00:00 2001 From: Fabien Potencier Date: Mon, 4 Mar 2024 21:55:44 +0100 Subject: [PATCH 04/81] Update VERSION for 5.4.37 --- src/Symfony/Component/HttpKernel/Kernel.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Symfony/Component/HttpKernel/Kernel.php b/src/Symfony/Component/HttpKernel/Kernel.php index e07f9114b0319..27d505faa3355 100644 --- a/src/Symfony/Component/HttpKernel/Kernel.php +++ b/src/Symfony/Component/HttpKernel/Kernel.php @@ -78,12 +78,12 @@ abstract class Kernel implements KernelInterface, RebootableInterface, Terminabl */ private static $freshCache = []; - public const VERSION = '5.4.37-DEV'; + public const VERSION = '5.4.37'; public const VERSION_ID = 50437; public const MAJOR_VERSION = 5; public const MINOR_VERSION = 4; public const RELEASE_VERSION = 37; - public const EXTRA_VERSION = 'DEV'; + public const EXTRA_VERSION = ''; public const END_OF_MAINTENANCE = '11/2024'; public const END_OF_LIFE = '11/2025'; From 2ed7af7ced938a0e90577933dd6e2b8e56d0317d Mon Sep 17 00:00:00 2001 From: Fabien Potencier Date: Mon, 4 Mar 2024 22:00:19 +0100 Subject: [PATCH 05/81] Bump Symfony version to 5.4.38 --- src/Symfony/Component/HttpKernel/Kernel.php | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/Symfony/Component/HttpKernel/Kernel.php b/src/Symfony/Component/HttpKernel/Kernel.php index 27d505faa3355..b00a05f517221 100644 --- a/src/Symfony/Component/HttpKernel/Kernel.php +++ b/src/Symfony/Component/HttpKernel/Kernel.php @@ -78,12 +78,12 @@ abstract class Kernel implements KernelInterface, RebootableInterface, Terminabl */ private static $freshCache = []; - public const VERSION = '5.4.37'; - public const VERSION_ID = 50437; + public const VERSION = '5.4.38-DEV'; + public const VERSION_ID = 50438; public const MAJOR_VERSION = 5; public const MINOR_VERSION = 4; - public const RELEASE_VERSION = 37; - public const EXTRA_VERSION = ''; + public const RELEASE_VERSION = 38; + public const EXTRA_VERSION = 'DEV'; public const END_OF_MAINTENANCE = '11/2024'; public const END_OF_LIFE = '11/2025'; From b9da7732f88f49de28929efe8d1e6132920a0f1f Mon Sep 17 00:00:00 2001 From: Fabien Potencier Date: Mon, 4 Mar 2024 22:00:43 +0100 Subject: [PATCH 06/81] Update CHANGELOG for 6.4.5 --- CHANGELOG-6.4.md | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/CHANGELOG-6.4.md b/CHANGELOG-6.4.md index 4c7c13f44ec90..723085c67be52 100644 --- a/CHANGELOG-6.4.md +++ b/CHANGELOG-6.4.md @@ -7,6 +7,16 @@ in 6.4 minor versions. To get the diff for a specific change, go to https://github.com/symfony/symfony/commit/XXX where XXX is the change hash To get the diff between two versions, go to https://github.com/symfony/symfony/compare/v6.4.0...v6.4.1 +* 6.4.5 (2024-03-04) + + * bug #54113 [AssetMapper] Throw exception in Javascript compiler when PCRE error (smnandre) + * bug #54129 [Clock] Add attributes to support PHPUnit 10 + 11 (ruudk) + * bug #54079 [AssetMapper] Fix `JavaScriptImportPathCompiler` regression in regex (PhilETaylor) + * bug #54102 [HttpClient] Fix deprecation on PHP 8.3 (nicolas-grekas) + * bug #54089 [Mailer] [Brevo] Remove tags from mandatory event arguments (palgalik) + * bug #54081 [DoctrineBridge] Safeguard dynamic access to Doctrine metadata properties (derrabus) + * bug #54080 [Routing] Enhance error handling in StaticPrefixCollection for compatibility with libpcre2-10.43 (Lustmored) + * 6.4.4 (2024-02-27) * bug #53985 [HttpKernel] Allow tagged controllers in ControllerResolver (marein) From e394573434889be04bee4c01899f0a16bc09a79a Mon Sep 17 00:00:00 2001 From: Fabien Potencier Date: Mon, 4 Mar 2024 22:00:47 +0100 Subject: [PATCH 07/81] Update VERSION for 6.4.5 --- src/Symfony/Component/HttpKernel/Kernel.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Symfony/Component/HttpKernel/Kernel.php b/src/Symfony/Component/HttpKernel/Kernel.php index fd7e276eb1a9c..d3ed631064403 100644 --- a/src/Symfony/Component/HttpKernel/Kernel.php +++ b/src/Symfony/Component/HttpKernel/Kernel.php @@ -76,12 +76,12 @@ abstract class Kernel implements KernelInterface, RebootableInterface, Terminabl */ private static array $freshCache = []; - public const VERSION = '6.4.5-DEV'; + public const VERSION = '6.4.5'; public const VERSION_ID = 60405; public const MAJOR_VERSION = 6; public const MINOR_VERSION = 4; public const RELEASE_VERSION = 5; - public const EXTRA_VERSION = 'DEV'; + public const EXTRA_VERSION = ''; public const END_OF_MAINTENANCE = '11/2026'; public const END_OF_LIFE = '11/2027'; From 75bafd285989a682540a125232ed43224bb60590 Mon Sep 17 00:00:00 2001 From: Fabien Potencier Date: Mon, 4 Mar 2024 22:04:43 +0100 Subject: [PATCH 08/81] Bump Symfony version to 6.4.6 --- src/Symfony/Component/HttpKernel/Kernel.php | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/Symfony/Component/HttpKernel/Kernel.php b/src/Symfony/Component/HttpKernel/Kernel.php index d3ed631064403..0cba93dc3a17e 100644 --- a/src/Symfony/Component/HttpKernel/Kernel.php +++ b/src/Symfony/Component/HttpKernel/Kernel.php @@ -76,12 +76,12 @@ abstract class Kernel implements KernelInterface, RebootableInterface, Terminabl */ private static array $freshCache = []; - public const VERSION = '6.4.5'; - public const VERSION_ID = 60405; + public const VERSION = '6.4.6-DEV'; + public const VERSION_ID = 60406; public const MAJOR_VERSION = 6; public const MINOR_VERSION = 4; - public const RELEASE_VERSION = 5; - public const EXTRA_VERSION = ''; + public const RELEASE_VERSION = 6; + public const EXTRA_VERSION = 'DEV'; public const END_OF_MAINTENANCE = '11/2026'; public const END_OF_LIFE = '11/2027'; From cdb3fdd844289a5503101fea4f4d2fba05b4b99c Mon Sep 17 00:00:00 2001 From: Fabien Potencier Date: Mon, 4 Mar 2024 22:09:04 +0100 Subject: [PATCH 09/81] Bump Symfony version to 7.0.6 --- src/Symfony/Component/HttpKernel/Kernel.php | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/Symfony/Component/HttpKernel/Kernel.php b/src/Symfony/Component/HttpKernel/Kernel.php index 9ef02f3b8613c..4e48507e60393 100644 --- a/src/Symfony/Component/HttpKernel/Kernel.php +++ b/src/Symfony/Component/HttpKernel/Kernel.php @@ -76,12 +76,12 @@ abstract class Kernel implements KernelInterface, RebootableInterface, Terminabl */ private static array $freshCache = []; - public const VERSION = '7.0.5'; - public const VERSION_ID = 70005; + public const VERSION = '7.0.6-DEV'; + public const VERSION_ID = 70006; public const MAJOR_VERSION = 7; public const MINOR_VERSION = 0; - public const RELEASE_VERSION = 5; - public const EXTRA_VERSION = ''; + public const RELEASE_VERSION = 6; + public const EXTRA_VERSION = 'DEV'; public const END_OF_MAINTENANCE = '07/2024'; public const END_OF_LIFE = '07/2024'; From f1233706168a322d7f67820880b703020f6be71c Mon Sep 17 00:00:00 2001 From: "Jonathan H. Wage" Date: Tue, 5 Mar 2024 14:09:36 -0600 Subject: [PATCH 10/81] [Messenger] [Amqp] Handle AMQPConnectionException when publishing a message. --- .../Amqp/Tests/Transport/ConnectionTest.php | 67 +++++++++++++++++++ .../Bridge/Amqp/Transport/Connection.php | 52 ++++++++++---- 2 files changed, 106 insertions(+), 13 deletions(-) diff --git a/src/Symfony/Component/Messenger/Bridge/Amqp/Tests/Transport/ConnectionTest.php b/src/Symfony/Component/Messenger/Bridge/Amqp/Tests/Transport/ConnectionTest.php index a08c102a4b9da..e57dad6cad97e 100644 --- a/src/Symfony/Component/Messenger/Bridge/Amqp/Tests/Transport/ConnectionTest.php +++ b/src/Symfony/Component/Messenger/Bridge/Amqp/Tests/Transport/ConnectionTest.php @@ -774,6 +774,73 @@ public function testItCanBeConstructedWithTLSOptionsAndNonTLSDsn() ); } + public function testItCanRetryPublishWhenAMQPConnectionExceptionIsThrown() + { + $factory = new TestAmqpFactory( + $amqpConnection = $this->createMock(\AMQPConnection::class), + $amqpChannel = $this->createMock(\AMQPChannel::class), + $amqpQueue = $this->createMock(\AMQPQueue::class), + $amqpExchange = $this->createMock(\AMQPExchange::class) + ); + + $amqpExchange->expects($this->exactly(2)) + ->method('publish') + ->willReturnOnConsecutiveCalls( + $this->throwException(new \AMQPConnectionException('a socket error occurred')), + null + ); + + $connection = Connection::fromDsn('amqp://localhost', [], $factory); + $connection->publish('body'); + } + + public function testItCanRetryPublishWithDelayWhenAMQPConnectionExceptionIsThrown() + { + $factory = new TestAmqpFactory( + $amqpConnection = $this->createMock(\AMQPConnection::class), + $amqpChannel = $this->createMock(\AMQPChannel::class), + $amqpQueue = $this->createMock(\AMQPQueue::class), + $amqpExchange = $this->createMock(\AMQPExchange::class) + ); + + $amqpExchange->expects($this->exactly(2)) + ->method('publish') + ->willReturnOnConsecutiveCalls( + $this->throwException(new \AMQPConnectionException('a socket error occurred')), + null + ); + + $connection = Connection::fromDsn('amqp://localhost', [], $factory); + $connection->publish('body', [], 5000); + } + + public function testItWillRetryMaxThreeTimesWhenAMQPConnectionExceptionIsThrown() + { + $factory = new TestAmqpFactory( + $amqpConnection = $this->createMock(\AMQPConnection::class), + $amqpChannel = $this->createMock(\AMQPChannel::class), + $amqpQueue = $this->createMock(\AMQPQueue::class), + $amqpExchange = $this->createMock(\AMQPExchange::class) + ); + + $exception = new \AMQPConnectionException('a socket error occurred'); + + $amqpExchange->expects($this->exactly(4)) + ->method('publish') + ->willReturnOnConsecutiveCalls( + $this->throwException($exception), + $this->throwException($exception), + $this->throwException($exception), + $this->throwException($exception), + ); + + self::expectException($exception::class); + self::expectExceptionMessage($exception->getMessage()); + + $connection = Connection::fromDsn('amqp://localhost', [], $factory); + $connection->publish('body'); + } + private function createDelayOrRetryConnection(\AMQPExchange $delayExchange, string $deadLetterExchangeName, string $delayQueueName): Connection { $amqpConnection = $this->createMock(\AMQPConnection::class); diff --git a/src/Symfony/Component/Messenger/Bridge/Amqp/Transport/Connection.php b/src/Symfony/Component/Messenger/Bridge/Amqp/Transport/Connection.php index b39902623adce..0ae1bff21d7c8 100644 --- a/src/Symfony/Component/Messenger/Bridge/Amqp/Transport/Connection.php +++ b/src/Symfony/Component/Messenger/Bridge/Amqp/Transport/Connection.php @@ -287,19 +287,21 @@ public function publish(string $body, array $headers = [], int $delayInMs = 0, ? $this->setupExchangeAndQueues(); // also setup normal exchange for delayed messages so delay queue can DLX messages to it } - if (0 !== $delayInMs) { - $this->publishWithDelay($body, $headers, $delayInMs, $amqpStamp); + $this->withConnectionExceptionRetry(function () use ($body, $headers, $delayInMs, $amqpStamp) { + if (0 !== $delayInMs) { + $this->publishWithDelay($body, $headers, $delayInMs, $amqpStamp); - return; - } + return; + } - $this->publishOnExchange( - $this->exchange(), - $body, - $this->getRoutingKeyForMessage($amqpStamp), - $headers, - $amqpStamp - ); + $this->publishOnExchange( + $this->exchange(), + $body, + $this->getRoutingKeyForMessage($amqpStamp), + $headers, + $amqpStamp + ); + }); } /** @@ -545,11 +547,16 @@ public function exchange(): \AMQPExchange private function clearWhenDisconnected(): void { if (!$this->channel()->isConnected()) { - unset($this->amqpChannel, $this->amqpExchange, $this->amqpDelayExchange); - $this->amqpQueues = []; + $this->clear(); } } + private function clear(): void + { + unset($this->amqpChannel, $this->amqpExchange, $this->amqpDelayExchange); + $this->amqpQueues = []; + } + private function getDefaultPublishRoutingKey(): ?string { return $this->exchangeOptions['default_publish_routing_key'] ?? null; @@ -566,4 +573,23 @@ private function getRoutingKeyForMessage(?AmqpStamp $amqpStamp): ?string { return $amqpStamp?->getRoutingKey() ?? $this->getDefaultPublishRoutingKey(); } + + private function withConnectionExceptionRetry(callable $callable): void + { + $maxRetries = 3; + $retries = 0; + + retry: + try { + $callable(); + } catch (\AMQPConnectionException $e) { + if (++$retries <= $maxRetries) { + $this->clear(); + + goto retry; + } + + throw $e; + } + } } From 88c2e6b119b9e502946074c21314e9de86feada8 Mon Sep 17 00:00:00 2001 From: Nadim AL ABDOU <46465503+nalabdou@users.noreply.github.com> Date: Wed, 6 Mar 2024 14:23:08 +0100 Subject: [PATCH 11/81] [Validator] Review Arabic translations and add correct translations. --- .../Resources/translations/validators.ar.xlf | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/Symfony/Component/Validator/Resources/translations/validators.ar.xlf b/src/Symfony/Component/Validator/Resources/translations/validators.ar.xlf index 6ac303a778fa9..dfd398ae95a4f 100644 --- a/src/Symfony/Component/Validator/Resources/translations/validators.ar.xlf +++ b/src/Symfony/Component/Validator/Resources/translations/validators.ar.xlf @@ -136,7 +136,7 @@ This value is not a valid IP address. - هذه القيمة ليست عنوان IP صالحًا. + هذا ليس عنوان IP صحيح. This value is not a valid language. @@ -192,7 +192,7 @@ No temporary folder was configured in php.ini, or the configured folder does not exist. - لم يتم تكوين مجلد مؤقت في ملف php.ini، أو المجلد المعد لا يوجد. + لم يتم تكوين مجلد مؤقت في ملف php.ini. Cannot write temporary file to disk. @@ -224,7 +224,7 @@ This value is not a valid International Bank Account Number (IBAN). - هذه القيمة ليست رقم حساب بنكي دولي (IBAN) صالحًا. + هذه القيمة ليست رقم حساب بنكي دولي (IBAN) صالحًا. This value is not a valid ISBN-10. @@ -312,7 +312,7 @@ This value is not a valid Business Identifier Code (BIC). - هذه القيمة ليست رمز معرف الأعمال (BIC) صالحًا. + هذه القيمة ليست رمز معرف أعمال (BIC) صالحًا. Error @@ -320,7 +320,7 @@ This value is not a valid UUID. - هذه القيمة ليست UUID صالحًا. + هذه القيمة ليست UUID صالحًا. This value should be a multiple of {{ compared_value }}. @@ -432,11 +432,11 @@ The detected character encoding is invalid ({{ detected }}). Allowed encodings are {{ encodings }}. - تم اكتشاف ترميز الأحرف غير صالح ({{ detected }}). الترميزات المسموح بها هي {{ encodings }}. + تم اكتشاف ترميز أحرف غير صالح ({{ detected }}). الترميزات المسموح بها هي {{ encodings }}. This value is not a valid MAC address. - هذه القيمة ليست عنوان MAC صالحًا. + هذه القيمة ليست عنوان MAC صالحًا. From 97d1624b299d9f0062f87dbc2c27bbf583eb7a5a Mon Sep 17 00:00:00 2001 From: Nicolas Grekas Date: Wed, 6 Mar 2024 16:35:34 +0100 Subject: [PATCH 12/81] [HttpClient] Fix PHP 8.3 deprecation in tests --- .../Component/HttpClient/Tests/HttpClientTraitTest.php | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/Symfony/Component/HttpClient/Tests/HttpClientTraitTest.php b/src/Symfony/Component/HttpClient/Tests/HttpClientTraitTest.php index 613d80cb1d3a7..3e81f429622a0 100644 --- a/src/Symfony/Component/HttpClient/Tests/HttpClientTraitTest.php +++ b/src/Symfony/Component/HttpClient/Tests/HttpClientTraitTest.php @@ -72,10 +72,8 @@ public function testPrepareRequestWithBodyIsArray() public function testNormalizeBodyMultipart() { $file = fopen('php://memory', 'r+'); - stream_context_set_option($file, ['http' => [ - 'filename' => 'test.txt', - 'content_type' => 'text/plain', - ]]); + stream_context_set_option($file, 'http', 'filename', 'test.txt'); + stream_context_set_option($file, 'http', 'content_type', 'text/plain'); fwrite($file, 'foobarbaz'); rewind($file); From 5f8fc3a9f6ca3444b1723a34b7f641ae4818bdaf Mon Sep 17 00:00:00 2001 From: Christophe Coevoet Date: Thu, 7 Mar 2024 11:28:55 +0100 Subject: [PATCH 13/81] Add an experimental CI job for PHP 8.4 --- .github/workflows/unit-tests.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/unit-tests.yml b/.github/workflows/unit-tests.yml index 9b902532c1bdc..09472e0b06d3c 100644 --- a/.github/workflows/unit-tests.yml +++ b/.github/workflows/unit-tests.yml @@ -33,7 +33,8 @@ jobs: - php: '8.2' mode: low-deps - php: '8.3' - #mode: experimental + - php: '8.4' + mode: experimental fail-fast: false runs-on: ubuntu-20.04 From f4ea95d002bbc38981e7ad70644921146ae58157 Mon Sep 17 00:00:00 2001 From: Nicolas Grekas Date: Thu, 7 Mar 2024 11:19:11 +0100 Subject: [PATCH 14/81] [ErrorHandler] Fix exit code when an exception occurs and the exception handler has been unregistered --- src/Symfony/Component/ErrorHandler/ErrorHandler.php | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/Symfony/Component/ErrorHandler/ErrorHandler.php b/src/Symfony/Component/ErrorHandler/ErrorHandler.php index 28b93c2b158b7..a2a98fb745906 100644 --- a/src/Symfony/Component/ErrorHandler/ErrorHandler.php +++ b/src/Symfony/Component/ErrorHandler/ErrorHandler.php @@ -669,6 +669,10 @@ public static function handleFatalError(?array $error = null): void set_exception_handler($h); } if (!$handler) { + if (null === $error && $exitCode = self::$exitCode) { + register_shutdown_function('register_shutdown_function', function () use ($exitCode) { exit($exitCode); }); + } + return; } if ($handler !== $h) { @@ -704,8 +708,7 @@ public static function handleFatalError(?array $error = null): void // Ignore this re-throw } - if ($exit && self::$exitCode) { - $exitCode = self::$exitCode; + if ($exit && $exitCode = self::$exitCode) { register_shutdown_function('register_shutdown_function', function () use ($exitCode) { exit($exitCode); }); } } From 874676516aefa5568e600d006c8205ced6d58e77 Mon Sep 17 00:00:00 2001 From: Alexandre Daubois <2144837+alexandre-daubois@users.noreply.github.com> Date: Thu, 7 Mar 2024 10:44:39 +0100 Subject: [PATCH 15/81] [FrameworkBundle] Fix PHP 8.4 deprecation --- .../FrameworkBundle/Console/Descriptor/TextDescriptor.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Symfony/Bundle/FrameworkBundle/Console/Descriptor/TextDescriptor.php b/src/Symfony/Bundle/FrameworkBundle/Console/Descriptor/TextDescriptor.php index 56bb0fbd9bed4..39dc8fb210ab7 100644 --- a/src/Symfony/Bundle/FrameworkBundle/Console/Descriptor/TextDescriptor.php +++ b/src/Symfony/Bundle/FrameworkBundle/Console/Descriptor/TextDescriptor.php @@ -559,7 +559,7 @@ private function formatControllerLink($controller, string $anchorText, ?callable } elseif (!\is_string($controller)) { return $anchorText; } elseif (str_contains($controller, '::')) { - $r = new \ReflectionMethod($controller); + $r = new \ReflectionMethod(...explode('::', $controller, 2)); } else { $r = new \ReflectionFunction($controller); } From 999f71367320326e4176eca9ecdf590195b12ae8 Mon Sep 17 00:00:00 2001 From: Christian Flothmann Date: Thu, 7 Mar 2024 15:59:23 +0100 Subject: [PATCH 16/81] add missing invalid extension error entry --- src/Symfony/Component/Validator/Constraints/File.php | 1 + 1 file changed, 1 insertion(+) diff --git a/src/Symfony/Component/Validator/Constraints/File.php b/src/Symfony/Component/Validator/Constraints/File.php index c55ceece72699..863e306f281f4 100644 --- a/src/Symfony/Component/Validator/Constraints/File.php +++ b/src/Symfony/Component/Validator/Constraints/File.php @@ -41,6 +41,7 @@ class File extends Constraint self::EMPTY_ERROR => 'EMPTY_ERROR', self::TOO_LARGE_ERROR => 'TOO_LARGE_ERROR', self::INVALID_MIME_TYPE_ERROR => 'INVALID_MIME_TYPE_ERROR', + self::INVALID_EXTENSION_ERROR => 'INVALID_EXTENSION_ERROR', self::FILENAME_TOO_LONG => 'FILENAME_TOO_LONG', ]; From 7dae80db975ccdba768ef67b2f1a8b7c195bf7e9 Mon Sep 17 00:00:00 2001 From: Nicolas Grekas Date: Thu, 7 Mar 2024 18:18:22 +0100 Subject: [PATCH 17/81] [Serializer] Fix fixture --- .../Serializer/Tests/Normalizer/ObjectNormalizerTest.php | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/Symfony/Component/Serializer/Tests/Normalizer/ObjectNormalizerTest.php b/src/Symfony/Component/Serializer/Tests/Normalizer/ObjectNormalizerTest.php index 36957ac5c0a3f..9e4c76d9865eb 100644 --- a/src/Symfony/Component/Serializer/Tests/Normalizer/ObjectNormalizerTest.php +++ b/src/Symfony/Component/Serializer/Tests/Normalizer/ObjectNormalizerTest.php @@ -1043,6 +1043,11 @@ public function __get($name) return $this->foo = 123; } } + + public function __isset($name) + { + return 'foo' === $name; + } } class FormatAndContextAwareNormalizer extends ObjectNormalizer From 9610a7c2e81fe3060df04c5455a6e2f17c92eb21 Mon Sep 17 00:00:00 2001 From: Nicolas Grekas Date: Thu, 7 Mar 2024 17:54:47 +0100 Subject: [PATCH 18/81] [PropertyAccess] Fix checking for missing properties --- .../Component/PropertyAccess/PropertyAccessor.php | 14 ++++++++++++-- .../Tests/Fixtures/TestClassMagicGet.php | 5 +++++ .../PropertyAccess/Tests/PropertyAccessorTest.php | 9 ++++++++- .../PropertyInfo/Extractor/ReflectionExtractor.php | 10 ++++------ 4 files changed, 29 insertions(+), 9 deletions(-) diff --git a/src/Symfony/Component/PropertyAccess/PropertyAccessor.php b/src/Symfony/Component/PropertyAccess/PropertyAccessor.php index 60f2d32770b0d..4343c9fc313fe 100644 --- a/src/Symfony/Component/PropertyAccess/PropertyAccessor.php +++ b/src/Symfony/Component/PropertyAccess/PropertyAccessor.php @@ -411,8 +411,18 @@ private function readProperty(array $zval, string $property, bool $ignoreInvalid throw $e; } } elseif (PropertyReadInfo::TYPE_PROPERTY === $type) { - if ($access->canBeReference() && !isset($object->$name) && !\array_key_exists($name, (array) $object) && !(new \ReflectionProperty($class, $name))->hasType()) { - throw new UninitializedPropertyException(sprintf('The property "%s::$%s" is not initialized.', $class, $name)); + if (!isset($object->$name) && !\array_key_exists($name, (array) $object)) { + try { + $r = new \ReflectionProperty($class, $name); + + if ($r->isPublic() && !$r->hasType()) { + throw new UninitializedPropertyException(sprintf('The property "%s::$%s" is not initialized.', $class, $name)); + } + } catch (\ReflectionException $e) { + if (!$ignoreInvalidProperty) { + throw new NoSuchPropertyException(sprintf('Can\'t get a way to read the property "%s" in class "%s".', $property, $class)); + } + } } $result[self::VALUE] = $object->$name; diff --git a/src/Symfony/Component/PropertyAccess/Tests/Fixtures/TestClassMagicGet.php b/src/Symfony/Component/PropertyAccess/Tests/Fixtures/TestClassMagicGet.php index d1e4d23f9dc53..e3850cca6e32f 100644 --- a/src/Symfony/Component/PropertyAccess/Tests/Fixtures/TestClassMagicGet.php +++ b/src/Symfony/Component/PropertyAccess/Tests/Fixtures/TestClassMagicGet.php @@ -39,4 +39,9 @@ public function __get(string $property) return 'constant value'; } } + + public function __isset(string $property) + { + return \in_array($property, ['magicProperty', 'constantMagicProperty'], true); + } } diff --git a/src/Symfony/Component/PropertyAccess/Tests/PropertyAccessorTest.php b/src/Symfony/Component/PropertyAccess/Tests/PropertyAccessorTest.php index fc9844944c66e..dc5c5500b18ea 100644 --- a/src/Symfony/Component/PropertyAccess/Tests/PropertyAccessorTest.php +++ b/src/Symfony/Component/PropertyAccess/Tests/PropertyAccessorTest.php @@ -990,12 +990,19 @@ public function testGetValuePropertyThrowsExceptionIfUninitializedWithLazyGhost( public function testGetValueGetterThrowsExceptionIfUninitializedWithLazyGhost() { + $lazyGhost = $this->createUninitializedObjectPropertyGhost(); + $this->expectException(UninitializedPropertyException::class); $this->expectExceptionMessage('The property "Symfony\Component\PropertyAccess\Tests\Fixtures\UninitializedObjectProperty::$privateUninitialized" is not readable because it is typed "DateTimeInterface". You should initialize it or declare a default value instead.'); + $this->propertyAccessor->getValue($lazyGhost, 'privateUninitialized'); + } + + public function testIsReadableWithMissingPropertyAndLazyGhost() + { $lazyGhost = $this->createUninitializedObjectPropertyGhost(); - $this->propertyAccessor->getValue($lazyGhost, 'privateUninitialized'); + $this->assertFalse($this->propertyAccessor->isReadable($lazyGhost, 'dummy')); } private function createUninitializedObjectPropertyGhost(): UninitializedObjectProperty diff --git a/src/Symfony/Component/PropertyInfo/Extractor/ReflectionExtractor.php b/src/Symfony/Component/PropertyInfo/Extractor/ReflectionExtractor.php index bc0bc77342f0e..ab6a0dd1c5810 100644 --- a/src/Symfony/Component/PropertyInfo/Extractor/ReflectionExtractor.php +++ b/src/Symfony/Component/PropertyInfo/Extractor/ReflectionExtractor.php @@ -274,14 +274,12 @@ public function getReadInfo(string $class, string $property, array $context = [] return new PropertyReadInfo(PropertyReadInfo::TYPE_METHOD, $getsetter, $this->getReadVisiblityForMethod($method), $method->isStatic(), false); } - if ($allowMagicGet && $reflClass->hasMethod('__get') && ($reflClass->getMethod('__get')->getModifiers() & $this->methodReflectionFlags)) { - return new PropertyReadInfo(PropertyReadInfo::TYPE_PROPERTY, $property, PropertyReadInfo::VISIBILITY_PUBLIC, false, false); + if ($allowMagicGet && $reflClass->hasMethod('__get') && (($r = $reflClass->getMethod('__get'))->getModifiers() & $this->methodReflectionFlags)) { + return new PropertyReadInfo(PropertyReadInfo::TYPE_PROPERTY, $property, PropertyReadInfo::VISIBILITY_PUBLIC, false, $r->returnsReference()); } - if ($hasProperty && ($reflClass->getProperty($property)->getModifiers() & $this->propertyReflectionFlags)) { - $reflProperty = $reflClass->getProperty($property); - - return new PropertyReadInfo(PropertyReadInfo::TYPE_PROPERTY, $property, $this->getReadVisiblityForProperty($reflProperty), $reflProperty->isStatic(), true); + if ($hasProperty && (($r = $reflClass->getProperty($property))->getModifiers() & $this->propertyReflectionFlags)) { + return new PropertyReadInfo(PropertyReadInfo::TYPE_PROPERTY, $property, $this->getReadVisiblityForProperty($r), $r->isStatic(), true); } if ($allowMagicCall && $reflClass->hasMethod('__call') && ($reflClass->getMethod('__call')->getModifiers() & $this->methodReflectionFlags)) { From 5dbc82d477c684f69803044e282f1b54e368d10d Mon Sep 17 00:00:00 2001 From: Nicolas Grekas Date: Fri, 8 Mar 2024 17:17:45 +0100 Subject: [PATCH 19/81] Fix merge --- .github/workflows/unit-tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/unit-tests.yml b/.github/workflows/unit-tests.yml index 9a8e67df29aac..e46fb412d9bd4 100644 --- a/.github/workflows/unit-tests.yml +++ b/.github/workflows/unit-tests.yml @@ -60,7 +60,7 @@ jobs: git config --global init.defaultBranch main git config --global advice.detachedHead false - (php --ri relay 2>&1 > /dev/null) || sudo rm /etc/php/*/cli/conf.d/20-relay.ini + (php --ri relay 2>&1 > /dev/null) || sudo rm -f /etc/php/*/cli/conf.d/20-relay.ini COMPOSER_HOME="$(composer config home)" ([ -d "$COMPOSER_HOME" ] || mkdir "$COMPOSER_HOME") && cp .github/composer-config.json "$COMPOSER_HOME/config.json" From a788d3d3695832c6e6f3b77f67bb72439d62a647 Mon Sep 17 00:00:00 2001 From: Christian Flothmann Date: Sat, 9 Mar 2024 08:54:04 +0100 Subject: [PATCH 20/81] backport NoSuspiciousCharactersValidator test --- .../NoSuspiciousCharactersValidatorTest.php | 58 ++++++++++++------- 1 file changed, 37 insertions(+), 21 deletions(-) diff --git a/src/Symfony/Component/Validator/Tests/Constraints/NoSuspiciousCharactersValidatorTest.php b/src/Symfony/Component/Validator/Tests/Constraints/NoSuspiciousCharactersValidatorTest.php index 6894d2f95e5e4..d15e41660b7d3 100644 --- a/src/Symfony/Component/Validator/Tests/Constraints/NoSuspiciousCharactersValidatorTest.php +++ b/src/Symfony/Component/Validator/Tests/Constraints/NoSuspiciousCharactersValidatorTest.php @@ -56,14 +56,26 @@ public static function provideNonSuspiciousStrings(): iterable /** * @dataProvider provideSuspiciousStrings */ - public function testSuspiciousStrings(string $string, array $options, string $errorCode, string $errorMessage) + public function testSuspiciousStrings(string $string, array $options, array $errors) { $this->validator->validate($string, new NoSuspiciousCharacters($options)); - $this->buildViolation($errorMessage) - ->setCode($errorCode) - ->setParameter('{{ value }}', '"'.$string.'"') - ->assertRaised(); + $violations = null; + + foreach ($errors as $code => $message) { + if (null === $violations) { + $violations = $this->buildViolation($message); + } else { + $violations = $violations->buildNextViolation($message); + } + + $violations = $violations + ->setCode($code) + ->setParameter('{{ value }}', '"'.$string.'"') + ; + } + + $violations->assertRaised(); } public static function provideSuspiciousStrings(): iterable @@ -71,8 +83,7 @@ public static function provideSuspiciousStrings(): iterable yield 'Fails RESTRICTION_LEVEL check because of character outside ASCII range' => [ 'à', ['restrictionLevel' => NoSuspiciousCharacters::RESTRICTION_LEVEL_ASCII], - NoSuspiciousCharacters::RESTRICTION_LEVEL_ERROR, - 'This value contains characters that are not allowed by the current restriction-level.', + [NoSuspiciousCharacters::RESTRICTION_LEVEL_ERROR => 'This value contains characters that are not allowed by the current restriction-level.'], ]; yield 'Fails RESTRICTION_LEVEL check because of mixed-script string' => [ @@ -81,8 +92,7 @@ public static function provideSuspiciousStrings(): iterable 'restrictionLevel' => NoSuspiciousCharacters::RESTRICTION_LEVEL_SINGLE_SCRIPT, 'locales' => ['en', 'zh_Hant_TW'], ], - NoSuspiciousCharacters::RESTRICTION_LEVEL_ERROR, - 'This value contains characters that are not allowed by the current restriction-level.', + [NoSuspiciousCharacters::RESTRICTION_LEVEL_ERROR => 'This value contains characters that are not allowed by the current restriction-level.'], ]; yield 'Fails RESTRICTION_LEVEL check because RESTRICTION_LEVEL_HIGH disallows Armenian script' => [ @@ -91,8 +101,7 @@ public static function provideSuspiciousStrings(): iterable 'restrictionLevel' => NoSuspiciousCharacters::RESTRICTION_LEVEL_HIGH, 'locales' => ['en', 'hy_AM'], ], - NoSuspiciousCharacters::RESTRICTION_LEVEL_ERROR, - 'This value contains characters that are not allowed by the current restriction-level.', + [NoSuspiciousCharacters::RESTRICTION_LEVEL_ERROR => 'This value contains characters that are not allowed by the current restriction-level.'], ]; yield 'Fails RESTRICTION_LEVEL check because RESTRICTION_LEVEL_MODERATE disallows Greek script' => [ @@ -101,8 +110,7 @@ public static function provideSuspiciousStrings(): iterable 'restrictionLevel' => NoSuspiciousCharacters::RESTRICTION_LEVEL_MODERATE, 'locales' => ['en', 'el_GR'], ], - NoSuspiciousCharacters::RESTRICTION_LEVEL_ERROR, - 'This value contains characters that are not allowed by the current restriction-level.', + [NoSuspiciousCharacters::RESTRICTION_LEVEL_ERROR => 'This value contains characters that are not allowed by the current restriction-level.'], ]; yield 'Fails RESTRICTION_LEVEL check because of characters missing from the configured locales’ scripts' => [ @@ -111,8 +119,7 @@ public static function provideSuspiciousStrings(): iterable 'restrictionLevel' => NoSuspiciousCharacters::RESTRICTION_LEVEL_MINIMAL, 'locales' => ['en'], ], - NoSuspiciousCharacters::RESTRICTION_LEVEL_ERROR, - 'This value contains characters that are not allowed by the current restriction-level.', + [NoSuspiciousCharacters::RESTRICTION_LEVEL_ERROR => 'This value contains characters that are not allowed by the current restriction-level.'], ]; yield 'Fails INVISIBLE check because of duplicated non-spacing mark' => [ @@ -120,8 +127,7 @@ public static function provideSuspiciousStrings(): iterable [ 'checks' => NoSuspiciousCharacters::CHECK_INVISIBLE, ], - NoSuspiciousCharacters::INVISIBLE_ERROR, - 'Using invisible characters is not allowed.', + [NoSuspiciousCharacters::INVISIBLE_ERROR => 'Using invisible characters is not allowed.'], ]; yield 'Fails MIXED_NUMBERS check because of different numbering systems' => [ @@ -129,8 +135,7 @@ public static function provideSuspiciousStrings(): iterable [ 'checks' => NoSuspiciousCharacters::CHECK_MIXED_NUMBERS, ], - NoSuspiciousCharacters::MIXED_NUMBERS_ERROR, - 'Mixing numbers from different scripts is not allowed.', + [NoSuspiciousCharacters::MIXED_NUMBERS_ERROR => 'Mixing numbers from different scripts is not allowed.'], ]; yield 'Fails HIDDEN_OVERLAY check because of hidden combining character' => [ @@ -138,8 +143,19 @@ public static function provideSuspiciousStrings(): iterable [ 'checks' => NoSuspiciousCharacters::CHECK_HIDDEN_OVERLAY, ], - NoSuspiciousCharacters::HIDDEN_OVERLAY_ERROR, - 'Using hidden overlay characters is not allowed.', + [NoSuspiciousCharacters::HIDDEN_OVERLAY_ERROR => 'Using hidden overlay characters is not allowed.'], + ]; + + yield 'Fails both HIDDEN_OVERLAY and RESTRICTION_LEVEL checks' => [ + 'i̇', + [ + 'checks' => NoSuspiciousCharacters::CHECK_HIDDEN_OVERLAY, + 'restrictionLevel' => NoSuspiciousCharacters::RESTRICTION_LEVEL_ASCII, + ], + [ + NoSuspiciousCharacters::RESTRICTION_LEVEL_ERROR => 'This value contains characters that are not allowed by the current restriction-level.', + NoSuspiciousCharacters::HIDDEN_OVERLAY_ERROR => 'Using hidden overlay characters is not allowed.', + ], ]; } From 77df90b959071f1250a7feb0b833f11a74f7c6c0 Mon Sep 17 00:00:00 2001 From: Brajk19 Date: Sat, 2 Mar 2024 18:13:00 +0100 Subject: [PATCH 21/81] [Validator] UniqueValidator - normalize before reducing keys --- .../Validator/Constraints/UniqueValidator.php | 4 +-- .../Tests/Constraints/UniqueValidatorTest.php | 31 +++++++++++++++++++ 2 files changed, 33 insertions(+), 2 deletions(-) diff --git a/src/Symfony/Component/Validator/Constraints/UniqueValidator.php b/src/Symfony/Component/Validator/Constraints/UniqueValidator.php index 1e692fe682a21..b0eefd84cb82f 100644 --- a/src/Symfony/Component/Validator/Constraints/UniqueValidator.php +++ b/src/Symfony/Component/Validator/Constraints/UniqueValidator.php @@ -43,12 +43,12 @@ public function validate(mixed $value, Constraint $constraint) $collectionElements = []; $normalizer = $this->getNormalizer($constraint); foreach ($value as $element) { + $element = $normalizer($element); + if ($fields && !$element = $this->reduceElementKeys($fields, $element)) { continue; } - $element = $normalizer($element); - if (\in_array($element, $collectionElements, true)) { $this->context->buildViolation($constraint->message) ->setParameter('{{ value }}', $this->formatValue($value)) diff --git a/src/Symfony/Component/Validator/Tests/Constraints/UniqueValidatorTest.php b/src/Symfony/Component/Validator/Tests/Constraints/UniqueValidatorTest.php index 35bde67d9bd3f..3c2dd9f21c98f 100644 --- a/src/Symfony/Component/Validator/Tests/Constraints/UniqueValidatorTest.php +++ b/src/Symfony/Component/Validator/Tests/Constraints/UniqueValidatorTest.php @@ -16,6 +16,7 @@ use Symfony\Component\Validator\Exception\UnexpectedTypeException; use Symfony\Component\Validator\Exception\UnexpectedValueException; use Symfony\Component\Validator\Test\ConstraintValidatorTestCase; +use Symfony\Component\Validator\Tests\Dummy\DummyClassOne; class UniqueValidatorTest extends ConstraintValidatorTestCase { @@ -283,6 +284,36 @@ public static function getInvalidCollectionValues(): array ], ]; } + + public function testArrayOfObjectsUnique() + { + $array = [ + new DummyClassOne(), + new DummyClassOne(), + new DummyClassOne(), + ]; + + $array[0]->code = '1'; + $array[1]->code = '2'; + $array[2]->code = '3'; + + $this->validator->validate( + $array, + new Unique( + normalizer: [self::class, 'normalizeDummyClassOne'], + fields: 'code' + ) + ); + + $this->assertNoViolation(); + } + + public static function normalizeDummyClassOne(DummyClassOne $obj): array + { + return [ + 'code' => $obj->code, + ]; + } } class CallableClass From 0d824a72fa8300764f1cd49aaf943941392ae096 Mon Sep 17 00:00:00 2001 From: MatTheCat Date: Sat, 9 Mar 2024 17:19:41 +0100 Subject: [PATCH 22/81] =?UTF-8?q?[Validator]=20Allow=20BICs=E2=80=99=20fir?= =?UTF-8?q?st=20four=20characters=20to=20be=20digits?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../Component/Validator/Constraints/BicValidator.php | 10 ---------- .../Validator/Tests/Constraints/BicValidatorTest.php | 7 +------ 2 files changed, 1 insertion(+), 16 deletions(-) diff --git a/src/Symfony/Component/Validator/Constraints/BicValidator.php b/src/Symfony/Component/Validator/Constraints/BicValidator.php index 5e9d76621ae3e..240f2dd26c41a 100644 --- a/src/Symfony/Component/Validator/Constraints/BicValidator.php +++ b/src/Symfony/Component/Validator/Constraints/BicValidator.php @@ -102,16 +102,6 @@ public function validate($value, Constraint $constraint) return; } - // first 4 letters must be alphabetic (bank code) - if (!ctype_alpha(substr($canonicalize, 0, 4))) { - $this->context->buildViolation($constraint->message) - ->setParameter('{{ value }}', $this->formatValue($value)) - ->setCode(Bic::INVALID_BANK_CODE_ERROR) - ->addViolation(); - - return; - } - $bicCountryCode = substr($canonicalize, 4, 2); if (!isset(self::BIC_COUNTRY_TO_IBAN_COUNTRY_MAP[$bicCountryCode]) && !Countries::exists($bicCountryCode)) { $this->context->buildViolation($constraint->message) diff --git a/src/Symfony/Component/Validator/Tests/Constraints/BicValidatorTest.php b/src/Symfony/Component/Validator/Tests/Constraints/BicValidatorTest.php index 0acfb67a63bd0..536e74b073a74 100644 --- a/src/Symfony/Component/Validator/Tests/Constraints/BicValidatorTest.php +++ b/src/Symfony/Component/Validator/Tests/Constraints/BicValidatorTest.php @@ -199,7 +199,6 @@ public function testValidBics($bic) public static function getValidBics() { - // http://formvalidation.io/validators/bic/ return [ ['ASPKAT2LXXX'], ['ASPKAT2L'], @@ -207,6 +206,7 @@ public static function getValidBics() ['UNCRIT2B912'], ['DABADKKK'], ['RZOOAT2L303'], + ['1SBACNBXSHA'], ]; } @@ -252,11 +252,6 @@ public static function getInvalidBics() ['ASPKAT2LX', Bic::INVALID_LENGTH_ERROR], ['ASPKAT2LXXX1', Bic::INVALID_LENGTH_ERROR], ['DABADKK', Bic::INVALID_LENGTH_ERROR], - ['1SBACNBXSHA', Bic::INVALID_BANK_CODE_ERROR], - ['RZ00AT2L303', Bic::INVALID_BANK_CODE_ERROR], - ['D2BACNBXSHA', Bic::INVALID_BANK_CODE_ERROR], - ['DS3ACNBXSHA', Bic::INVALID_BANK_CODE_ERROR], - ['DSB4CNBXSHA', Bic::INVALID_BANK_CODE_ERROR], ['DEUT12HH', Bic::INVALID_COUNTRY_CODE_ERROR], ['DSBAC6BXSHA', Bic::INVALID_COUNTRY_CODE_ERROR], ['DSBA5NBXSHA', Bic::INVALID_COUNTRY_CODE_ERROR], From 02b54a14e0c3bbb459170b3b866699156afa94ae Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gr=C3=A9goire=20Pineau?= Date: Thu, 8 Feb 2024 17:44:38 +0100 Subject: [PATCH 23/81] [Workflow] Fix Marking when it must contains more than one tokens --- src/Symfony/Component/Workflow/Marking.php | 37 ++++++-- .../Component/Workflow/Tests/MarkingTest.php | 54 +++++++++++- .../Workflow/Tests/WorkflowBuilderTrait.php | 39 +++++++++ .../Component/Workflow/Tests/WorkflowTest.php | 85 ++++++++++++++++--- 4 files changed, 192 insertions(+), 23 deletions(-) diff --git a/src/Symfony/Component/Workflow/Marking.php b/src/Symfony/Component/Workflow/Marking.php index 4396c2f374112..55abef2acea98 100644 --- a/src/Symfony/Component/Workflow/Marking.php +++ b/src/Symfony/Component/Workflow/Marking.php @@ -19,7 +19,7 @@ class Marking { private $places = []; - private $context = null; + private $context; /** * @param int[] $representation Keys are the place name and values should be 1 @@ -27,23 +27,46 @@ class Marking public function __construct(array $representation = []) { foreach ($representation as $place => $nbToken) { - $this->mark($place); + $this->mark($place, $nbToken); } } - public function mark(string $place) + public function mark(string $place, int $nbToken = 1) { - $this->places[$place] = 1; + if ($nbToken < 1) { + throw new \LogicException(sprintf('The number of tokens must be greater than 0, "%s" given.', $nbToken)); + } + + if (!\array_key_exists($place, $this->places)) { + $this->places[$place] = 0; + } + $this->places[$place] += $nbToken; } - public function unmark(string $place) + public function unmark(string $place, int $nbToken = 1) { - unset($this->places[$place]); + if ($nbToken < 1) { + throw new \LogicException(sprintf('The number of tokens must be greater than 0, "%s" given.', $nbToken)); + } + + if (!$this->has($place)) { + throw new \LogicException(sprintf('The place "%s" is not marked.', $place)); + } + + $this->places[$place] -= $nbToken; + + if (0 > $this->places[$place]) { + throw new \LogicException(sprintf('The place "%s" could not contain a negative token number.', $place)); + } + + if (0 === $this->places[$place]) { + unset($this->places[$place]); + } } public function has(string $place) { - return isset($this->places[$place]); + return \array_key_exists($place, $this->places); } public function getPlaces() diff --git a/src/Symfony/Component/Workflow/Tests/MarkingTest.php b/src/Symfony/Component/Workflow/Tests/MarkingTest.php index 0a1c22b4cc9d7..fc06b725d158e 100644 --- a/src/Symfony/Component/Workflow/Tests/MarkingTest.php +++ b/src/Symfony/Component/Workflow/Tests/MarkingTest.php @@ -22,24 +22,70 @@ public function testMarking() $this->assertTrue($marking->has('a')); $this->assertFalse($marking->has('b')); - $this->assertSame(['a' => 1], $marking->getPlaces()); + $this->assertPlaces(['a' => 1], $marking); $marking->mark('b'); $this->assertTrue($marking->has('a')); $this->assertTrue($marking->has('b')); - $this->assertSame(['a' => 1, 'b' => 1], $marking->getPlaces()); + $this->assertPlaces(['a' => 1, 'b' => 1], $marking); $marking->unmark('a'); $this->assertFalse($marking->has('a')); $this->assertTrue($marking->has('b')); - $this->assertSame(['b' => 1], $marking->getPlaces()); + $this->assertPlaces(['b' => 1], $marking); $marking->unmark('b'); $this->assertFalse($marking->has('a')); $this->assertFalse($marking->has('b')); - $this->assertSame([], $marking->getPlaces()); + $this->assertPlaces([], $marking); + + $marking->mark('a'); + $this->assertPlaces(['a' => 1], $marking); + + $marking->mark('a'); + $this->assertPlaces(['a' => 2], $marking); + + $marking->unmark('a'); + $this->assertPlaces(['a' => 1], $marking); + + $marking->unmark('a'); + $this->assertPlaces([], $marking); + } + + public function testGuardNotMarked() + { + $marking = new Marking([]); + + $this->expectException(\LogicException::class); + $this->expectExceptionMessage('The place "a" is not marked.'); + $marking->unmark('a'); + } + + public function testGuardNotNbTokenLowerThanZero() + { + $marking = new Marking(['a' => 1]); + + $this->expectException(\LogicException::class); + $this->expectExceptionMessage('The place "a" could not contain a negative token number.'); + $marking->unmark('a', 2); + } + + public function testGuardNotNbTokenEquals0() + { + $marking = new Marking(['a' => 1]); + + $this->expectException(\LogicException::class); + $this->expectExceptionMessage('The number of tokens must be greater than 0, "0" given.'); + $marking->unmark('a', 0); + } + + private function assertPlaces(array $expected, Marking $marking) + { + $places = $marking->getPlaces(); + ksort($places); + $this->assertSame($expected, $places); } } diff --git a/src/Symfony/Component/Workflow/Tests/WorkflowBuilderTrait.php b/src/Symfony/Component/Workflow/Tests/WorkflowBuilderTrait.php index ae812324c6395..5e825a4badde0 100644 --- a/src/Symfony/Component/Workflow/Tests/WorkflowBuilderTrait.php +++ b/src/Symfony/Component/Workflow/Tests/WorkflowBuilderTrait.php @@ -158,4 +158,43 @@ private static function createComplexStateMachineDefinition() // | d | -------------+ // +-----+ } + + private static function createWorkflowWithSameNameBackTransition(): Definition + { + $places = range('a', 'c'); + + $transitions = []; + $transitions[] = new Transition('a_to_bc', 'a', ['b', 'c']); + $transitions[] = new Transition('back1', 'b', 'a'); + $transitions[] = new Transition('back1', 'c', 'b'); + $transitions[] = new Transition('back2', 'c', 'b'); + $transitions[] = new Transition('back2', 'b', 'a'); + $transitions[] = new Transition('c_to_cb', 'c', ['b', 'c']); + + return new Definition($places, $transitions); + + // The graph looks like: + // +-----------------------------------------------------------------+ + // | | + // | | + // | +---------------------------------------------+ | + // v | v | + // +---+ +---------+ +-------+ +---------+ +---+ +-------+ + // | a | --> | a_to_bc | --> | | --> | back2 | --> | | --> | back2 | + // +---+ +---------+ | | +---------+ | | +-------+ + // ^ | | | | + // | | c | <-----+ | b | + // | | | | | | + // | | | +---------+ | | +-------+ + // | | | --> | c_to_cb | --> | | --> | back1 | + // | +-------+ +---------+ +---+ +-------+ + // | | ^ | + // | | | | + // | v | | + // | +-------+ | | + // | | back1 | ----------------------+ | + // | +-------+ | + // | | + // +-----------------------------------------------------------------+ + } } diff --git a/src/Symfony/Component/Workflow/Tests/WorkflowTest.php b/src/Symfony/Component/Workflow/Tests/WorkflowTest.php index a109655cd22c2..0ed36029adaa3 100644 --- a/src/Symfony/Component/Workflow/Tests/WorkflowTest.php +++ b/src/Symfony/Component/Workflow/Tests/WorkflowTest.php @@ -330,28 +330,32 @@ public function testApplyWithSameNameTransition() $marking = $workflow->apply($subject, 'a_to_bc'); - $this->assertFalse($marking->has('a')); - $this->assertTrue($marking->has('b')); - $this->assertTrue($marking->has('c')); + $this->assertPlaces([ + 'b' => 1, + 'c' => 1, + ], $marking); $marking = $workflow->apply($subject, 'to_a'); - $this->assertTrue($marking->has('a')); - $this->assertFalse($marking->has('b')); - $this->assertFalse($marking->has('c')); + // Two tokens in "a" + $this->assertPlaces([ + 'a' => 2, + ], $marking); $workflow->apply($subject, 'a_to_bc'); $marking = $workflow->apply($subject, 'b_to_c'); - $this->assertFalse($marking->has('a')); - $this->assertFalse($marking->has('b')); - $this->assertTrue($marking->has('c')); + $this->assertPlaces([ + 'a' => 1, + 'c' => 2, + ], $marking); $marking = $workflow->apply($subject, 'to_a'); - $this->assertTrue($marking->has('a')); - $this->assertFalse($marking->has('b')); - $this->assertFalse($marking->has('c')); + $this->assertPlaces([ + 'a' => 2, + 'c' => 1, + ], $marking); } public function testApplyWithSameNameTransition2() @@ -785,6 +789,63 @@ public function testGetEnabledTransitionsWithSameNameTransition() $this->assertSame('to_a', $transitions[1]->getName()); $this->assertSame('to_a', $transitions[2]->getName()); } + + /** + * @@testWith ["back1"] + * ["back2"] + */ + public function testApplyWithSameNameBackTransition(string $transition) + { + $definition = $this->createWorkflowWithSameNameBackTransition(); + $workflow = new Workflow($definition, new MethodMarkingStore()); + + $subject = new Subject(); + + $marking = $workflow->apply($subject, 'a_to_bc'); + $this->assertPlaces([ + 'b' => 1, + 'c' => 1, + ], $marking); + + $marking = $workflow->apply($subject, $transition); + $this->assertPlaces([ + 'a' => 1, + 'b' => 1, + ], $marking); + + $marking = $workflow->apply($subject, $transition); + $this->assertPlaces([ + 'a' => 2, + ], $marking); + + $marking = $workflow->apply($subject, 'a_to_bc'); + $this->assertPlaces([ + 'a' => 1, + 'b' => 1, + 'c' => 1, + ], $marking); + + $marking = $workflow->apply($subject, 'c_to_cb'); + $this->assertPlaces([ + 'a' => 1, + 'b' => 2, + 'c' => 1, + ], $marking); + + $marking = $workflow->apply($subject, 'c_to_cb'); + $this->assertPlaces([ + 'a' => 1, + 'b' => 3, + 'c' => 1, + ], $marking); + } + + private function assertPlaces(array $expected, Marking $marking) + { + $places = $marking->getPlaces(); + ksort($places); + $this->assertSame($expected, $places); + } } class EventDispatcherMock implements \Symfony\Contracts\EventDispatcher\EventDispatcherInterface From 10d7d43a5bc329fbe6da35ee515d6bdfc934fee0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gr=C3=A9goire=20Pineau?= Date: Tue, 12 Mar 2024 09:06:46 +0100 Subject: [PATCH 24/81] Revert "bug #53865 [Workflow]Fix Marking when it must contains more than one tokens (lyrixx)" This reverts commit 5ce412b6f772d78185557bc8b36848615c583d20, reversing changes made to 7dae80db975ccdba768ef67b2f1a8b7c195bf7e9. --- src/Symfony/Component/Workflow/Marking.php | 37 ++------ .../Component/Workflow/Tests/MarkingTest.php | 54 +----------- .../Workflow/Tests/WorkflowBuilderTrait.php | 39 --------- .../Component/Workflow/Tests/WorkflowTest.php | 85 +++---------------- 4 files changed, 23 insertions(+), 192 deletions(-) diff --git a/src/Symfony/Component/Workflow/Marking.php b/src/Symfony/Component/Workflow/Marking.php index 55abef2acea98..4396c2f374112 100644 --- a/src/Symfony/Component/Workflow/Marking.php +++ b/src/Symfony/Component/Workflow/Marking.php @@ -19,7 +19,7 @@ class Marking { private $places = []; - private $context; + private $context = null; /** * @param int[] $representation Keys are the place name and values should be 1 @@ -27,46 +27,23 @@ class Marking public function __construct(array $representation = []) { foreach ($representation as $place => $nbToken) { - $this->mark($place, $nbToken); + $this->mark($place); } } - public function mark(string $place, int $nbToken = 1) + public function mark(string $place) { - if ($nbToken < 1) { - throw new \LogicException(sprintf('The number of tokens must be greater than 0, "%s" given.', $nbToken)); - } - - if (!\array_key_exists($place, $this->places)) { - $this->places[$place] = 0; - } - $this->places[$place] += $nbToken; + $this->places[$place] = 1; } - public function unmark(string $place, int $nbToken = 1) + public function unmark(string $place) { - if ($nbToken < 1) { - throw new \LogicException(sprintf('The number of tokens must be greater than 0, "%s" given.', $nbToken)); - } - - if (!$this->has($place)) { - throw new \LogicException(sprintf('The place "%s" is not marked.', $place)); - } - - $this->places[$place] -= $nbToken; - - if (0 > $this->places[$place]) { - throw new \LogicException(sprintf('The place "%s" could not contain a negative token number.', $place)); - } - - if (0 === $this->places[$place]) { - unset($this->places[$place]); - } + unset($this->places[$place]); } public function has(string $place) { - return \array_key_exists($place, $this->places); + return isset($this->places[$place]); } public function getPlaces() diff --git a/src/Symfony/Component/Workflow/Tests/MarkingTest.php b/src/Symfony/Component/Workflow/Tests/MarkingTest.php index fc06b725d158e..0a1c22b4cc9d7 100644 --- a/src/Symfony/Component/Workflow/Tests/MarkingTest.php +++ b/src/Symfony/Component/Workflow/Tests/MarkingTest.php @@ -22,70 +22,24 @@ public function testMarking() $this->assertTrue($marking->has('a')); $this->assertFalse($marking->has('b')); - $this->assertPlaces(['a' => 1], $marking); + $this->assertSame(['a' => 1], $marking->getPlaces()); $marking->mark('b'); $this->assertTrue($marking->has('a')); $this->assertTrue($marking->has('b')); - $this->assertPlaces(['a' => 1, 'b' => 1], $marking); + $this->assertSame(['a' => 1, 'b' => 1], $marking->getPlaces()); $marking->unmark('a'); $this->assertFalse($marking->has('a')); $this->assertTrue($marking->has('b')); - $this->assertPlaces(['b' => 1], $marking); + $this->assertSame(['b' => 1], $marking->getPlaces()); $marking->unmark('b'); $this->assertFalse($marking->has('a')); $this->assertFalse($marking->has('b')); - $this->assertPlaces([], $marking); - - $marking->mark('a'); - $this->assertPlaces(['a' => 1], $marking); - - $marking->mark('a'); - $this->assertPlaces(['a' => 2], $marking); - - $marking->unmark('a'); - $this->assertPlaces(['a' => 1], $marking); - - $marking->unmark('a'); - $this->assertPlaces([], $marking); - } - - public function testGuardNotMarked() - { - $marking = new Marking([]); - - $this->expectException(\LogicException::class); - $this->expectExceptionMessage('The place "a" is not marked.'); - $marking->unmark('a'); - } - - public function testGuardNotNbTokenLowerThanZero() - { - $marking = new Marking(['a' => 1]); - - $this->expectException(\LogicException::class); - $this->expectExceptionMessage('The place "a" could not contain a negative token number.'); - $marking->unmark('a', 2); - } - - public function testGuardNotNbTokenEquals0() - { - $marking = new Marking(['a' => 1]); - - $this->expectException(\LogicException::class); - $this->expectExceptionMessage('The number of tokens must be greater than 0, "0" given.'); - $marking->unmark('a', 0); - } - - private function assertPlaces(array $expected, Marking $marking) - { - $places = $marking->getPlaces(); - ksort($places); - $this->assertSame($expected, $places); + $this->assertSame([], $marking->getPlaces()); } } diff --git a/src/Symfony/Component/Workflow/Tests/WorkflowBuilderTrait.php b/src/Symfony/Component/Workflow/Tests/WorkflowBuilderTrait.php index 5e825a4badde0..ae812324c6395 100644 --- a/src/Symfony/Component/Workflow/Tests/WorkflowBuilderTrait.php +++ b/src/Symfony/Component/Workflow/Tests/WorkflowBuilderTrait.php @@ -158,43 +158,4 @@ private static function createComplexStateMachineDefinition() // | d | -------------+ // +-----+ } - - private static function createWorkflowWithSameNameBackTransition(): Definition - { - $places = range('a', 'c'); - - $transitions = []; - $transitions[] = new Transition('a_to_bc', 'a', ['b', 'c']); - $transitions[] = new Transition('back1', 'b', 'a'); - $transitions[] = new Transition('back1', 'c', 'b'); - $transitions[] = new Transition('back2', 'c', 'b'); - $transitions[] = new Transition('back2', 'b', 'a'); - $transitions[] = new Transition('c_to_cb', 'c', ['b', 'c']); - - return new Definition($places, $transitions); - - // The graph looks like: - // +-----------------------------------------------------------------+ - // | | - // | | - // | +---------------------------------------------+ | - // v | v | - // +---+ +---------+ +-------+ +---------+ +---+ +-------+ - // | a | --> | a_to_bc | --> | | --> | back2 | --> | | --> | back2 | - // +---+ +---------+ | | +---------+ | | +-------+ - // ^ | | | | - // | | c | <-----+ | b | - // | | | | | | - // | | | +---------+ | | +-------+ - // | | | --> | c_to_cb | --> | | --> | back1 | - // | +-------+ +---------+ +---+ +-------+ - // | | ^ | - // | | | | - // | v | | - // | +-------+ | | - // | | back1 | ----------------------+ | - // | +-------+ | - // | | - // +-----------------------------------------------------------------+ - } } diff --git a/src/Symfony/Component/Workflow/Tests/WorkflowTest.php b/src/Symfony/Component/Workflow/Tests/WorkflowTest.php index 0ed36029adaa3..a109655cd22c2 100644 --- a/src/Symfony/Component/Workflow/Tests/WorkflowTest.php +++ b/src/Symfony/Component/Workflow/Tests/WorkflowTest.php @@ -330,32 +330,28 @@ public function testApplyWithSameNameTransition() $marking = $workflow->apply($subject, 'a_to_bc'); - $this->assertPlaces([ - 'b' => 1, - 'c' => 1, - ], $marking); + $this->assertFalse($marking->has('a')); + $this->assertTrue($marking->has('b')); + $this->assertTrue($marking->has('c')); $marking = $workflow->apply($subject, 'to_a'); - // Two tokens in "a" - $this->assertPlaces([ - 'a' => 2, - ], $marking); + $this->assertTrue($marking->has('a')); + $this->assertFalse($marking->has('b')); + $this->assertFalse($marking->has('c')); $workflow->apply($subject, 'a_to_bc'); $marking = $workflow->apply($subject, 'b_to_c'); - $this->assertPlaces([ - 'a' => 1, - 'c' => 2, - ], $marking); + $this->assertFalse($marking->has('a')); + $this->assertFalse($marking->has('b')); + $this->assertTrue($marking->has('c')); $marking = $workflow->apply($subject, 'to_a'); - $this->assertPlaces([ - 'a' => 2, - 'c' => 1, - ], $marking); + $this->assertTrue($marking->has('a')); + $this->assertFalse($marking->has('b')); + $this->assertFalse($marking->has('c')); } public function testApplyWithSameNameTransition2() @@ -789,63 +785,6 @@ public function testGetEnabledTransitionsWithSameNameTransition() $this->assertSame('to_a', $transitions[1]->getName()); $this->assertSame('to_a', $transitions[2]->getName()); } - - /** - * @@testWith ["back1"] - * ["back2"] - */ - public function testApplyWithSameNameBackTransition(string $transition) - { - $definition = $this->createWorkflowWithSameNameBackTransition(); - $workflow = new Workflow($definition, new MethodMarkingStore()); - - $subject = new Subject(); - - $marking = $workflow->apply($subject, 'a_to_bc'); - $this->assertPlaces([ - 'b' => 1, - 'c' => 1, - ], $marking); - - $marking = $workflow->apply($subject, $transition); - $this->assertPlaces([ - 'a' => 1, - 'b' => 1, - ], $marking); - - $marking = $workflow->apply($subject, $transition); - $this->assertPlaces([ - 'a' => 2, - ], $marking); - - $marking = $workflow->apply($subject, 'a_to_bc'); - $this->assertPlaces([ - 'a' => 1, - 'b' => 1, - 'c' => 1, - ], $marking); - - $marking = $workflow->apply($subject, 'c_to_cb'); - $this->assertPlaces([ - 'a' => 1, - 'b' => 2, - 'c' => 1, - ], $marking); - - $marking = $workflow->apply($subject, 'c_to_cb'); - $this->assertPlaces([ - 'a' => 1, - 'b' => 3, - 'c' => 1, - ], $marking); - } - - private function assertPlaces(array $expected, Marking $marking) - { - $places = $marking->getPlaces(); - ksort($places); - $this->assertSame($expected, $places); - } } class EventDispatcherMock implements \Symfony\Contracts\EventDispatcher\EventDispatcherInterface From 159ebc6df1c7f739bfe8fcd33a6c4751f9a379cc Mon Sep 17 00:00:00 2001 From: George Sparrow Date: Tue, 5 Mar 2024 18:26:30 +0100 Subject: [PATCH 25/81] updating missing translations for Greek #53768 --- .../Resources/translations/validators.el.xlf | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/Symfony/Component/Validator/Resources/translations/validators.el.xlf b/src/Symfony/Component/Validator/Resources/translations/validators.el.xlf index f7677fabfb89a..db927e1d51e65 100644 --- a/src/Symfony/Component/Validator/Resources/translations/validators.el.xlf +++ b/src/Symfony/Component/Validator/Resources/translations/validators.el.xlf @@ -136,7 +136,7 @@ This value is not a valid IP address. - Αυτή η τιμή δεν είναι έγκυρη διεύθυνση IP. + Αυτή η IP διεύθυνση δεν είναι έγκυρη. This value is not a valid language. @@ -192,7 +192,7 @@ No temporary folder was configured in php.ini, or the configured folder does not exist. - Δεν ρυθμίστηκε προσωρινός φάκελος στο php.ini, ή ο ρυθμισμένος φάκελος δεν υπάρχει. + Δεν έχει ρυθμιστεί προσωρινός φάκελος στο php.ini, ή ο ρυθμισμένος φάκελος δεν υπάρχει. Cannot write temporary file to disk. @@ -224,7 +224,7 @@ This value is not a valid International Bank Account Number (IBAN). - Αυτή η τιμή δεν είναι έγκυρος Διεθνής Αριθμός Τραπεζικού Λογαριασμού (IBAN). + Αυτός δεν είναι έγκυρος διεθνής αριθμός τραπεζικού λογαριασμού (IBAN). This value is not a valid ISBN-10. @@ -312,7 +312,7 @@ This value is not a valid Business Identifier Code (BIC). - Αυτή η τιμή δεν είναι έγκυρος Κωδικός Ταυτοποίησης Επιχείρησης (BIC). + Αυτός ο αριθμός δεν είναι έγκυρος Κωδικός Ταυτοποίησης Επιχείρησης (BIC). Error @@ -320,7 +320,7 @@ This value is not a valid UUID. - Αυτή η τιμή δεν είναι έγκυρη UUID. + Αυτός ο αριθμός δεν είναι έγκυρη UUID. This value should be a multiple of {{ compared_value }}. @@ -436,7 +436,7 @@ This value is not a valid MAC address. - Αυτή η τιμή δεν είναι έγκυρη διεύθυνση MAC. + Αυτός ο αριθμός δεν είναι έγκυρη διεύθυνση MAC. From 4966c75bda42c2a4d9c00bb02c2766958ae89d60 Mon Sep 17 00:00:00 2001 From: Arjen van der Meijden Date: Fri, 8 Mar 2024 15:43:25 +0100 Subject: [PATCH 26/81] [HttpClient] Lazily initialize CurlClientState --- .../Component/HttpClient/CurlHttpClient.php | 61 +++++++++++++------ .../HttpClient/Tests/CurlHttpClientTest.php | 4 +- 2 files changed, 44 insertions(+), 21 deletions(-) diff --git a/src/Symfony/Component/HttpClient/CurlHttpClient.php b/src/Symfony/Component/HttpClient/CurlHttpClient.php index 52e1c74267b7e..3a2fba025aeff 100644 --- a/src/Symfony/Component/HttpClient/CurlHttpClient.php +++ b/src/Symfony/Component/HttpClient/CurlHttpClient.php @@ -50,6 +50,9 @@ final class CurlHttpClient implements HttpClientInterface, LoggerAwareInterface, */ private $logger; + private $maxHostConnections; + private $maxPendingPushes; + /** * An internal object to share state between the client and its responses. * @@ -70,18 +73,22 @@ public function __construct(array $defaultOptions = [], int $maxHostConnections throw new \LogicException('You cannot use the "Symfony\Component\HttpClient\CurlHttpClient" as the "curl" extension is not installed.'); } + $this->maxHostConnections = $maxHostConnections; + $this->maxPendingPushes = $maxPendingPushes; + $this->defaultOptions['buffer'] = $this->defaultOptions['buffer'] ?? \Closure::fromCallable([__CLASS__, 'shouldBuffer']); if ($defaultOptions) { [, $this->defaultOptions] = self::prepareRequest(null, null, $defaultOptions, $this->defaultOptions); } - - $this->multi = new CurlClientState($maxHostConnections, $maxPendingPushes); } public function setLogger(LoggerInterface $logger): void { - $this->logger = $this->multi->logger = $logger; + $this->logger = $logger; + if (isset($this->multi)) { + $this->multi->logger = $logger; + } } /** @@ -91,6 +98,8 @@ public function setLogger(LoggerInterface $logger): void */ public function request(string $method, string $url, array $options = []): ResponseInterface { + $multi = $this->ensureState(); + [$url, $options] = self::prepareRequest($method, $url, $options, $this->defaultOptions); $scheme = $url['scheme']; $authority = $url['authority']; @@ -161,25 +170,25 @@ public function request(string $method, string $url, array $options = []): Respo } // curl's resolve feature varies by host:port but ours varies by host only, let's handle this with our own DNS map - if (isset($this->multi->dnsCache->hostnames[$host])) { - $options['resolve'] += [$host => $this->multi->dnsCache->hostnames[$host]]; + if (isset($multi->dnsCache->hostnames[$host])) { + $options['resolve'] += [$host => $multi->dnsCache->hostnames[$host]]; } - if ($options['resolve'] || $this->multi->dnsCache->evictions) { + if ($options['resolve'] || $multi->dnsCache->evictions) { // First reset any old DNS cache entries then add the new ones - $resolve = $this->multi->dnsCache->evictions; - $this->multi->dnsCache->evictions = []; + $resolve = $multi->dnsCache->evictions; + $multi->dnsCache->evictions = []; $port = parse_url($authority, \PHP_URL_PORT) ?: ('http:' === $scheme ? 80 : 443); if ($resolve && 0x072A00 > CurlClientState::$curlVersion['version_number']) { // DNS cache removals require curl 7.42 or higher - $this->multi->reset(); + $multi->reset(); } foreach ($options['resolve'] as $host => $ip) { $resolve[] = null === $ip ? "-$host:$port" : "$host:$port:$ip"; - $this->multi->dnsCache->hostnames[$host] = $ip; - $this->multi->dnsCache->removals["-$host:$port"] = "-$host:$port"; + $multi->dnsCache->hostnames[$host] = $ip; + $multi->dnsCache->removals["-$host:$port"] = "-$host:$port"; } $curlopts[\CURLOPT_RESOLVE] = $resolve; @@ -281,8 +290,8 @@ public function request(string $method, string $url, array $options = []): Respo $curlopts += $options['extra']['curl']; } - if ($pushedResponse = $this->multi->pushedResponses[$url] ?? null) { - unset($this->multi->pushedResponses[$url]); + if ($pushedResponse = $multi->pushedResponses[$url] ?? null) { + unset($multi->pushedResponses[$url]); if (self::acceptPushForRequest($method, $options, $pushedResponse)) { $this->logger && $this->logger->debug(sprintf('Accepting pushed response: "%s %s"', $method, $url)); @@ -290,7 +299,7 @@ public function request(string $method, string $url, array $options = []): Respo // Reinitialize the pushed response with request's options $ch = $pushedResponse->handle; $pushedResponse = $pushedResponse->response; - $pushedResponse->__construct($this->multi, $url, $options, $this->logger); + $pushedResponse->__construct($multi, $url, $options, $this->logger); } else { $this->logger && $this->logger->debug(sprintf('Rejecting pushed response: "%s"', $url)); $pushedResponse = null; @@ -300,7 +309,7 @@ public function request(string $method, string $url, array $options = []): Respo if (!$pushedResponse) { $ch = curl_init(); $this->logger && $this->logger->info(sprintf('Request: "%s %s"', $method, $url)); - $curlopts += [\CURLOPT_SHARE => $this->multi->share]; + $curlopts += [\CURLOPT_SHARE => $multi->share]; } foreach ($curlopts as $opt => $value) { @@ -310,7 +319,7 @@ public function request(string $method, string $url, array $options = []): Respo } } - return $pushedResponse ?? new CurlResponse($this->multi, $ch, $options, $this->logger, $method, self::createRedirectResolver($options, $host), CurlClientState::$curlVersion['version_number']); + return $pushedResponse ?? new CurlResponse($multi, $ch, $options, $this->logger, $method, self::createRedirectResolver($options, $host), CurlClientState::$curlVersion['version_number']); } /** @@ -324,9 +333,11 @@ public function stream($responses, ?float $timeout = null): ResponseStreamInterf throw new \TypeError(sprintf('"%s()" expects parameter 1 to be an iterable of CurlResponse objects, "%s" given.', __METHOD__, get_debug_type($responses))); } - if (\is_resource($this->multi->handle) || $this->multi->handle instanceof \CurlMultiHandle) { + $multi = $this->ensureState(); + + if (\is_resource($multi->handle) || $multi->handle instanceof \CurlMultiHandle) { $active = 0; - while (\CURLM_CALL_MULTI_PERFORM === curl_multi_exec($this->multi->handle, $active)) { + while (\CURLM_CALL_MULTI_PERFORM === curl_multi_exec($multi->handle, $active)) { } } @@ -335,7 +346,9 @@ public function stream($responses, ?float $timeout = null): ResponseStreamInterf public function reset() { - $this->multi->reset(); + if (isset($this->multi)) { + $this->multi->reset(); + } } /** @@ -439,6 +452,16 @@ private static function createRedirectResolver(array $options, string $host): \C }; } + private function ensureState(): CurlClientState + { + if (!isset($this->multi)) { + $this->multi = new CurlClientState($this->maxHostConnections, $this->maxPendingPushes); + $this->multi->logger = $this->logger; + } + + return $this->multi; + } + private function findConstantName(int $opt): ?string { $constants = array_filter(get_defined_constants(), static function ($v, $k) use ($opt) { diff --git a/src/Symfony/Component/HttpClient/Tests/CurlHttpClientTest.php b/src/Symfony/Component/HttpClient/Tests/CurlHttpClientTest.php index 284a243496b91..ec43a83a075db 100644 --- a/src/Symfony/Component/HttpClient/Tests/CurlHttpClientTest.php +++ b/src/Symfony/Component/HttpClient/Tests/CurlHttpClientTest.php @@ -63,9 +63,9 @@ public function testHandleIsReinitOnReset() { $httpClient = $this->getHttpClient(__FUNCTION__); - $r = new \ReflectionProperty($httpClient, 'multi'); + $r = new \ReflectionMethod($httpClient, 'ensureState'); $r->setAccessible(true); - $clientState = $r->getValue($httpClient); + $clientState = $r->invoke($httpClient); $initialShareId = $clientState->share; $httpClient->reset(); self::assertNotSame($initialShareId, $clientState->share); From 684e7af5a847d40d61213be19bf75089bf478df9 Mon Sep 17 00:00:00 2001 From: Arnout Boks Date: Mon, 11 Mar 2024 15:45:10 +0100 Subject: [PATCH 27/81] [Mailer] Fix sendmail transport not handling failure --- .../Fixtures/fake-failing-sendmail.php | 4 +++ .../Tests/Transport/SendmailTransportTest.php | 25 +++++++++++++++++++ .../Transport/Smtp/Stream/AbstractStream.php | 3 ++- .../Transport/Smtp/Stream/ProcessStream.php | 8 +++++- 4 files changed, 38 insertions(+), 2 deletions(-) create mode 100755 src/Symfony/Component/Mailer/Tests/Transport/Fixtures/fake-failing-sendmail.php diff --git a/src/Symfony/Component/Mailer/Tests/Transport/Fixtures/fake-failing-sendmail.php b/src/Symfony/Component/Mailer/Tests/Transport/Fixtures/fake-failing-sendmail.php new file mode 100755 index 0000000000000..920b980e0f714 --- /dev/null +++ b/src/Symfony/Component/Mailer/Tests/Transport/Fixtures/fake-failing-sendmail.php @@ -0,0 +1,4 @@ +#!/usr/bin/env php +assertStringEqualsFile($this->argsPath, __DIR__.'/Fixtures/fake-sendmail.php -ffrom@mail.com recipient@mail.com'); } + + public function testThrowsTransportExceptionOnFailure() + { + if ('\\' === \DIRECTORY_SEPARATOR) { + $this->markTestSkipped('Windows does not support shebangs nor non-blocking standard streams'); + } + + $mail = new Email(); + $mail + ->from('from@mail.com') + ->to('to@mail.com') + ->subject('Subject') + ->text('Some text') + ; + + $envelope = new DelayedEnvelope($mail); + $envelope->setRecipients([new Address('recipient@mail.com')]); + + $sendmailTransport = new SendmailTransport(self::FAKE_FAILING_SENDMAIL); + $this->expectException(TransportException::class); + $this->expectExceptionMessage('Process failed with exit code 42: Sending failed'); + $sendmailTransport->send($mail, $envelope); + } } diff --git a/src/Symfony/Component/Mailer/Transport/Smtp/Stream/AbstractStream.php b/src/Symfony/Component/Mailer/Transport/Smtp/Stream/AbstractStream.php index c53f8b54ee505..2be8fce94c93a 100644 --- a/src/Symfony/Component/Mailer/Transport/Smtp/Stream/AbstractStream.php +++ b/src/Symfony/Component/Mailer/Transport/Smtp/Stream/AbstractStream.php @@ -27,6 +27,7 @@ abstract class AbstractStream protected $stream; protected $in; protected $out; + protected $err; private $debug = ''; @@ -65,7 +66,7 @@ abstract public function initialize(): void; public function terminate(): void { - $this->stream = $this->out = $this->in = null; + $this->stream = $this->err = $this->out = $this->in = null; } public function readLine(): string diff --git a/src/Symfony/Component/Mailer/Transport/Smtp/Stream/ProcessStream.php b/src/Symfony/Component/Mailer/Transport/Smtp/Stream/ProcessStream.php index bc721ad0cd85f..808d9eb53fa68 100644 --- a/src/Symfony/Component/Mailer/Transport/Smtp/Stream/ProcessStream.php +++ b/src/Symfony/Component/Mailer/Transport/Smtp/Stream/ProcessStream.php @@ -45,14 +45,20 @@ public function initialize(): void } $this->in = &$pipes[0]; $this->out = &$pipes[1]; + $this->err = &$pipes[2]; } public function terminate(): void { if (null !== $this->stream) { fclose($this->in); + $out = stream_get_contents($this->out); fclose($this->out); - proc_close($this->stream); + $err = stream_get_contents($this->err); + fclose($this->err); + if (0 !== $exitCode = proc_close($this->stream)) { + throw new TransportException('Process failed with exit code '.$exitCode.': '.$out.$err); + } } parent::terminate(); From 66cf5cb11c139b6728b09e99b09303378c4e2277 Mon Sep 17 00:00:00 2001 From: Alexandre Daubois Date: Tue, 12 Mar 2024 14:08:16 +0100 Subject: [PATCH 28/81] [DoctrineBridge] Add missing return type --- .../Bridge/Doctrine/Tests/Fixtures/ContainerAwareFixture.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Symfony/Bridge/Doctrine/Tests/Fixtures/ContainerAwareFixture.php b/src/Symfony/Bridge/Doctrine/Tests/Fixtures/ContainerAwareFixture.php index 6655033ab4999..cccaeedee80a7 100644 --- a/src/Symfony/Bridge/Doctrine/Tests/Fixtures/ContainerAwareFixture.php +++ b/src/Symfony/Bridge/Doctrine/Tests/Fixtures/ContainerAwareFixture.php @@ -25,7 +25,7 @@ public function setContainer(ContainerInterface $container = null) $this->container = $container; } - public function load(ObjectManager $manager) + public function load(ObjectManager $manager): void { } } From 94426aae8a43b11b8964f07c2a0ac90b4def091c Mon Sep 17 00:00:00 2001 From: Alexandre Daubois Date: Tue, 12 Mar 2024 13:44:59 +0100 Subject: [PATCH 29/81] [VarDumper] Fix test suite with PHP 8.4 --- .../VarDumper/Caster/ReflectionCaster.php | 10 +++++-- .../Tests/Caster/ReflectionCasterTest.php | 27 +++++++++++-------- 2 files changed, 24 insertions(+), 13 deletions(-) diff --git a/src/Symfony/Component/VarDumper/Caster/ReflectionCaster.php b/src/Symfony/Component/VarDumper/Caster/ReflectionCaster.php index ef6a85ef0fb1c..b373a6fa5fad6 100644 --- a/src/Symfony/Component/VarDumper/Caster/ReflectionCaster.php +++ b/src/Symfony/Component/VarDumper/Caster/ReflectionCaster.php @@ -116,10 +116,16 @@ public static function castType(\ReflectionType $c, array $a, Stub $stub, bool $ public static function castAttribute(\ReflectionAttribute $c, array $a, Stub $stub, bool $isNested) { - self::addMap($a, $c, [ + $map = [ 'name' => 'getName', 'arguments' => 'getArguments', - ]); + ]; + + if (\PHP_VERSION_ID >= 80400) { + unset($map['name']); + } + + self::addMap($a, $c, $map); return $a; } diff --git a/src/Symfony/Component/VarDumper/Tests/Caster/ReflectionCasterTest.php b/src/Symfony/Component/VarDumper/Tests/Caster/ReflectionCasterTest.php index 07226b0ed37a9..e57999182ea89 100644 --- a/src/Symfony/Component/VarDumper/Tests/Caster/ReflectionCasterTest.php +++ b/src/Symfony/Component/VarDumper/Tests/Caster/ReflectionCasterTest.php @@ -599,13 +599,14 @@ class: "Symfony\Component\VarDumper\Tests\Caster\ReflectionCasterTest" public function testReflectionClassWithAttribute() { $var = new \ReflectionClass(LotsOfAttributes::class); + $dumpedAttributeNameProperty = (\PHP_VERSION_ID < 80400 ? '' : '+').'name'; - $this->assertDumpMatchesFormat(<<< 'EOTXT' + $this->assertDumpMatchesFormat(<< ReflectionAttribute { - name: "Symfony\Component\VarDumper\Tests\Fixtures\MyAttribute" + $dumpedAttributeNameProperty: "Symfony\Component\VarDumper\Tests\Fixtures\MyAttribute" arguments: [] } ] @@ -621,14 +622,15 @@ public function testReflectionClassWithAttribute() public function testReflectionMethodWithAttribute() { $var = new \ReflectionMethod(LotsOfAttributes::class, 'someMethod'); + $dumpedAttributeNameProperty = (\PHP_VERSION_ID < 80400 ? '' : '+').'name'; - $this->assertDumpMatchesFormat(<<< 'EOTXT' + $this->assertDumpMatchesFormat(<< ReflectionAttribute { - name: "Symfony\Component\VarDumper\Tests\Fixtures\MyAttribute" + $dumpedAttributeNameProperty: "Symfony\Component\VarDumper\Tests\Fixtures\MyAttribute" arguments: array:1 [ 0 => "two" ] @@ -646,14 +648,15 @@ public function testReflectionMethodWithAttribute() public function testReflectionPropertyWithAttribute() { $var = new \ReflectionProperty(LotsOfAttributes::class, 'someProperty'); + $dumpedAttributeNameProperty = (\PHP_VERSION_ID < 80400 ? '' : '+').'name'; - $this->assertDumpMatchesFormat(<<< 'EOTXT' + $this->assertDumpMatchesFormat(<< ReflectionAttribute { - name: "Symfony\Component\VarDumper\Tests\Fixtures\MyAttribute" + $dumpedAttributeNameProperty: "Symfony\Component\VarDumper\Tests\Fixtures\MyAttribute" arguments: array:2 [ 0 => "one" "extra" => "hello" @@ -671,8 +674,9 @@ public function testReflectionPropertyWithAttribute() public function testReflectionClassConstantWithAttribute() { $var = new \ReflectionClassConstant(LotsOfAttributes::class, 'SOME_CONSTANT'); + $dumpedAttributeNameProperty = (\PHP_VERSION_ID < 80400 ? '' : '+').'name'; - $this->assertDumpMatchesFormat(<<< 'EOTXT' + $this->assertDumpMatchesFormat(<< ReflectionAttribute { - name: "Symfony\Component\VarDumper\Tests\Fixtures\RepeatableAttribute" + $dumpedAttributeNameProperty: "Symfony\Component\VarDumper\Tests\Fixtures\RepeatableAttribute" arguments: array:1 [ 0 => "one" ] } 1 => ReflectionAttribute { - name: "Symfony\Component\VarDumper\Tests\Fixtures\RepeatableAttribute" + $dumpedAttributeNameProperty: "Symfony\Component\VarDumper\Tests\Fixtures\RepeatableAttribute" arguments: array:1 [ 0 => "two" ] @@ -703,14 +707,15 @@ public function testReflectionClassConstantWithAttribute() public function testReflectionParameterWithAttribute() { $var = new \ReflectionParameter([LotsOfAttributes::class, 'someMethod'], 'someParameter'); + $dumpedAttributeNameProperty = (\PHP_VERSION_ID < 80400 ? '' : '+').'name'; - $this->assertDumpMatchesFormat(<<< 'EOTXT' + $this->assertDumpMatchesFormat(<< ReflectionAttribute { - name: "Symfony\Component\VarDumper\Tests\Fixtures\MyAttribute" + $dumpedAttributeNameProperty: "Symfony\Component\VarDumper\Tests\Fixtures\MyAttribute" arguments: array:1 [ 0 => "three" ] From f32d633a2e9dffcab9dccd2d20553035fa984338 Mon Sep 17 00:00:00 2001 From: Alexandre Daubois Date: Tue, 12 Mar 2024 15:18:29 +0100 Subject: [PATCH 30/81] [HttpKernel] Fix creating `ReflectionMethod` with only one argument --- src/Symfony/Component/HttpKernel/Event/ControllerEvent.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Symfony/Component/HttpKernel/Event/ControllerEvent.php b/src/Symfony/Component/HttpKernel/Event/ControllerEvent.php index 9e5a3a56e1c30..626163d148b8a 100644 --- a/src/Symfony/Component/HttpKernel/Event/ControllerEvent.php +++ b/src/Symfony/Component/HttpKernel/Event/ControllerEvent.php @@ -70,7 +70,7 @@ public function setController(callable $controller, ?array $attributes = null): if (\is_array($controller) && method_exists(...$controller)) { $this->controllerReflector = new \ReflectionMethod(...$controller); } elseif (\is_string($controller) && str_contains($controller, '::')) { - $this->controllerReflector = new \ReflectionMethod($controller); + $this->controllerReflector = new \ReflectionMethod(...explode('::', $controller, 2)); } else { $this->controllerReflector = new \ReflectionFunction($controller(...)); } From 05b48f6fc7c1f8f20fb52a06ae46508b48ebbfd1 Mon Sep 17 00:00:00 2001 From: Nicolas Grekas Date: Tue, 12 Mar 2024 15:33:14 +0100 Subject: [PATCH 31/81] [CI] Remove experimental flag on PHP 8.4 job --- .github/workflows/unit-tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/unit-tests.yml b/.github/workflows/unit-tests.yml index 09472e0b06d3c..159abdf72ac02 100644 --- a/.github/workflows/unit-tests.yml +++ b/.github/workflows/unit-tests.yml @@ -34,7 +34,7 @@ jobs: mode: low-deps - php: '8.3' - php: '8.4' - mode: experimental + #mode: experimental fail-fast: false runs-on: ubuntu-20.04 From 59d7c7239a8f9c8dce2d618aea035a07d95031c0 Mon Sep 17 00:00:00 2001 From: Nicolas Grekas Date: Tue, 12 Mar 2024 15:53:19 +0100 Subject: [PATCH 32/81] [ErrorHandler] Fix tests --- src/Symfony/Component/ErrorHandler/ErrorHandler.php | 7 ++++++- .../Component/ErrorHandler/Tests/ErrorHandlerTest.php | 7 +++++++ 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/src/Symfony/Component/ErrorHandler/ErrorHandler.php b/src/Symfony/Component/ErrorHandler/ErrorHandler.php index a2a98fb745906..b5109f457bc71 100644 --- a/src/Symfony/Component/ErrorHandler/ErrorHandler.php +++ b/src/Symfony/Component/ErrorHandler/ErrorHandler.php @@ -517,7 +517,12 @@ public function handleError(int $type, string $message, string $file, int $line) } // Display the original error message instead of the default one. - $this->handleException($errorAsException); + $exitCode = self::$exitCode; + try { + $this->handleException($errorAsException); + } finally { + self::$exitCode = $exitCode; + } // Stop the process by giving back the error to the native handler. return false; diff --git a/src/Symfony/Component/ErrorHandler/Tests/ErrorHandlerTest.php b/src/Symfony/Component/ErrorHandler/Tests/ErrorHandlerTest.php index 5462a9f230b5b..2728234af3121 100644 --- a/src/Symfony/Component/ErrorHandler/Tests/ErrorHandlerTest.php +++ b/src/Symfony/Component/ErrorHandler/Tests/ErrorHandlerTest.php @@ -31,6 +31,13 @@ */ class ErrorHandlerTest extends TestCase { + public function tearDown(): void + { + $r = new \ReflectionProperty(ErrorHandler::class, 'exitCode'); + $r->setAccessible(true); + $r->setValue(null, 0); + } + public function testRegister() { $handler = ErrorHandler::register(); From e3972003848635dfe75ef9439404bccda8060243 Mon Sep 17 00:00:00 2001 From: Nicolas PHILIPPE Date: Fri, 1 Mar 2024 08:40:26 +0100 Subject: [PATCH 33/81] [Messenger] trigger retry logic when message is a redelivery --- src/Symfony/Component/Messenger/CHANGELOG.md | 1 - .../Messenger/Exception/RejectRedeliveredMessageException.php | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/src/Symfony/Component/Messenger/CHANGELOG.md b/src/Symfony/Component/Messenger/CHANGELOG.md index 7e68e9f5c2767..43affdabf7223 100644 --- a/src/Symfony/Component/Messenger/CHANGELOG.md +++ b/src/Symfony/Component/Messenger/CHANGELOG.md @@ -8,7 +8,6 @@ CHANGELOG * Add `HandlerDescriptor::getOptions` * Add support for multiple Redis Sentinel hosts * Add `--all` option to the `messenger:failed:remove` command - * `RejectRedeliveredMessageException` implements `UnrecoverableExceptionInterface` in order to not be retried * Add `WrappedExceptionsInterface` interface for exceptions that hold multiple individual exceptions * Deprecate `HandlerFailedException::getNestedExceptions()`, `HandlerFailedException::getNestedExceptionsOfClass()` and `DelayedMessageHandlingException::getExceptions()` which are replaced by a new `getWrappedExceptions()` method diff --git a/src/Symfony/Component/Messenger/Exception/RejectRedeliveredMessageException.php b/src/Symfony/Component/Messenger/Exception/RejectRedeliveredMessageException.php index 72283878c1b0c..0befccf4a1d1f 100644 --- a/src/Symfony/Component/Messenger/Exception/RejectRedeliveredMessageException.php +++ b/src/Symfony/Component/Messenger/Exception/RejectRedeliveredMessageException.php @@ -14,6 +14,6 @@ /** * @author Tobias Schultze */ -class RejectRedeliveredMessageException extends RuntimeException implements UnrecoverableExceptionInterface +class RejectRedeliveredMessageException extends RuntimeException { } From b186bb8be47942613500eeb1378c7857f739d8da Mon Sep 17 00:00:00 2001 From: guangwu Date: Wed, 13 Mar 2024 09:50:36 +0800 Subject: [PATCH 34/81] fix: typo --- .../Component/Serializer/Tests/Annotation/ContextTest.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Symfony/Component/Serializer/Tests/Annotation/ContextTest.php b/src/Symfony/Component/Serializer/Tests/Annotation/ContextTest.php index 77c1edca02afb..afa445893d791 100644 --- a/src/Symfony/Component/Serializer/Tests/Annotation/ContextTest.php +++ b/src/Symfony/Component/Serializer/Tests/Annotation/ContextTest.php @@ -199,7 +199,7 @@ function () { return new Context(...['context' => ['foo' => 'bar'], 'groups' => DUMP ]; - yield 'named arguemnts: with groups option as array' => [ + yield 'named arguments: with groups option as array' => [ function () { return new Context(...['context' => ['foo' => 'bar'], 'groups' => ['a', 'b']]); }, << Date: Wed, 13 Mar 2024 09:40:21 +0100 Subject: [PATCH 35/81] [VarDumper] prevent error in value to Typed property must not be accessed before initialization --- src/Symfony/Component/VarDumper/Cloner/Stub.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Symfony/Component/VarDumper/Cloner/Stub.php b/src/Symfony/Component/VarDumper/Cloner/Stub.php index 4070b981d2374..4455a362b88cb 100644 --- a/src/Symfony/Component/VarDumper/Cloner/Stub.php +++ b/src/Symfony/Component/VarDumper/Cloner/Stub.php @@ -35,7 +35,7 @@ class Stub public int $type = self::TYPE_REF; public string|int|null $class = ''; - public mixed $value; + public mixed $value = null; public int $cut = 0; public int $handle = 0; public int $refCount = 0; From ee5bd73211ec20f7f8254bfb357896e2766f36c0 Mon Sep 17 00:00:00 2001 From: Bastien Jaillot Date: Tue, 12 Mar 2024 14:21:55 +0100 Subject: [PATCH 36/81] [Lock] compatiblity with redis cluster 7 --- src/Symfony/Component/Lock/Store/RedisStore.php | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/src/Symfony/Component/Lock/Store/RedisStore.php b/src/Symfony/Component/Lock/Store/RedisStore.php index 0060f12a6bfdc..2baf322af065a 100644 --- a/src/Symfony/Component/Lock/Store/RedisStore.php +++ b/src/Symfony/Component/Lock/Store/RedisStore.php @@ -258,10 +258,10 @@ public function exists(Key $key) private function evaluate(string $script, string $resource, array $args) { if ( - $this->redis instanceof \Redis || - $this->redis instanceof \RedisCluster || - $this->redis instanceof RedisProxy || - $this->redis instanceof RedisClusterProxy + $this->redis instanceof \Redis + || $this->redis instanceof \RedisCluster + || $this->redis instanceof RedisProxy + || $this->redis instanceof RedisClusterProxy ) { $this->redis->clearLastError(); $result = $this->redis->eval($script, array_merge([$resource], $args), 1); @@ -317,7 +317,9 @@ private function getNowCode(): string try { $this->supportTime = 1 === $this->evaluate($script, 'symfony_check_support_time', []); } catch (LockStorageException $e) { - if (false === strpos($e->getMessage(), 'commands not allowed after non deterministic')) { + if (!str_contains($e->getMessage(), 'commands not allowed after non deterministic') + && !str_contains($e->getMessage(), 'is not allowed from script script') + ) { throw $e; } $this->supportTime = false; From 3a91c5e2626f69e5b38c1b433e57caa0afd49791 Mon Sep 17 00:00:00 2001 From: Alexandre Daubois Date: Wed, 13 Mar 2024 14:21:57 +0100 Subject: [PATCH 37/81] [ErrorHandler] Fix `ErrorHandlerTest::tearDown()` visibility --- src/Symfony/Component/ErrorHandler/Tests/ErrorHandlerTest.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Symfony/Component/ErrorHandler/Tests/ErrorHandlerTest.php b/src/Symfony/Component/ErrorHandler/Tests/ErrorHandlerTest.php index 2728234af3121..75a91d9e221cc 100644 --- a/src/Symfony/Component/ErrorHandler/Tests/ErrorHandlerTest.php +++ b/src/Symfony/Component/ErrorHandler/Tests/ErrorHandlerTest.php @@ -31,7 +31,7 @@ */ class ErrorHandlerTest extends TestCase { - public function tearDown(): void + protected function tearDown(): void { $r = new \ReflectionProperty(ErrorHandler::class, 'exitCode'); $r->setAccessible(true); From 7318816fb28e08ca6f67b0f758774b6521f326b0 Mon Sep 17 00:00:00 2001 From: Ernesto Domato Date: Tue, 27 Feb 2024 14:30:29 -0300 Subject: [PATCH 38/81] [Lock] Check the correct SQLSTATE error code for MySQL * Closes bug: #54091 Signed-off-by: Ernesto Domato --- src/Symfony/Component/Cache/Adapter/PdoAdapter.php | 2 +- src/Symfony/Component/Lock/Store/PdoStore.php | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Symfony/Component/Cache/Adapter/PdoAdapter.php b/src/Symfony/Component/Cache/Adapter/PdoAdapter.php index 52c139c3dfc29..1674850350921 100644 --- a/src/Symfony/Component/Cache/Adapter/PdoAdapter.php +++ b/src/Symfony/Component/Cache/Adapter/PdoAdapter.php @@ -600,7 +600,7 @@ private function getServerVersion(): string private function isTableMissing(\PDOException $exception): bool { $driver = $this->driver; - $code = $exception->getCode(); + $code = $exception->errorInfo ? $exception->errorInfo[1] : $exception->getCode(); switch (true) { case 'pgsql' === $driver && '42P01' === $code: diff --git a/src/Symfony/Component/Lock/Store/PdoStore.php b/src/Symfony/Component/Lock/Store/PdoStore.php index 159b9287d6852..ba4965b0057f9 100644 --- a/src/Symfony/Component/Lock/Store/PdoStore.php +++ b/src/Symfony/Component/Lock/Store/PdoStore.php @@ -330,7 +330,7 @@ private function getCurrentTimestampStatement(): string private function isTableMissing(\PDOException $exception): bool { $driver = $this->getDriver(); - $code = $exception->getCode(); + $code = $exception->errorInfo ? $exception->errorInfo[1] : $exception->getCode(); switch (true) { case 'pgsql' === $driver && '42P01' === $code: From 4a4b0116b4f160d71f57639297b75ab29df5a5c3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gr=C3=A9goire=20Pineau?= Date: Wed, 13 Mar 2024 17:09:04 +0100 Subject: [PATCH 39/81] [DependencyInjection] fix XmlDumper when a tag contains also a 'name' property --- .../DependencyInjection/Dumper/XmlDumper.php | 11 ++++++----- .../Fixtures/containers/container_non_scalar_tags.php | 1 + .../Tests/Fixtures/xml/services_with_array_tags.xml | 1 + .../Tests/Fixtures/yaml/services_with_array_tags.yml | 2 +- .../Tests/Loader/XmlFileLoaderTest.php | 2 +- 5 files changed, 10 insertions(+), 7 deletions(-) diff --git a/src/Symfony/Component/DependencyInjection/Dumper/XmlDumper.php b/src/Symfony/Component/DependencyInjection/Dumper/XmlDumper.php index 05d424d15d653..6ae8d5c611906 100644 --- a/src/Symfony/Component/DependencyInjection/Dumper/XmlDumper.php +++ b/src/Symfony/Component/DependencyInjection/Dumper/XmlDumper.php @@ -134,16 +134,17 @@ private function addService(Definition $definition, ?string $id, \DOMElement $pa foreach ($tags as $name => $tags) { foreach ($tags as $attributes) { $tag = $this->document->createElement('tag'); - if (!\array_key_exists('name', $attributes)) { - $tag->setAttribute('name', $name); - } else { - $tag->appendChild($this->document->createTextNode($name)); - } // Check if we have recursive attributes if (array_filter($attributes, \is_array(...))) { + $tag->setAttribute('name', $name); $this->addTagRecursiveAttributes($tag, $attributes); } else { + if (!\array_key_exists('name', $attributes)) { + $tag->setAttribute('name', $name); + } else { + $tag->appendChild($this->document->createTextNode($name)); + } foreach ($attributes as $key => $value) { $tag->setAttribute($key, $value ?? ''); } diff --git a/src/Symfony/Component/DependencyInjection/Tests/Fixtures/containers/container_non_scalar_tags.php b/src/Symfony/Component/DependencyInjection/Tests/Fixtures/containers/container_non_scalar_tags.php index 76c69868cc49a..2a1234fa7e26a 100644 --- a/src/Symfony/Component/DependencyInjection/Tests/Fixtures/containers/container_non_scalar_tags.php +++ b/src/Symfony/Component/DependencyInjection/Tests/Fixtures/containers/container_non_scalar_tags.php @@ -10,6 +10,7 @@ $container ->register('foo', FooClass::class) ->addTag('foo_tag', [ + 'name' => 'attributeName', 'foo' => 'bar', 'bar' => [ 'foo' => 'bar', diff --git a/src/Symfony/Component/DependencyInjection/Tests/Fixtures/xml/services_with_array_tags.xml b/src/Symfony/Component/DependencyInjection/Tests/Fixtures/xml/services_with_array_tags.xml index 8e910be31431c..ba8d790571e8b 100644 --- a/src/Symfony/Component/DependencyInjection/Tests/Fixtures/xml/services_with_array_tags.xml +++ b/src/Symfony/Component/DependencyInjection/Tests/Fixtures/xml/services_with_array_tags.xml @@ -4,6 +4,7 @@ + attributeName bar bar diff --git a/src/Symfony/Component/DependencyInjection/Tests/Fixtures/yaml/services_with_array_tags.yml b/src/Symfony/Component/DependencyInjection/Tests/Fixtures/yaml/services_with_array_tags.yml index 3f580df3e30ef..e4f355c045699 100644 --- a/src/Symfony/Component/DependencyInjection/Tests/Fixtures/yaml/services_with_array_tags.yml +++ b/src/Symfony/Component/DependencyInjection/Tests/Fixtures/yaml/services_with_array_tags.yml @@ -7,4 +7,4 @@ services: foo: class: Bar\FooClass tags: - - foo_tag: { foo: bar, bar: { foo: bar, bar: foo } } + - foo_tag: { name: attributeName, foo: bar, bar: { foo: bar, bar: foo } } diff --git a/src/Symfony/Component/DependencyInjection/Tests/Loader/XmlFileLoaderTest.php b/src/Symfony/Component/DependencyInjection/Tests/Loader/XmlFileLoaderTest.php index c61fb0be569bc..d53fe9398d468 100644 --- a/src/Symfony/Component/DependencyInjection/Tests/Loader/XmlFileLoaderTest.php +++ b/src/Symfony/Component/DependencyInjection/Tests/Loader/XmlFileLoaderTest.php @@ -468,7 +468,7 @@ public function testParseServiceTagsWithArrayAttributes() $loader = new XmlFileLoader($container, new FileLocator(self::$fixturesPath.'/xml')); $loader->load('services_with_array_tags.xml'); - $this->assertEquals(['foo_tag' => [['foo' => 'bar', 'bar' => ['foo' => 'bar', 'bar' => 'foo']]]], $container->getDefinition('foo')->getTags()); + $this->assertEquals(['foo_tag' => [['name' => 'attributeName', 'foo' => 'bar', 'bar' => ['foo' => 'bar', 'bar' => 'foo']]]], $container->getDefinition('foo')->getTags()); } public function testParseTagsWithoutNameThrowsException() From 96e1d421116b38851f651e12b81c3aa341a6f9f2 Mon Sep 17 00:00:00 2001 From: Ariful Alam Date: Thu, 29 Feb 2024 21:01:06 +0600 Subject: [PATCH 40/81] Update `changed-translation-files` step with native git diff command --- .github/workflows/integration-tests.yml | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/.github/workflows/integration-tests.yml b/.github/workflows/integration-tests.yml index a0216526e0e80..5511e08ad6407 100644 --- a/.github/workflows/integration-tests.yml +++ b/.github/workflows/integration-tests.yml @@ -198,10 +198,14 @@ jobs: # sudo rm -rf .phpunit # [ -d .phpunit.bak ] && mv .phpunit.bak .phpunit - - uses: marceloprado/has-changed-path@v1.0.1 + - name: Check for changes in translation files id: changed-translation-files - with: - paths: src/**/Resources/translations/*.xlf + run: | + if git diff --quiet HEAD~1 HEAD -- 'src/**/Resources/translations/*.xlf'; then + echo "{changed}={true}" >> $GITHUB_OUTPUT + else + echo "{changed}={false}" >> $GITHUB_OUTPUT + fi - name: Check Translation Status if: steps.changed-translation-files.outputs.changed == 'true' From 8575199f307112e56dfaa638ba083f10e50bdebe Mon Sep 17 00:00:00 2001 From: Neil Peyssard Date: Mon, 4 Mar 2024 13:33:38 +0100 Subject: [PATCH 41/81] [Serializer] Fix object normalizer when properties has the same name as their accessor --- .../Mapping/Loader/AnnotationLoader.php | 2 +- .../Normalizer/ObjectNormalizer.php | 16 +++-- .../Fixtures/SamePropertyAsMethodDummy.php | 48 ++++++++++++++ ...yAsMethodWithMethodSerializedNameDummy.php | 62 ++++++++++++++++++ ...sMethodWithPropertySerializedNameDummy.php | 65 +++++++++++++++++++ .../Tests/Normalizer/ObjectNormalizerTest.php | 50 ++++++++++++++ 6 files changed, 238 insertions(+), 5 deletions(-) create mode 100644 src/Symfony/Component/Serializer/Tests/Fixtures/SamePropertyAsMethodDummy.php create mode 100644 src/Symfony/Component/Serializer/Tests/Fixtures/SamePropertyAsMethodWithMethodSerializedNameDummy.php create mode 100644 src/Symfony/Component/Serializer/Tests/Fixtures/SamePropertyAsMethodWithPropertySerializedNameDummy.php diff --git a/src/Symfony/Component/Serializer/Mapping/Loader/AnnotationLoader.php b/src/Symfony/Component/Serializer/Mapping/Loader/AnnotationLoader.php index 4d0e1768d21a4..9082a3cc260ca 100644 --- a/src/Symfony/Component/Serializer/Mapping/Loader/AnnotationLoader.php +++ b/src/Symfony/Component/Serializer/Mapping/Loader/AnnotationLoader.php @@ -106,7 +106,7 @@ public function loadClassMetadata(ClassMetadataInterface $classMetadata) $accessorOrMutator = preg_match('/^(get|is|has|set)(.+)$/i', $method->name, $matches); if ($accessorOrMutator) { - $attributeName = lcfirst($matches[2]); + $attributeName = $reflectionClass->hasProperty($method->name) ? $method->name : lcfirst($matches[2]); if (isset($attributesMetadata[$attributeName])) { $attributeMetadata = $attributesMetadata[$attributeName]; diff --git a/src/Symfony/Component/Serializer/Normalizer/ObjectNormalizer.php b/src/Symfony/Component/Serializer/Normalizer/ObjectNormalizer.php index cbbade546a1c9..0dafaa7b7bd5f 100644 --- a/src/Symfony/Component/Serializer/Normalizer/ObjectNormalizer.php +++ b/src/Symfony/Component/Serializer/Normalizer/ObjectNormalizer.php @@ -86,17 +86,25 @@ protected function extractAttributes(object $object, ?string $format = null, arr if (str_starts_with($name, 'get') || str_starts_with($name, 'has')) { // getters and hassers - $attributeName = substr($name, 3); + $attributeName = $name; if (!$reflClass->hasProperty($attributeName)) { - $attributeName = lcfirst($attributeName); + $attributeName = substr($attributeName, 3); + + if (!$reflClass->hasProperty($attributeName)) { + $attributeName = lcfirst($attributeName); + } } } elseif (str_starts_with($name, 'is')) { // issers - $attributeName = substr($name, 2); + $attributeName = $name; if (!$reflClass->hasProperty($attributeName)) { - $attributeName = lcfirst($attributeName); + $attributeName = substr($attributeName, 2); + + if (!$reflClass->hasProperty($attributeName)) { + $attributeName = lcfirst($attributeName); + } } } diff --git a/src/Symfony/Component/Serializer/Tests/Fixtures/SamePropertyAsMethodDummy.php b/src/Symfony/Component/Serializer/Tests/Fixtures/SamePropertyAsMethodDummy.php new file mode 100644 index 0000000000000..89c8fcb9c399c --- /dev/null +++ b/src/Symfony/Component/Serializer/Tests/Fixtures/SamePropertyAsMethodDummy.php @@ -0,0 +1,48 @@ + + * + * For the full copyright and license information, please view the LICENSE + * file that was distributed with this source code. + */ + +namespace Symfony\Component\Serializer\Tests\Fixtures; + +class SamePropertyAsMethodDummy +{ + private $freeTrial; + private $hasSubscribe; + private $getReady; + private $isActive; + + public function __construct($freeTrial, $hasSubscribe, $getReady, $isActive) + { + $this->freeTrial = $freeTrial; + $this->hasSubscribe = $hasSubscribe; + $this->getReady = $getReady; + $this->isActive = $isActive; + } + + public function getFreeTrial() + { + return $this->freeTrial; + } + + public function hasSubscribe() + { + return $this->hasSubscribe; + } + + public function getReady() + { + return $this->getReady; + } + + public function isActive() + { + return $this->isActive; + } +} diff --git a/src/Symfony/Component/Serializer/Tests/Fixtures/SamePropertyAsMethodWithMethodSerializedNameDummy.php b/src/Symfony/Component/Serializer/Tests/Fixtures/SamePropertyAsMethodWithMethodSerializedNameDummy.php new file mode 100644 index 0000000000000..b4cf205fd57c8 --- /dev/null +++ b/src/Symfony/Component/Serializer/Tests/Fixtures/SamePropertyAsMethodWithMethodSerializedNameDummy.php @@ -0,0 +1,62 @@ + + * + * For the full copyright and license information, please view the LICENSE + * file that was distributed with this source code. + */ + +namespace Symfony\Component\Serializer\Tests\Fixtures; + +use Symfony\Component\Serializer\Annotation\SerializedName; + +class SamePropertyAsMethodWithMethodSerializedNameDummy +{ + private $freeTrial; + private $hasSubscribe; + private $getReady; + private $isActive; + + public function __construct($freeTrial, $hasSubscribe, $getReady, $isActive) + { + $this->freeTrial = $freeTrial; + $this->hasSubscribe = $hasSubscribe; + $this->getReady = $getReady; + $this->isActive = $isActive; + } + + /** + * @SerializedName("free_trial_method") + */ + public function getFreeTrial() + { + return $this->freeTrial; + } + + /** + * @SerializedName("has_subscribe_method") + */ + public function hasSubscribe() + { + return $this->hasSubscribe; + } + + /** + * @SerializedName("get_ready_method") + */ + public function getReady() + { + return $this->getReady; + } + + /** + * @SerializedName("is_active_method") + */ + public function isActive() + { + return $this->isActive; + } +} diff --git a/src/Symfony/Component/Serializer/Tests/Fixtures/SamePropertyAsMethodWithPropertySerializedNameDummy.php b/src/Symfony/Component/Serializer/Tests/Fixtures/SamePropertyAsMethodWithPropertySerializedNameDummy.php new file mode 100644 index 0000000000000..04dc64a3c71c0 --- /dev/null +++ b/src/Symfony/Component/Serializer/Tests/Fixtures/SamePropertyAsMethodWithPropertySerializedNameDummy.php @@ -0,0 +1,65 @@ + + * + * For the full copyright and license information, please view the LICENSE + * file that was distributed with this source code. + */ + +namespace Symfony\Component\Serializer\Tests\Fixtures; + +use Symfony\Component\Serializer\Annotation\SerializedName; + +class SamePropertyAsMethodWithPropertySerializedNameDummy +{ + /** + * @SerializedName("free_trial_property") + */ + private $freeTrial; + + /** + * @SerializedName("has_subscribe_property") + */ + private $hasSubscribe; + + /** + * @SerializedName("get_ready_property") + */ + private $getReady; + + /** + * @SerializedName("is_active_property") + */ + private $isActive; + + public function __construct($freeTrial, $hasSubscribe, $getReady, $isActive) + { + $this->freeTrial = $freeTrial; + $this->hasSubscribe = $hasSubscribe; + $this->getReady = $getReady; + $this->isActive = $isActive; + } + + public function getFreeTrial() + { + return $this->freeTrial; + } + + public function hasSubscribe() + { + return $this->hasSubscribe; + } + + public function getReady() + { + return $this->getReady; + } + + public function isActive() + { + return $this->isActive; + } +} diff --git a/src/Symfony/Component/Serializer/Tests/Normalizer/ObjectNormalizerTest.php b/src/Symfony/Component/Serializer/Tests/Normalizer/ObjectNormalizerTest.php index 36957ac5c0a3f..01c3b785efbf5 100644 --- a/src/Symfony/Component/Serializer/Tests/Normalizer/ObjectNormalizerTest.php +++ b/src/Symfony/Component/Serializer/Tests/Normalizer/ObjectNormalizerTest.php @@ -40,6 +40,9 @@ use Symfony\Component\Serializer\Tests\Fixtures\Php74Dummy; use Symfony\Component\Serializer\Tests\Fixtures\Php74DummyPrivate; use Symfony\Component\Serializer\Tests\Fixtures\Php80Dummy; +use Symfony\Component\Serializer\Tests\Fixtures\SamePropertyAsMethodDummy; +use Symfony\Component\Serializer\Tests\Fixtures\SamePropertyAsMethodWithMethodSerializedNameDummy; +use Symfony\Component\Serializer\Tests\Fixtures\SamePropertyAsMethodWithPropertySerializedNameDummy; use Symfony\Component\Serializer\Tests\Fixtures\SiblingHolder; use Symfony\Component\Serializer\Tests\Normalizer\Features\AttributesTestTrait; use Symfony\Component\Serializer\Tests\Normalizer\Features\CacheableObjectAttributesTestTrait; @@ -869,6 +872,53 @@ public function testNormalizeStdClass() $this->assertSame(['baz' => 'baz'], $this->normalizer->normalize($o2)); } + + public function testSamePropertyAsMethod() + { + $object = new SamePropertyAsMethodDummy('free_trial', 'has_subscribe', 'get_ready', 'is_active'); + $expected = [ + 'freeTrial' => 'free_trial', + 'hasSubscribe' => 'has_subscribe', + 'getReady' => 'get_ready', + 'isActive' => 'is_active', + ]; + + $this->assertSame($expected, $this->normalizer->normalize($object)); + } + + public function testSamePropertyAsMethodWithPropertySerializedName() + { + $classMetadataFactory = new ClassMetadataFactory(new AnnotationLoader(new AnnotationReader())); + $this->normalizer = new ObjectNormalizer($classMetadataFactory, new MetadataAwareNameConverter($classMetadataFactory)); + $this->normalizer->setSerializer($this->serializer); + + $object = new SamePropertyAsMethodWithPropertySerializedNameDummy('free_trial', 'has_subscribe', 'get_ready', 'is_active'); + $expected = [ + 'free_trial_property' => 'free_trial', + 'has_subscribe_property' => 'has_subscribe', + 'get_ready_property' => 'get_ready', + 'is_active_property' => 'is_active', + ]; + + $this->assertSame($expected, $this->normalizer->normalize($object)); + } + + public function testSamePropertyAsMethodWithMethodSerializedName() + { + $classMetadataFactory = new ClassMetadataFactory(new AnnotationLoader(new AnnotationReader())); + $this->normalizer = new ObjectNormalizer($classMetadataFactory, new MetadataAwareNameConverter($classMetadataFactory)); + $this->normalizer->setSerializer($this->serializer); + + $object = new SamePropertyAsMethodWithMethodSerializedNameDummy('free_trial', 'has_subscribe', 'get_ready', 'is_active'); + $expected = [ + 'free_trial_method' => 'free_trial', + 'has_subscribe_method' => 'has_subscribe', + 'get_ready_method' => 'get_ready', + 'is_active_method' => 'is_active', + ]; + + $this->assertSame($expected, $this->normalizer->normalize($object)); + } } class ProxyObjectDummy extends ObjectDummy From 53533897f025cc299859b64c6bd887a076aece3e Mon Sep 17 00:00:00 2001 From: Fabien Potencier Date: Wed, 13 Mar 2024 18:38:56 +0100 Subject: [PATCH 42/81] [FrameworkBundle] Fix typo --- .../Bundle/FrameworkBundle/Command/CacheClearCommand.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Symfony/Bundle/FrameworkBundle/Command/CacheClearCommand.php b/src/Symfony/Bundle/FrameworkBundle/Command/CacheClearCommand.php index 20df3f69ed78a..b245dd7a68c1f 100644 --- a/src/Symfony/Bundle/FrameworkBundle/Command/CacheClearCommand.php +++ b/src/Symfony/Bundle/FrameworkBundle/Command/CacheClearCommand.php @@ -156,7 +156,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int } if ($this->isNfs($realBuildDir)) { - $io->note('For better performances, you should move the cache and log directories to a non-shared folder of the VM.'); + $io->note('For better performance, you should move the cache and log directories to a non-shared folder of the VM.'); $fs->remove($realBuildDir); } else { $fs->rename($realBuildDir, $oldBuildDir); From 05ad85d22998919db4812e1fe1848cbb7d6861ed Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gr=C3=A9goire=20Pineau?= Date: Wed, 13 Mar 2024 18:56:40 +0100 Subject: [PATCH 43/81] [ErrorHandler] Skip failing tests when "xdebug.file_link_format" option is defined --- .../Tests/ErrorRenderer/FileLinkFormatterTest.php | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/Symfony/Component/ErrorHandler/Tests/ErrorRenderer/FileLinkFormatterTest.php b/src/Symfony/Component/ErrorHandler/Tests/ErrorRenderer/FileLinkFormatterTest.php index a5f6330679ff9..807ee729fc5d8 100644 --- a/src/Symfony/Component/ErrorHandler/Tests/ErrorRenderer/FileLinkFormatterTest.php +++ b/src/Symfony/Component/ErrorHandler/Tests/ErrorRenderer/FileLinkFormatterTest.php @@ -27,6 +27,11 @@ public function testWhenNoFileLinkFormatAndNoRequest() public function testAfterUnserialize() { + if (get_cfg_var('xdebug.file_link_format')) { + // There is not way to override "xdebug.file_link_format" option in a test. + $this->markTestSkipped('php.ini has a custom option for "xdebug.file_link_format".'); + } + $ide = $_ENV['SYMFONY_IDE'] ?? $_SERVER['SYMFONY_IDE'] ?? null; $_ENV['SYMFONY_IDE'] = $_SERVER['SYMFONY_IDE'] = null; $sut = unserialize(serialize(new FileLinkFormatter())); From b184401ebe369cbae174965d94244c9156228746 Mon Sep 17 00:00:00 2001 From: Andreas Schempp Date: Tue, 12 Mar 2024 11:20:58 +0100 Subject: [PATCH 44/81] [Security] Correctly initialize the voter property --- .../DataCollector/SecurityDataCollector.php | 1 + .../SecurityDataCollectorTest.php | 30 +++++++++++++++++++ 2 files changed, 31 insertions(+) diff --git a/src/Symfony/Bundle/SecurityBundle/DataCollector/SecurityDataCollector.php b/src/Symfony/Bundle/SecurityBundle/DataCollector/SecurityDataCollector.php index 01eea81a38315..72c76964bcbde 100644 --- a/src/Symfony/Bundle/SecurityBundle/DataCollector/SecurityDataCollector.php +++ b/src/Symfony/Bundle/SecurityBundle/DataCollector/SecurityDataCollector.php @@ -145,6 +145,7 @@ public function collect(Request $request, Response $response, ?\Throwable $excep // collect voters and access decision manager information if ($this->accessDecisionManager instanceof TraceableAccessDecisionManager) { $this->data['voter_strategy'] = $this->accessDecisionManager->getStrategy(); + $this->data['voters'] = []; foreach ($this->accessDecisionManager->getVoters() as $voter) { if ($voter instanceof TraceableVoter) { diff --git a/src/Symfony/Bundle/SecurityBundle/Tests/DataCollector/SecurityDataCollectorTest.php b/src/Symfony/Bundle/SecurityBundle/Tests/DataCollector/SecurityDataCollectorTest.php index ae706830738f3..ea70292f8dca7 100644 --- a/src/Symfony/Bundle/SecurityBundle/Tests/DataCollector/SecurityDataCollectorTest.php +++ b/src/Symfony/Bundle/SecurityBundle/Tests/DataCollector/SecurityDataCollectorTest.php @@ -400,6 +400,36 @@ public function dispatch(object $event, ?string $eventName = null): object $this->assertSame($dataCollector->getVoterStrategy(), $strategy, 'Wrong value returned by getVoterStrategy'); } + public function testGetVotersIfAccessDecisionManagerHasNoVoters() + { + $strategy = MainConfiguration::STRATEGY_AFFIRMATIVE; + + $accessDecisionManager = $this->createMock(TraceableAccessDecisionManager::class); + + $accessDecisionManager + ->method('getStrategy') + ->willReturn($strategy); + + $accessDecisionManager + ->method('getVoters') + ->willReturn([]); + + $accessDecisionManager + ->method('getDecisionLog') + ->willReturn([[ + 'attributes' => ['view'], + 'object' => new \stdClass(), + 'result' => true, + 'voterDetails' => [], + ]]); + + $dataCollector = new SecurityDataCollector(null, null, null, $accessDecisionManager, null, null, true); + + $dataCollector->collect(new Request(), new Response()); + + $this->assertEmpty($dataCollector->getVoters()); + } + public static function provideRoles(): array { return [ From 0cfdf2fe768b510a0d6135c8a11bc4394d614ccd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gr=C3=A9goire=20Pineau?= Date: Thu, 14 Mar 2024 19:12:43 +0100 Subject: [PATCH 45/81] [FrameworkBundle] Fix mailer config with XML --- .../DependencyInjection/Configuration.php | 3 ++- .../Resources/config/schema/symfony-1.0.xsd | 2 +- .../Fixtures/php/mailer_with_dsn.php | 2 +- .../Fixtures/xml/mailer_with_dsn.xml | 3 +-- .../Fixtures/xml/mailer_with_transports.xml | 4 ++-- .../Fixtures/yml/mailer_with_dsn.yml | 1 - .../FrameworkExtensionTestCase.php | 22 ++++++++++++------- .../XmlFrameworkExtensionTest.php | 1 - 8 files changed, 21 insertions(+), 17 deletions(-) diff --git a/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php b/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php index 487759a87a1ba..57be2f199751a 100644 --- a/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php +++ b/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php @@ -1559,7 +1559,7 @@ private function addHttpClientSection(ArrayNodeDefinition $rootNode, callable $e continue; } if (\is_array($scopedConfig['retry_failed'])) { - $scopedConfig['retry_failed'] = $scopedConfig['retry_failed'] + $config['default_options']['retry_failed']; + $scopedConfig['retry_failed'] += $config['default_options']['retry_failed']; } } @@ -1897,6 +1897,7 @@ private function addMailerSection(ArrayNodeDefinition $rootNode, callable $enabl ->end() ->arrayNode('envelope') ->info('Mailer Envelope configuration') + ->fixXmlConfig('recipient') ->children() ->scalarNode('sender')->end() ->arrayNode('recipients') diff --git a/src/Symfony/Bundle/FrameworkBundle/Resources/config/schema/symfony-1.0.xsd b/src/Symfony/Bundle/FrameworkBundle/Resources/config/schema/symfony-1.0.xsd index faee50e2528a8..60e87a1bcf43c 100644 --- a/src/Symfony/Bundle/FrameworkBundle/Resources/config/schema/symfony-1.0.xsd +++ b/src/Symfony/Bundle/FrameworkBundle/Resources/config/schema/symfony-1.0.xsd @@ -703,7 +703,7 @@ - + diff --git a/src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/Fixtures/php/mailer_with_dsn.php b/src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/Fixtures/php/mailer_with_dsn.php index df2ca46e46ee9..2f10631f00520 100644 --- a/src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/Fixtures/php/mailer_with_dsn.php +++ b/src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/Fixtures/php/mailer_with_dsn.php @@ -8,7 +8,7 @@ 'dsn' => 'smtp://example.com', 'envelope' => [ 'sender' => 'sender@example.org', - 'recipients' => ['redirected@example.org', 'redirected1@example.org'], + 'recipients' => ['redirected@example.org'], ], 'headers' => [ 'from' => 'from@example.org', diff --git a/src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/Fixtures/xml/mailer_with_dsn.xml b/src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/Fixtures/xml/mailer_with_dsn.xml index be53f59bc3cad..06109accc233d 100644 --- a/src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/Fixtures/xml/mailer_with_dsn.xml +++ b/src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/Fixtures/xml/mailer_with_dsn.xml @@ -10,8 +10,7 @@ sender@example.org - redirected@example.org - redirected1@example.org + redirected@example.org from@example.org bcc1@example.org diff --git a/src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/Fixtures/xml/mailer_with_transports.xml b/src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/Fixtures/xml/mailer_with_transports.xml index cbe538d33e99c..56a6e61af8114 100644 --- a/src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/Fixtures/xml/mailer_with_transports.xml +++ b/src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/Fixtures/xml/mailer_with_transports.xml @@ -12,8 +12,8 @@ smtp://example2.com sender@example.org - redirected@example.org - redirected1@example.org + redirected@example.org + redirected1@example.org from@example.org bcc1@example.org diff --git a/src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/Fixtures/yml/mailer_with_dsn.yml b/src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/Fixtures/yml/mailer_with_dsn.yml index f8b3c87c4302c..7aa79560d2db9 100644 --- a/src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/Fixtures/yml/mailer_with_dsn.yml +++ b/src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/Fixtures/yml/mailer_with_dsn.yml @@ -5,7 +5,6 @@ framework: sender: sender@example.org recipients: - redirected@example.org - - redirected1@example.org headers: from: from@example.org bcc: [bcc1@example.org, bcc2@example.org] diff --git a/src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/FrameworkExtensionTestCase.php b/src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/FrameworkExtensionTestCase.php index 5e955d0163a31..7555b7530032b 100644 --- a/src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/FrameworkExtensionTestCase.php +++ b/src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/FrameworkExtensionTestCase.php @@ -318,7 +318,7 @@ public function testWorkflows() $this->assertSame('state_machine.pull_request.metadata_store', (string) $metadataStoreReference); $metadataStoreDefinition = $container->getDefinition('state_machine.pull_request.metadata_store'); - $this->assertSame(Workflow\Metadata\InMemoryMetadataStore::class, $metadataStoreDefinition->getClass()); + $this->assertSame(InMemoryMetadataStore::class, $metadataStoreDefinition->getClass()); $this->assertSame(InMemoryMetadataStore::class, $metadataStoreDefinition->getClass()); $workflowMetadata = $metadataStoreDefinition->getArgument(0); @@ -1940,21 +1940,27 @@ public function testHttpClientFullDefaultOptions() ], $defaultOptions['peer_fingerprint']); } - public static function provideMailer(): array + public static function provideMailer(): iterable { - return [ - ['mailer_with_dsn', ['main' => 'smtp://example.com']], - ['mailer_with_transports', [ + yield [ + 'mailer_with_dsn', + ['main' => 'smtp://example.com'], + ['redirected@example.org'], + ]; + yield [ + 'mailer_with_transports', + [ 'transport1' => 'smtp://example1.com', 'transport2' => 'smtp://example2.com', - ]], + ], + ['redirected@example.org', 'redirected1@example.org'], ]; } /** * @dataProvider provideMailer */ - public function testMailer(string $configFile, array $expectedTransports) + public function testMailer(string $configFile, array $expectedTransports, array $expectedRecipients) { $container = $this->createContainerFromFile($configFile); @@ -1966,7 +1972,7 @@ public function testMailer(string $configFile, array $expectedTransports) $this->assertTrue($container->hasDefinition('mailer.envelope_listener')); $l = $container->getDefinition('mailer.envelope_listener'); $this->assertSame('sender@example.org', $l->getArgument(0)); - $this->assertSame(['redirected@example.org', 'redirected1@example.org'], $l->getArgument(1)); + $this->assertSame($expectedRecipients, $l->getArgument(1)); $this->assertEquals(new Reference('messenger.default_bus', ContainerInterface::NULL_ON_INVALID_REFERENCE), $container->getDefinition('mailer.mailer')->getArgument(1)); $this->assertTrue($container->hasDefinition('mailer.message_listener')); diff --git a/src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/XmlFrameworkExtensionTest.php b/src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/XmlFrameworkExtensionTest.php index 4a2ff788bf5c6..3b388812fd60e 100644 --- a/src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/XmlFrameworkExtensionTest.php +++ b/src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/XmlFrameworkExtensionTest.php @@ -14,7 +14,6 @@ use Symfony\Component\Config\FileLocator; use Symfony\Component\DependencyInjection\ContainerBuilder; use Symfony\Component\DependencyInjection\Loader\XmlFileLoader; -use Symfony\Component\RateLimiter\Policy\SlidingWindowLimiter; class XmlFrameworkExtensionTest extends FrameworkExtensionTestCase { From d7519b74904146516a215c0a60d2b5e2ae757635 Mon Sep 17 00:00:00 2001 From: Neil Peyssard Date: Fri, 15 Mar 2024 10:21:56 +0100 Subject: [PATCH 46/81] [Filesystem] Fix str_contains deprecation --- src/Symfony/Component/Filesystem/Filesystem.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Symfony/Component/Filesystem/Filesystem.php b/src/Symfony/Component/Filesystem/Filesystem.php index 037629f18919d..4df06aed115db 100644 --- a/src/Symfony/Component/Filesystem/Filesystem.php +++ b/src/Symfony/Component/Filesystem/Filesystem.php @@ -199,7 +199,7 @@ private static function doRemove(array $files, bool $isRecursive): void throw new IOException(sprintf('Failed to remove directory "%s": ', $file).$lastError); } - } elseif (!self::box('unlink', $file) && (str_contains(self::$lastError, 'Permission denied') || file_exists($file))) { + } elseif (!self::box('unlink', $file) && ((self::$lastError && str_contains(self::$lastError, 'Permission denied')) || file_exists($file))) { throw new IOException(sprintf('Failed to remove file "%s": ', $file).self::$lastError); } } From 868939c6a083262eb3afaa397398b862e57bc5c8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?G=C3=A1lik=20P=C3=A1l?= Date: Thu, 7 Mar 2024 21:17:55 +0100 Subject: [PATCH 47/81] [Mailer] [Brevo] Check that tags is present in payload before calling setTags --- .../Brevo/RemoteEvent/BrevoPayloadConverter.php | 5 ++++- .../Webhook/Fixtures/request_without_tags.json | 13 +++++++++++++ .../Tests/Webhook/Fixtures/request_without_tags.php | 9 +++++++++ 3 files changed, 26 insertions(+), 1 deletion(-) create mode 100644 src/Symfony/Component/Mailer/Bridge/Brevo/Tests/Webhook/Fixtures/request_without_tags.json create mode 100644 src/Symfony/Component/Mailer/Bridge/Brevo/Tests/Webhook/Fixtures/request_without_tags.php diff --git a/src/Symfony/Component/Mailer/Bridge/Brevo/RemoteEvent/BrevoPayloadConverter.php b/src/Symfony/Component/Mailer/Bridge/Brevo/RemoteEvent/BrevoPayloadConverter.php index 8d556b8f37c9a..5f5f0816c23c6 100644 --- a/src/Symfony/Component/Mailer/Bridge/Brevo/RemoteEvent/BrevoPayloadConverter.php +++ b/src/Symfony/Component/Mailer/Bridge/Brevo/RemoteEvent/BrevoPayloadConverter.php @@ -60,7 +60,10 @@ public function convert(array $payload): AbstractMailerEvent $event->setDate($date); $event->setRecipientEmail($payload['email']); - $event->setTags($payload['tags']); + + if (isset($payload['tags'])) { + $event->setTags($payload['tags']); + } return $event; } diff --git a/src/Symfony/Component/Mailer/Bridge/Brevo/Tests/Webhook/Fixtures/request_without_tags.json b/src/Symfony/Component/Mailer/Bridge/Brevo/Tests/Webhook/Fixtures/request_without_tags.json new file mode 100644 index 0000000000000..4fbeadc58112b --- /dev/null +++ b/src/Symfony/Component/Mailer/Bridge/Brevo/Tests/Webhook/Fixtures/request_without_tags.json @@ -0,0 +1,13 @@ +{ + "id": 814119, + "email": "example@gmail.com", + "message-id": "<202305311313.92192897094@smtp-relay.mailin.fr>", + "date": "2023-05-31 15:13:08", + "event": "request", + "subject": "Subject Line", + "sending_ip": "127.0.0.1", + "ts_event": 1685538788, + "ts": 1685538788, + "reason": "sent", + "ts_epoch": 1685538788179 +} diff --git a/src/Symfony/Component/Mailer/Bridge/Brevo/Tests/Webhook/Fixtures/request_without_tags.php b/src/Symfony/Component/Mailer/Bridge/Brevo/Tests/Webhook/Fixtures/request_without_tags.php new file mode 100644 index 0000000000000..57bb1ff1893ee --- /dev/null +++ b/src/Symfony/Component/Mailer/Bridge/Brevo/Tests/Webhook/Fixtures/request_without_tags.php @@ -0,0 +1,9 @@ +', json_decode(file_get_contents(str_replace('.php', '.json', __FILE__)), true, flags: JSON_THROW_ON_ERROR)); +$wh->setRecipientEmail('example@gmail.com'); +$wh->setDate(\DateTimeImmutable::createFromFormat('U', 1685538788)); + +return $wh; From 98fe71abe6fee8d84d6c2b3b6f29330f0f777134 Mon Sep 17 00:00:00 2001 From: Ariful Alam Date: Sat, 16 Mar 2024 00:07:11 +0600 Subject: [PATCH 48/81] [Cache][Lock] Identify missing table in pgsql correctly and address failing integration tests --- src/Symfony/Component/Cache/Adapter/PdoAdapter.php | 4 ++-- src/Symfony/Component/Lock/Store/PdoStore.php | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/Symfony/Component/Cache/Adapter/PdoAdapter.php b/src/Symfony/Component/Cache/Adapter/PdoAdapter.php index 1674850350921..a2a275b861314 100644 --- a/src/Symfony/Component/Cache/Adapter/PdoAdapter.php +++ b/src/Symfony/Component/Cache/Adapter/PdoAdapter.php @@ -600,10 +600,10 @@ private function getServerVersion(): string private function isTableMissing(\PDOException $exception): bool { $driver = $this->driver; - $code = $exception->errorInfo ? $exception->errorInfo[1] : $exception->getCode(); + [$sqlState, $code] = $exception->errorInfo ?? [null, $exception->getCode()]; switch (true) { - case 'pgsql' === $driver && '42P01' === $code: + case 'pgsql' === $driver && '42P01' === $sqlState: case 'sqlite' === $driver && str_contains($exception->getMessage(), 'no such table:'): case 'oci' === $driver && 942 === $code: case 'sqlsrv' === $driver && 208 === $code: diff --git a/src/Symfony/Component/Lock/Store/PdoStore.php b/src/Symfony/Component/Lock/Store/PdoStore.php index ba4965b0057f9..70c69919737ec 100644 --- a/src/Symfony/Component/Lock/Store/PdoStore.php +++ b/src/Symfony/Component/Lock/Store/PdoStore.php @@ -330,10 +330,10 @@ private function getCurrentTimestampStatement(): string private function isTableMissing(\PDOException $exception): bool { $driver = $this->getDriver(); - $code = $exception->errorInfo ? $exception->errorInfo[1] : $exception->getCode(); + [$sqlState, $code] = $exception->errorInfo ?? [null, $exception->getCode()]; switch (true) { - case 'pgsql' === $driver && '42P01' === $code: + case 'pgsql' === $driver && '42P01' === $sqlState: case 'sqlite' === $driver && str_contains($exception->getMessage(), 'no such table:'): case 'oci' === $driver && 942 === $code: case 'sqlsrv' === $driver && 208 === $code: From dd3c25426506d2ee4b27604ce0668fb088af299f Mon Sep 17 00:00:00 2001 From: Francisco Alvarez Alonso Date: Fri, 15 Mar 2024 21:33:22 +0100 Subject: [PATCH 49/81] Throw TransformationFailedException when there is a null bytes injection --- .../DataTransformer/DateTimeToStringTransformer.php | 4 ++++ .../DateTimeToStringTransformerTest.php | 13 +++++++++++++ 2 files changed, 17 insertions(+) diff --git a/src/Symfony/Component/Form/Extension/Core/DataTransformer/DateTimeToStringTransformer.php b/src/Symfony/Component/Form/Extension/Core/DataTransformer/DateTimeToStringTransformer.php index 4e3df8690a571..b4e13eb8fb1cc 100644 --- a/src/Symfony/Component/Form/Extension/Core/DataTransformer/DateTimeToStringTransformer.php +++ b/src/Symfony/Component/Form/Extension/Core/DataTransformer/DateTimeToStringTransformer.php @@ -118,6 +118,10 @@ public function reverseTransform($value) throw new TransformationFailedException('Expected a string.'); } + if (str_contains($value, "\0")) { + throw new TransformationFailedException('Null bytes not allowed'); + } + $outputTz = new \DateTimeZone($this->outputTimezone); $dateTime = \DateTime::createFromFormat($this->parseFormat, $value, $outputTz); diff --git a/src/Symfony/Component/Form/Tests/Extension/Core/DataTransformer/DateTimeToStringTransformerTest.php b/src/Symfony/Component/Form/Tests/Extension/Core/DataTransformer/DateTimeToStringTransformerTest.php index 66ad9ff416e26..f7ef667e769b6 100644 --- a/src/Symfony/Component/Form/Tests/Extension/Core/DataTransformer/DateTimeToStringTransformerTest.php +++ b/src/Symfony/Component/Form/Tests/Extension/Core/DataTransformer/DateTimeToStringTransformerTest.php @@ -133,6 +133,19 @@ public function testReverseTransformEmpty() $this->assertNull($reverseTransformer->reverseTransform('')); } + public function testReverseTransformWithNullBytes() + { + $transformer = new DateTimeToStringTransformer(); + + $nullByte = \chr(0); + $value = '2024-03-15 21:11:00'.$nullByte; + + $this->expectException(TransformationFailedException::class); + $this->expectExceptionMessage('Null bytes not allowed'); + + $transformer->reverseTransform($value); + } + public function testReverseTransformWithDifferentTimezones() { $reverseTransformer = new DateTimeToStringTransformer('America/New_York', 'Asia/Hong_Kong', 'Y-m-d H:i:s'); From 43d9c191145fe1fb1ac7e2cd1268e542ed0c7b1b Mon Sep 17 00:00:00 2001 From: eltharin Date: Wed, 13 Mar 2024 14:18:10 +0100 Subject: [PATCH 50/81] [DoctrineBridge] Fix deprecation warning with ORM 3 when guessing field lengths --- .../Bridge/Doctrine/Form/DoctrineOrmTypeGuesser.php | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/Symfony/Bridge/Doctrine/Form/DoctrineOrmTypeGuesser.php b/src/Symfony/Bridge/Doctrine/Form/DoctrineOrmTypeGuesser.php index 49b0a9f89aefa..1023602248fed 100644 --- a/src/Symfony/Bridge/Doctrine/Form/DoctrineOrmTypeGuesser.php +++ b/src/Symfony/Bridge/Doctrine/Form/DoctrineOrmTypeGuesser.php @@ -13,6 +13,7 @@ use Doctrine\DBAL\Types\Types; use Doctrine\ORM\Mapping\ClassMetadataInfo; +use Doctrine\ORM\Mapping\FieldMapping; use Doctrine\ORM\Mapping\JoinColumnMapping; use Doctrine\ORM\Mapping\MappingException as LegacyMappingException; use Doctrine\Persistence\ManagerRegistry; @@ -141,8 +142,10 @@ public function guessMaxLength(string $class, string $property) if ($ret && isset($ret[0]->fieldMappings[$property]) && !$ret[0]->hasAssociation($property)) { $mapping = $ret[0]->getFieldMapping($property); - if (isset($mapping['length'])) { - return new ValueGuess($mapping['length'], Guess::HIGH_CONFIDENCE); + $length = $mapping instanceof FieldMapping ? $mapping->length : ($mapping['length'] ?? null); + + if (null !== $length) { + return new ValueGuess($length, Guess::HIGH_CONFIDENCE); } if (\in_array($ret[0]->getTypeOfField($property), [Types::DECIMAL, Types::FLOAT])) { From 410bcceb18980b9bcb384644e9f89246ebe674a7 Mon Sep 17 00:00:00 2001 From: Adam Bramley Date: Fri, 1 Mar 2024 10:54:31 +1100 Subject: [PATCH 51/81] Catch TableNotFoundException in MySQL delete --- .../Messenger/Bridge/Doctrine/Transport/Connection.php | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/Symfony/Component/Messenger/Bridge/Doctrine/Transport/Connection.php b/src/Symfony/Component/Messenger/Bridge/Doctrine/Transport/Connection.php index 2b77b78f531f4..79b302760ad22 100644 --- a/src/Symfony/Component/Messenger/Bridge/Doctrine/Transport/Connection.php +++ b/src/Symfony/Component/Messenger/Bridge/Doctrine/Transport/Connection.php @@ -161,6 +161,10 @@ public function get(): ?array $this->driverConnection->delete($this->configuration['table_name'], ['delivered_at' => '9999-12-31 23:59:59']); } catch (DriverException $e) { // Ignore the exception + } catch (TableNotFoundException $e) { + if ($this->autoSetup) { + $this->setup(); + } } } From e9d30bac03fc341a43acabfd0651b4961be261fb Mon Sep 17 00:00:00 2001 From: Alexandre Daubois Date: Sat, 16 Mar 2024 08:20:26 +0100 Subject: [PATCH 52/81] Add more explicit nullable types for default null values --- .../Tests/Fixtures/ContainerAwareFixture.php | 2 +- .../Tests/Fixtures/Type/StringWrapper.php | 2 +- .../ConfigurationTest.php | 2 +- .../Cache/Tests/Fixtures/DriverWrapper.php | 2 +- .../Tests/Compiler/AutowirePassTest.php | 4 ++++ .../Tests/Fixtures/Bar.php | 4 ++-- .../BarMethodCall.php | 2 +- .../BarOptionalArgument.php | 2 +- .../CheckTypeDeclarationsPass/Foo.php | 2 +- .../Tests/Fixtures/OptionalParameter.php | 23 +++++++++++++++++++ .../Tests/Fixtures/Prototype/Foo.php | 2 +- .../Fixtures/includes/autowiring_classes.php | 17 ++++---------- .../Tests/Fixtures/MockStream/MockStream.php | 2 +- .../DeprecatedChoiceListFactory.php | 6 ++--- .../Form/Tests/Fixtures/CustomArrayObject.php | 2 +- .../Form/Tests/Fixtures/FixedTranslator.php | 2 +- .../DataCollector/CloneVarDataCollector.php | 2 +- .../Fixtures/NonTraversableArrayObject.php | 2 +- .../Tests/Fixtures/TraversableArrayObject.php | 2 +- .../PropertyInfo/Tests/Fixtures/Dummy.php | 2 +- .../Tests/Fixtures/RedirectableUrlMatcher.php | 2 +- .../Fixtures/AbstractNormalizerDummy.php | 8 +++---- .../Tests/Fixtures/DenormalizableDummy.php | 2 +- .../Serializer/Tests/Fixtures/Dummy.php | 4 ++-- .../Serializer/Tests/Fixtures/DummyString.php | 2 +- .../Tests/Fixtures/EnvelopeNormalizer.php | 4 ++-- .../Fixtures/EnvelopedMessageNormalizer.php | 4 ++-- .../Fixtures/NormalizableTraversableDummy.php | 4 ++-- .../Tests/Fixtures/NotNormalizableDummy.php | 2 +- .../Serializer/Tests/Fixtures/ScalarDummy.php | 4 ++-- .../AbstractObjectNormalizerTest.php | 12 +++++----- .../Tests/Fixtures/CustomArrayObject.php | 2 +- .../VarDumper/Tests/Fixtures/FooInterface.php | 2 +- .../VarDumper/Tests/Fixtures/Twig.php | 2 +- .../VarDumper/Tests/Fixtures/dumb-var.php | 2 +- 35 files changed, 80 insertions(+), 60 deletions(-) create mode 100644 src/Symfony/Component/DependencyInjection/Tests/Fixtures/OptionalParameter.php diff --git a/src/Symfony/Bridge/Doctrine/Tests/Fixtures/ContainerAwareFixture.php b/src/Symfony/Bridge/Doctrine/Tests/Fixtures/ContainerAwareFixture.php index cccaeedee80a7..307b563d69462 100644 --- a/src/Symfony/Bridge/Doctrine/Tests/Fixtures/ContainerAwareFixture.php +++ b/src/Symfony/Bridge/Doctrine/Tests/Fixtures/ContainerAwareFixture.php @@ -20,7 +20,7 @@ class ContainerAwareFixture implements FixtureInterface, ContainerAwareInterface { public $container; - public function setContainer(ContainerInterface $container = null) + public function setContainer(?ContainerInterface $container = null) { $this->container = $container; } diff --git a/src/Symfony/Bridge/Doctrine/Tests/Fixtures/Type/StringWrapper.php b/src/Symfony/Bridge/Doctrine/Tests/Fixtures/Type/StringWrapper.php index 941ab3ed48ee8..ff031ed40d592 100644 --- a/src/Symfony/Bridge/Doctrine/Tests/Fixtures/Type/StringWrapper.php +++ b/src/Symfony/Bridge/Doctrine/Tests/Fixtures/Type/StringWrapper.php @@ -15,7 +15,7 @@ class StringWrapper { private $string; - public function __construct(string $string = null) + public function __construct(?string $string = null) { $this->string = $string; } diff --git a/src/Symfony/Bridge/PhpUnit/Tests/DeprecationErrorHandler/ConfigurationTest.php b/src/Symfony/Bridge/PhpUnit/Tests/DeprecationErrorHandler/ConfigurationTest.php index 726f397f919b3..557906895ad34 100644 --- a/src/Symfony/Bridge/PhpUnit/Tests/DeprecationErrorHandler/ConfigurationTest.php +++ b/src/Symfony/Bridge/PhpUnit/Tests/DeprecationErrorHandler/ConfigurationTest.php @@ -525,7 +525,7 @@ public function testBaselineFileWriteError() $this->expectException(\ErrorException::class); $this->expectExceptionMessageMatches('/[Ff]ailed to open stream: Permission denied/'); - set_error_handler(static function (int $errno, string $errstr, string $errfile = null, int $errline = null): bool { + set_error_handler(static function (int $errno, string $errstr, ?string $errfile = null, ?int $errline = null): bool { if ($errno & (E_WARNING | E_WARNING)) { throw new \ErrorException($errstr, 0, $errno, $errfile, $errline); } diff --git a/src/Symfony/Component/Cache/Tests/Fixtures/DriverWrapper.php b/src/Symfony/Component/Cache/Tests/Fixtures/DriverWrapper.php index f0d97724a4e3f..0f7337fe6e913 100644 --- a/src/Symfony/Component/Cache/Tests/Fixtures/DriverWrapper.php +++ b/src/Symfony/Component/Cache/Tests/Fixtures/DriverWrapper.php @@ -32,7 +32,7 @@ public function connect(array $params, $username = null, $password = null, array return $this->driver->connect($params, $username, $password, $driverOptions); } - public function getDatabasePlatform(ServerVersionProvider $versionProvider = null): AbstractPlatform + public function getDatabasePlatform(?ServerVersionProvider $versionProvider = null): AbstractPlatform { return $this->driver->getDatabasePlatform($versionProvider); } diff --git a/src/Symfony/Component/DependencyInjection/Tests/Compiler/AutowirePassTest.php b/src/Symfony/Component/DependencyInjection/Tests/Compiler/AutowirePassTest.php index ac81725033e42..a68755aa3e349 100644 --- a/src/Symfony/Component/DependencyInjection/Tests/Compiler/AutowirePassTest.php +++ b/src/Symfony/Component/DependencyInjection/Tests/Compiler/AutowirePassTest.php @@ -28,6 +28,7 @@ use Symfony\Component\DependencyInjection\Tests\Fixtures\CaseSensitiveClass; use Symfony\Component\DependencyInjection\Tests\Fixtures\includes\FooVariadic; use Symfony\Component\DependencyInjection\Tests\Fixtures\includes\MultipleArgumentsOptionalScalarNotReallyOptional; +use Symfony\Component\DependencyInjection\Tests\Fixtures\OptionalParameter; use Symfony\Component\DependencyInjection\Tests\Fixtures\WithTarget; use Symfony\Component\DependencyInjection\TypedReference; use Symfony\Contracts\Service\Attribute\Required; @@ -405,6 +406,9 @@ public function testResolveParameter() $this->assertEquals(Foo::class, $container->getDefinition('bar')->getArgument(0)); } + /** + * @group legacy + */ public function testOptionalParameter() { $container = new ContainerBuilder(); diff --git a/src/Symfony/Component/DependencyInjection/Tests/Fixtures/Bar.php b/src/Symfony/Component/DependencyInjection/Tests/Fixtures/Bar.php index 7e1a30b5ffa07..19fc83d8b7e95 100644 --- a/src/Symfony/Component/DependencyInjection/Tests/Fixtures/Bar.php +++ b/src/Symfony/Component/DependencyInjection/Tests/Fixtures/Bar.php @@ -15,12 +15,12 @@ class Bar implements BarInterface { public $quz; - public function __construct($quz = null, \NonExistent $nonExistent = null, BarInterface $decorated = null, array $foo = [], iterable $baz = []) + public function __construct($quz = null, ?\NonExistent $nonExistent = null, ?BarInterface $decorated = null, array $foo = [], iterable $baz = []) { $this->quz = $quz; } - public static function create(\NonExistent $nonExistent = null, $factory = null) + public static function create(?\NonExistent $nonExistent = null, $factory = null) { } } diff --git a/src/Symfony/Component/DependencyInjection/Tests/Fixtures/CheckTypeDeclarationsPass/BarMethodCall.php b/src/Symfony/Component/DependencyInjection/Tests/Fixtures/CheckTypeDeclarationsPass/BarMethodCall.php index 65437a63ec743..53f8bb7c3221e 100644 --- a/src/Symfony/Component/DependencyInjection/Tests/Fixtures/CheckTypeDeclarationsPass/BarMethodCall.php +++ b/src/Symfony/Component/DependencyInjection/Tests/Fixtures/CheckTypeDeclarationsPass/BarMethodCall.php @@ -20,7 +20,7 @@ public function setFoosVariadic(Foo $foo, Foo ...$foos) $this->foo = $foo; } - public function setFoosOptional(Foo $foo, Foo $fooOptional = null) + public function setFoosOptional(Foo $foo, ?Foo $fooOptional = null) { $this->foo = $foo; } diff --git a/src/Symfony/Component/DependencyInjection/Tests/Fixtures/CheckTypeDeclarationsPass/BarOptionalArgument.php b/src/Symfony/Component/DependencyInjection/Tests/Fixtures/CheckTypeDeclarationsPass/BarOptionalArgument.php index 4f348895132ca..98ee3a45a6036 100644 --- a/src/Symfony/Component/DependencyInjection/Tests/Fixtures/CheckTypeDeclarationsPass/BarOptionalArgument.php +++ b/src/Symfony/Component/DependencyInjection/Tests/Fixtures/CheckTypeDeclarationsPass/BarOptionalArgument.php @@ -6,7 +6,7 @@ class BarOptionalArgument { public $foo; - public function __construct(\stdClass $foo = null) + public function __construct(?\stdClass $foo = null) { $this->foo = $foo; } diff --git a/src/Symfony/Component/DependencyInjection/Tests/Fixtures/CheckTypeDeclarationsPass/Foo.php b/src/Symfony/Component/DependencyInjection/Tests/Fixtures/CheckTypeDeclarationsPass/Foo.php index e775def689305..36f027f1dd9c6 100644 --- a/src/Symfony/Component/DependencyInjection/Tests/Fixtures/CheckTypeDeclarationsPass/Foo.php +++ b/src/Symfony/Component/DependencyInjection/Tests/Fixtures/CheckTypeDeclarationsPass/Foo.php @@ -9,7 +9,7 @@ public static function createBar() return new Bar(new \stdClass()); } - public static function createBarArguments(\stdClass $stdClass, \stdClass $stdClassOptional = null) + public static function createBarArguments(\stdClass $stdClass, ?\stdClass $stdClassOptional = null) { return new Bar($stdClass); } diff --git a/src/Symfony/Component/DependencyInjection/Tests/Fixtures/OptionalParameter.php b/src/Symfony/Component/DependencyInjection/Tests/Fixtures/OptionalParameter.php new file mode 100644 index 0000000000000..8674c648e9005 --- /dev/null +++ b/src/Symfony/Component/DependencyInjection/Tests/Fixtures/OptionalParameter.php @@ -0,0 +1,23 @@ + + * + * For the full copyright and license information, please view the LICENSE + * file that was distributed with this source code. + */ + +namespace Symfony\Component\DependencyInjection\Tests\Fixtures; + +use Symfony\Component\DependencyInjection\Tests\Compiler\A; +use Symfony\Component\DependencyInjection\Tests\Compiler\CollisionInterface; +use Symfony\Component\DependencyInjection\Tests\Compiler\Foo; + +class OptionalParameter +{ + public function __construct(?CollisionInterface $c = null, A $a, ?Foo $f = null) + { + } +} diff --git a/src/Symfony/Component/DependencyInjection/Tests/Fixtures/Prototype/Foo.php b/src/Symfony/Component/DependencyInjection/Tests/Fixtures/Prototype/Foo.php index 49545a8dfa2e6..ba061adebe1e3 100644 --- a/src/Symfony/Component/DependencyInjection/Tests/Fixtures/Prototype/Foo.php +++ b/src/Symfony/Component/DependencyInjection/Tests/Fixtures/Prototype/Foo.php @@ -8,7 +8,7 @@ #[When(env: 'dev')] class Foo implements FooInterface, Sub\BarInterface { - public function __construct($bar = null, iterable $foo = null, object $baz = null) + public function __construct($bar = null, ?iterable $foo = null, ?object $baz = null) { } diff --git a/src/Symfony/Component/DependencyInjection/Tests/Fixtures/includes/autowiring_classes.php b/src/Symfony/Component/DependencyInjection/Tests/Fixtures/includes/autowiring_classes.php index 87440891d85fc..a360fbaefad54 100644 --- a/src/Symfony/Component/DependencyInjection/Tests/Fixtures/includes/autowiring_classes.php +++ b/src/Symfony/Component/DependencyInjection/Tests/Fixtures/includes/autowiring_classes.php @@ -99,7 +99,7 @@ public function __construct(A $a, DInterface $d) class E { - public function __construct(D $d = null) + public function __construct(?D $d = null) { } } @@ -155,13 +155,6 @@ public function __construct(Dunglas $j, Dunglas $k) } } -class OptionalParameter -{ - public function __construct(CollisionInterface $c = null, A $a, Foo $f = null) - { - } -} - class BadTypeHintedArgument { public function __construct(Dunglas $k, NotARealClass $r) @@ -195,7 +188,7 @@ public function __construct(A $k, $foo, Dunglas $dunglas, array $bar) class MultipleArgumentsOptionalScalar { - public function __construct(A $a, $foo = 'default_val', Lille $lille = null) + public function __construct(A $a, $foo = 'default_val', ?Lille $lille = null) { } } @@ -211,7 +204,7 @@ public function __construct(A $a, Lille $lille, $foo = 'some_val') */ class ClassForResource { - public function __construct($foo, Bar $bar = null) + public function __construct($foo, ?Bar $bar = null) { } @@ -350,7 +343,7 @@ public function setBar() { } - public function setOptionalNotAutowireable(NotARealClass $n = null) + public function setOptionalNotAutowireable(?NotARealClass $n = null) { } @@ -399,7 +392,7 @@ class DecoratorImpl implements DecoratorInterface class Decorated implements DecoratorInterface { - public function __construct($quz = null, \NonExistent $nonExistent = null, DecoratorInterface $decorated = null, array $foo = []) + public function __construct($quz = null, ?\NonExistent $nonExistent = null, ?DecoratorInterface $decorated = null, array $foo = []) { } } diff --git a/src/Symfony/Component/Filesystem/Tests/Fixtures/MockStream/MockStream.php b/src/Symfony/Component/Filesystem/Tests/Fixtures/MockStream/MockStream.php index cb8ed6a775140..bf4c1466c5894 100644 --- a/src/Symfony/Component/Filesystem/Tests/Fixtures/MockStream/MockStream.php +++ b/src/Symfony/Component/Filesystem/Tests/Fixtures/MockStream/MockStream.php @@ -28,7 +28,7 @@ class MockStream * @param string|null $opened_path If the path is opened successfully, and STREAM_USE_PATH is set in options, * opened_path should be set to the full path of the file/resource that was actually opened */ - public function stream_open(string $path, string $mode, int $options, string &$opened_path = null): bool + public function stream_open(string $path, string $mode, int $options, ?string &$opened_path = null): bool { return true; } diff --git a/src/Symfony/Component/Form/Tests/Fixtures/ChoiceList/DeprecatedChoiceListFactory.php b/src/Symfony/Component/Form/Tests/Fixtures/ChoiceList/DeprecatedChoiceListFactory.php index 89d4ec182ed74..731262a84dfc3 100644 --- a/src/Symfony/Component/Form/Tests/Fixtures/ChoiceList/DeprecatedChoiceListFactory.php +++ b/src/Symfony/Component/Form/Tests/Fixtures/ChoiceList/DeprecatedChoiceListFactory.php @@ -9,15 +9,15 @@ class DeprecatedChoiceListFactory implements ChoiceListFactoryInterface { - public function createListFromChoices(iterable $choices, callable $value = null): ChoiceListInterface + public function createListFromChoices(iterable $choices, ?callable $value = null): ChoiceListInterface { } - public function createListFromLoader(ChoiceLoaderInterface $loader, callable $value = null): ChoiceListInterface + public function createListFromLoader(ChoiceLoaderInterface $loader, ?callable $value = null): ChoiceListInterface { } - public function createView(ChoiceListInterface $list, $preferredChoices = null, $label = null, callable $index = null, callable $groupBy = null, $attr = null): ChoiceListView + public function createView(ChoiceListInterface $list, $preferredChoices = null, $label = null, ?callable $index = null, ?callable $groupBy = null, $attr = null): ChoiceListView { } } diff --git a/src/Symfony/Component/Form/Tests/Fixtures/CustomArrayObject.php b/src/Symfony/Component/Form/Tests/Fixtures/CustomArrayObject.php index 942add40e3736..7a4db4fe28611 100644 --- a/src/Symfony/Component/Form/Tests/Fixtures/CustomArrayObject.php +++ b/src/Symfony/Component/Form/Tests/Fixtures/CustomArrayObject.php @@ -19,7 +19,7 @@ class CustomArrayObject implements \ArrayAccess, \IteratorAggregate, \Countable, { private $array; - public function __construct(array $array = null) + public function __construct(?array $array = null) { $this->array = $array ?: []; } diff --git a/src/Symfony/Component/Form/Tests/Fixtures/FixedTranslator.php b/src/Symfony/Component/Form/Tests/Fixtures/FixedTranslator.php index ba17b5dd3d99d..098ef83e4ac29 100644 --- a/src/Symfony/Component/Form/Tests/Fixtures/FixedTranslator.php +++ b/src/Symfony/Component/Form/Tests/Fixtures/FixedTranslator.php @@ -22,7 +22,7 @@ public function __construct(array $translations) $this->translations = $translations; } - public function trans(string $id, array $parameters = [], string $domain = null, string $locale = null): string + public function trans(string $id, array $parameters = [], ?string $domain = null, ?string $locale = null): string { return $this->translations[$id] ?? $id; } diff --git a/src/Symfony/Component/HttpKernel/Tests/Fixtures/DataCollector/CloneVarDataCollector.php b/src/Symfony/Component/HttpKernel/Tests/Fixtures/DataCollector/CloneVarDataCollector.php index 3c8d27449c027..a6ebc06da9cab 100644 --- a/src/Symfony/Component/HttpKernel/Tests/Fixtures/DataCollector/CloneVarDataCollector.php +++ b/src/Symfony/Component/HttpKernel/Tests/Fixtures/DataCollector/CloneVarDataCollector.php @@ -24,7 +24,7 @@ public function __construct($varToClone) $this->varToClone = $varToClone; } - public function collect(Request $request, Response $response, \Throwable $exception = null) + public function collect(Request $request, Response $response, ?\Throwable $exception = null) { $this->data = $this->cloneVar($this->varToClone); } diff --git a/src/Symfony/Component/PropertyAccess/Tests/Fixtures/NonTraversableArrayObject.php b/src/Symfony/Component/PropertyAccess/Tests/Fixtures/NonTraversableArrayObject.php index 72e053171c841..19bc4ec63f4d6 100644 --- a/src/Symfony/Component/PropertyAccess/Tests/Fixtures/NonTraversableArrayObject.php +++ b/src/Symfony/Component/PropertyAccess/Tests/Fixtures/NonTraversableArrayObject.php @@ -19,7 +19,7 @@ class NonTraversableArrayObject implements \ArrayAccess, \Countable, \Serializab { private $array; - public function __construct(array $array = null) + public function __construct(?array $array = null) { $this->array = $array ?: []; } diff --git a/src/Symfony/Component/PropertyAccess/Tests/Fixtures/TraversableArrayObject.php b/src/Symfony/Component/PropertyAccess/Tests/Fixtures/TraversableArrayObject.php index eb4da3f201342..dc155a7bfaa58 100644 --- a/src/Symfony/Component/PropertyAccess/Tests/Fixtures/TraversableArrayObject.php +++ b/src/Symfony/Component/PropertyAccess/Tests/Fixtures/TraversableArrayObject.php @@ -19,7 +19,7 @@ class TraversableArrayObject implements \ArrayAccess, \IteratorAggregate, \Count { private $array; - public function __construct(array $array = null) + public function __construct(?array $array = null) { $this->array = $array ?: []; } diff --git a/src/Symfony/Component/PropertyInfo/Tests/Fixtures/Dummy.php b/src/Symfony/Component/PropertyInfo/Tests/Fixtures/Dummy.php index 2fb3d2e0f807c..06c0783a3c8f8 100644 --- a/src/Symfony/Component/PropertyInfo/Tests/Fixtures/Dummy.php +++ b/src/Symfony/Component/PropertyInfo/Tests/Fixtures/Dummy.php @@ -194,7 +194,7 @@ public function getA() * * @param ParentDummy|null $parent */ - public function setB(ParentDummy $parent = null) + public function setB(?ParentDummy $parent = null) { } diff --git a/src/Symfony/Component/Routing/Tests/Fixtures/RedirectableUrlMatcher.php b/src/Symfony/Component/Routing/Tests/Fixtures/RedirectableUrlMatcher.php index c5f49a83057c3..6c1dd651855ae 100644 --- a/src/Symfony/Component/Routing/Tests/Fixtures/RedirectableUrlMatcher.php +++ b/src/Symfony/Component/Routing/Tests/Fixtures/RedirectableUrlMatcher.php @@ -19,7 +19,7 @@ */ class RedirectableUrlMatcher extends UrlMatcher implements RedirectableUrlMatcherInterface { - public function redirect(string $path, string $route, string $scheme = null): array + public function redirect(string $path, string $route, ?string $scheme = null): array { return [ '_controller' => 'Some controller reference...', diff --git a/src/Symfony/Component/Serializer/Tests/Fixtures/AbstractNormalizerDummy.php b/src/Symfony/Component/Serializer/Tests/Fixtures/AbstractNormalizerDummy.php index ae3b411b31186..a3d28c6ca24fd 100644 --- a/src/Symfony/Component/Serializer/Tests/Fixtures/AbstractNormalizerDummy.php +++ b/src/Symfony/Component/Serializer/Tests/Fixtures/AbstractNormalizerDummy.php @@ -31,14 +31,14 @@ public function getAllowedAttributes($classOrObject, array $context, bool $attri /** * {@inheritdoc} */ - public function normalize($object, string $format = null, array $context = []) + public function normalize($object, ?string $format = null, array $context = []) { } /** * {@inheritdoc} */ - public function supportsNormalization($data, string $format = null): bool + public function supportsNormalization($data, ?string $format = null): bool { return true; } @@ -46,14 +46,14 @@ public function supportsNormalization($data, string $format = null): bool /** * {@inheritdoc} */ - public function denormalize($data, string $type, string $format = null, array $context = []) + public function denormalize($data, string $type, ?string $format = null, array $context = []) { } /** * {@inheritdoc} */ - public function supportsDenormalization($data, string $type, string $format = null): bool + public function supportsDenormalization($data, string $type, ?string $format = null): bool { return true; } diff --git a/src/Symfony/Component/Serializer/Tests/Fixtures/DenormalizableDummy.php b/src/Symfony/Component/Serializer/Tests/Fixtures/DenormalizableDummy.php index e7c03e3d8ec0c..3170e3618ef30 100644 --- a/src/Symfony/Component/Serializer/Tests/Fixtures/DenormalizableDummy.php +++ b/src/Symfony/Component/Serializer/Tests/Fixtures/DenormalizableDummy.php @@ -16,7 +16,7 @@ class DenormalizableDummy implements DenormalizableInterface { - public function denormalize(DenormalizerInterface $denormalizer, $data, string $format = null, array $context = []) + public function denormalize(DenormalizerInterface $denormalizer, $data, ?string $format = null, array $context = []) { } } diff --git a/src/Symfony/Component/Serializer/Tests/Fixtures/Dummy.php b/src/Symfony/Component/Serializer/Tests/Fixtures/Dummy.php index da0400593d254..db09a40b5651e 100644 --- a/src/Symfony/Component/Serializer/Tests/Fixtures/Dummy.php +++ b/src/Symfony/Component/Serializer/Tests/Fixtures/Dummy.php @@ -23,7 +23,7 @@ class Dummy implements NormalizableInterface, DenormalizableInterface public $baz; public $qux; - public function normalize(NormalizerInterface $normalizer, string $format = null, array $context = []) + public function normalize(NormalizerInterface $normalizer, ?string $format = null, array $context = []) { return [ 'foo' => $this->foo, @@ -33,7 +33,7 @@ public function normalize(NormalizerInterface $normalizer, string $format = null ]; } - public function denormalize(DenormalizerInterface $denormalizer, $data, string $format = null, array $context = []) + public function denormalize(DenormalizerInterface $denormalizer, $data, ?string $format = null, array $context = []) { $this->foo = $data['foo']; $this->bar = $data['bar']; diff --git a/src/Symfony/Component/Serializer/Tests/Fixtures/DummyString.php b/src/Symfony/Component/Serializer/Tests/Fixtures/DummyString.php index 056de300332a1..4a4bef8a19ca8 100644 --- a/src/Symfony/Component/Serializer/Tests/Fixtures/DummyString.php +++ b/src/Symfony/Component/Serializer/Tests/Fixtures/DummyString.php @@ -22,7 +22,7 @@ class DummyString implements DenormalizableInterface /** @var string $value */ public $value; - public function denormalize(DenormalizerInterface $denormalizer, $data, string $format = null, array $context = []) + public function denormalize(DenormalizerInterface $denormalizer, $data, ?string $format = null, array $context = []) { $this->value = $data; } diff --git a/src/Symfony/Component/Serializer/Tests/Fixtures/EnvelopeNormalizer.php b/src/Symfony/Component/Serializer/Tests/Fixtures/EnvelopeNormalizer.php index 1492d5d0298ec..f321d55af4fb0 100644 --- a/src/Symfony/Component/Serializer/Tests/Fixtures/EnvelopeNormalizer.php +++ b/src/Symfony/Component/Serializer/Tests/Fixtures/EnvelopeNormalizer.php @@ -20,7 +20,7 @@ class EnvelopeNormalizer implements NormalizerInterface { private $serializer; - public function normalize($envelope, string $format = null, array $context = []): array + public function normalize($envelope, ?string $format = null, array $context = []): array { $xmlContent = $this->serializer->serialize($envelope->message, 'xml'); @@ -31,7 +31,7 @@ public function normalize($envelope, string $format = null, array $context = []) ]; } - public function supportsNormalization($data, string $format = null, array $context = []): bool + public function supportsNormalization($data, ?string $format = null, array $context = []): bool { return $data instanceof EnvelopeObject; } diff --git a/src/Symfony/Component/Serializer/Tests/Fixtures/EnvelopedMessageNormalizer.php b/src/Symfony/Component/Serializer/Tests/Fixtures/EnvelopedMessageNormalizer.php index dfdec91b1b613..68a5b94707e59 100644 --- a/src/Symfony/Component/Serializer/Tests/Fixtures/EnvelopedMessageNormalizer.php +++ b/src/Symfony/Component/Serializer/Tests/Fixtures/EnvelopedMessageNormalizer.php @@ -18,14 +18,14 @@ */ class EnvelopedMessageNormalizer implements NormalizerInterface { - public function normalize($message, string $format = null, array $context = []): array + public function normalize($message, ?string $format = null, array $context = []): array { return [ 'text' => $message->text, ]; } - public function supportsNormalization($data, string $format = null, array $context = []): bool + public function supportsNormalization($data, ?string $format = null, array $context = []): bool { return $data instanceof EnvelopedMessage; } diff --git a/src/Symfony/Component/Serializer/Tests/Fixtures/NormalizableTraversableDummy.php b/src/Symfony/Component/Serializer/Tests/Fixtures/NormalizableTraversableDummy.php index 55b4402b076fa..26bbae37e10c3 100644 --- a/src/Symfony/Component/Serializer/Tests/Fixtures/NormalizableTraversableDummy.php +++ b/src/Symfony/Component/Serializer/Tests/Fixtures/NormalizableTraversableDummy.php @@ -18,7 +18,7 @@ class NormalizableTraversableDummy extends TraversableDummy implements NormalizableInterface, DenormalizableInterface { - public function normalize(NormalizerInterface $normalizer, string $format = null, array $context = []) + public function normalize(NormalizerInterface $normalizer, ?string $format = null, array $context = []) { return [ 'foo' => 'normalizedFoo', @@ -26,7 +26,7 @@ public function normalize(NormalizerInterface $normalizer, string $format = null ]; } - public function denormalize(DenormalizerInterface $denormalizer, $data, string $format = null, array $context = []) + public function denormalize(DenormalizerInterface $denormalizer, $data, ?string $format = null, array $context = []) { return [ 'foo' => 'denormalizedFoo', diff --git a/src/Symfony/Component/Serializer/Tests/Fixtures/NotNormalizableDummy.php b/src/Symfony/Component/Serializer/Tests/Fixtures/NotNormalizableDummy.php index 8bb655db9c536..86ee6dbe5da91 100644 --- a/src/Symfony/Component/Serializer/Tests/Fixtures/NotNormalizableDummy.php +++ b/src/Symfony/Component/Serializer/Tests/Fixtures/NotNormalizableDummy.php @@ -24,7 +24,7 @@ public function __construct() { } - public function denormalize(DenormalizerInterface $denormalizer, $data, string $format = null, array $context = []) + public function denormalize(DenormalizerInterface $denormalizer, $data, ?string $format = null, array $context = []) { throw new NotNormalizableValueException(); } diff --git a/src/Symfony/Component/Serializer/Tests/Fixtures/ScalarDummy.php b/src/Symfony/Component/Serializer/Tests/Fixtures/ScalarDummy.php index ffe4ee65859a2..0704db31d3644 100644 --- a/src/Symfony/Component/Serializer/Tests/Fixtures/ScalarDummy.php +++ b/src/Symfony/Component/Serializer/Tests/Fixtures/ScalarDummy.php @@ -21,12 +21,12 @@ class ScalarDummy implements NormalizableInterface, DenormalizableInterface public $foo; public $xmlFoo; - public function normalize(NormalizerInterface $normalizer, string $format = null, array $context = []) + public function normalize(NormalizerInterface $normalizer, ?string $format = null, array $context = []) { return 'xml' === $format ? $this->xmlFoo : $this->foo; } - public function denormalize(DenormalizerInterface $denormalizer, $data, string $format = null, array $context = []) + public function denormalize(DenormalizerInterface $denormalizer, $data, ?string $format = null, array $context = []) { if ('xml' === $format) { $this->xmlFoo = $data; diff --git a/src/Symfony/Component/Serializer/Tests/Normalizer/AbstractObjectNormalizerTest.php b/src/Symfony/Component/Serializer/Tests/Normalizer/AbstractObjectNormalizerTest.php index 5adc3d4eef74d..5243eb2f2ef1a 100644 --- a/src/Symfony/Component/Serializer/Tests/Normalizer/AbstractObjectNormalizerTest.php +++ b/src/Symfony/Component/Serializer/Tests/Normalizer/AbstractObjectNormalizerTest.php @@ -559,12 +559,12 @@ public function testProvidingContextCacheKeyGeneratesSameChildContextCacheKey() $normalizer = new class() extends AbstractObjectNormalizerDummy { public $childContextCacheKey; - protected function extractAttributes(object $object, string $format = null, array $context = []): array + protected function extractAttributes(object $object, ?string $format = null, array $context = []): array { return array_keys((array) $object); } - protected function getAttributeValue(object $object, string $attribute, string $format = null, array $context = []) + protected function getAttributeValue(object $object, string $attribute, ?string $format = null, array $context = []) { return $object->{$attribute}; } @@ -599,12 +599,12 @@ public function testChildContextKeepsOriginalContextCacheKey() $normalizer = new class() extends AbstractObjectNormalizerDummy { public $childContextCacheKey; - protected function extractAttributes(object $object, string $format = null, array $context = []): array + protected function extractAttributes(object $object, ?string $format = null, array $context = []): array { return array_keys((array) $object); } - protected function getAttributeValue(object $object, string $attribute, string $format = null, array $context = []) + protected function getAttributeValue(object $object, string $attribute, ?string $format = null, array $context = []) { return $object->{$attribute}; } @@ -634,12 +634,12 @@ public function testChildContextCacheKeyStaysFalseWhenOriginalCacheKeyIsFalse() $normalizer = new class() extends AbstractObjectNormalizerDummy { public $childContextCacheKey; - protected function extractAttributes(object $object, string $format = null, array $context = []): array + protected function extractAttributes(object $object, ?string $format = null, array $context = []): array { return array_keys((array) $object); } - protected function getAttributeValue(object $object, string $attribute, string $format = null, array $context = []) + protected function getAttributeValue(object $object, string $attribute, ?string $format = null, array $context = []) { return $object->{$attribute}; } diff --git a/src/Symfony/Component/Validator/Tests/Fixtures/CustomArrayObject.php b/src/Symfony/Component/Validator/Tests/Fixtures/CustomArrayObject.php index 4ca7f4a99fabe..7bc850ddc1fb6 100644 --- a/src/Symfony/Component/Validator/Tests/Fixtures/CustomArrayObject.php +++ b/src/Symfony/Component/Validator/Tests/Fixtures/CustomArrayObject.php @@ -19,7 +19,7 @@ class CustomArrayObject implements \ArrayAccess, \IteratorAggregate, \Countable, { private $array; - public function __construct(array $array = null) + public function __construct(?array $array = null) { $this->array = $array ?: []; } diff --git a/src/Symfony/Component/VarDumper/Tests/Fixtures/FooInterface.php b/src/Symfony/Component/VarDumper/Tests/Fixtures/FooInterface.php index 172958b47e2ab..c094efe2d5b15 100644 --- a/src/Symfony/Component/VarDumper/Tests/Fixtures/FooInterface.php +++ b/src/Symfony/Component/VarDumper/Tests/Fixtures/FooInterface.php @@ -7,5 +7,5 @@ interface FooInterface /** * Hello. */ - public function foo(?\stdClass $a, \stdClass $b = null); + public function foo(?\stdClass $a, ?\stdClass $b = null); } diff --git a/src/Symfony/Component/VarDumper/Tests/Fixtures/Twig.php b/src/Symfony/Component/VarDumper/Tests/Fixtures/Twig.php index 5d1a73d424b4b..bb6e578d5015c 100644 --- a/src/Symfony/Component/VarDumper/Tests/Fixtures/Twig.php +++ b/src/Symfony/Component/VarDumper/Tests/Fixtures/Twig.php @@ -18,7 +18,7 @@ class __TwigTemplate_VarDumperFixture_u75a09 extends AbstractTwigTemplate { private $path; - public function __construct(Twig\Environment $env = null, $path = null) + public function __construct(?Twig\Environment $env = null, $path = null) { if (null !== $env) { parent::__construct($env); diff --git a/src/Symfony/Component/VarDumper/Tests/Fixtures/dumb-var.php b/src/Symfony/Component/VarDumper/Tests/Fixtures/dumb-var.php index fc48012f4d13f..1b36fcd11e0f7 100644 --- a/src/Symfony/Component/VarDumper/Tests/Fixtures/dumb-var.php +++ b/src/Symfony/Component/VarDumper/Tests/Fixtures/dumb-var.php @@ -22,7 +22,7 @@ class DumbFoo '[]' => [], 'res' => $g, 'obj' => $foo, - 'closure' => function ($a, \PDO &$b = null) {}, + 'closure' => function ($a, ?\PDO &$b = null) {}, 'line' => __LINE__ - 1, 'nobj' => [(object) []], ]; From f6506aae3690d2fbb07e0811494c32aa9a6d6a30 Mon Sep 17 00:00:00 2001 From: Asis Pattisahusiwa <79239132+asispts@users.noreply.github.com> Date: Tue, 19 Mar 2024 10:26:44 +0700 Subject: [PATCH 53/81] Drop test case --- .../Doctrine/Tests/Form/Type/EntityTypeTest.php | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/src/Symfony/Bridge/Doctrine/Tests/Form/Type/EntityTypeTest.php b/src/Symfony/Bridge/Doctrine/Tests/Form/Type/EntityTypeTest.php index cde5c8f5bcda7..72dca16705af3 100644 --- a/src/Symfony/Bridge/Doctrine/Tests/Form/Type/EntityTypeTest.php +++ b/src/Symfony/Bridge/Doctrine/Tests/Form/Type/EntityTypeTest.php @@ -1346,19 +1346,6 @@ public function testPassIdAndNameToView() $this->assertEquals('name', $view->vars['full_name']); } - public function testStripLeadingUnderscoresAndDigitsFromId() - { - $view = $this->factory->createNamed('_09name', static::TESTED_TYPE, null, [ - 'em' => 'default', - 'class' => self::SINGLE_IDENT_CLASS, - ]) - ->createView(); - - $this->assertEquals('name', $view->vars['id']); - $this->assertEquals('_09name', $view->vars['name']); - $this->assertEquals('_09name', $view->vars['full_name']); - } - public function testPassIdAndNameToViewWithParent() { $view = $this->factory->createNamedBuilder('parent', FormTypeTest::TESTED_TYPE) From 9be8d52fe1cffedef93bc4f556ddf02583165273 Mon Sep 17 00:00:00 2001 From: Christian Flothmann Date: Tue, 19 Mar 2024 09:31:00 +0100 Subject: [PATCH 54/81] fix tests --- src/Symfony/Bridge/Doctrine/composer.json | 4 ++-- .../Tests/Extension/Core/Type/BaseTypeTestCase.php | 10 ---------- 2 files changed, 2 insertions(+), 12 deletions(-) diff --git a/src/Symfony/Bridge/Doctrine/composer.json b/src/Symfony/Bridge/Doctrine/composer.json index 61d08a0b213d2..6d90870c7af55 100644 --- a/src/Symfony/Bridge/Doctrine/composer.json +++ b/src/Symfony/Bridge/Doctrine/composer.json @@ -30,7 +30,7 @@ "symfony/cache": "^5.4|^6.0", "symfony/config": "^4.4|^5.0|^6.0", "symfony/dependency-injection": "^4.4|^5.0|^6.0", - "symfony/form": "^5.4.21|^6.2.7", + "symfony/form": "^5.4.38|^6.4.6", "symfony/http-kernel": "^5.0|^6.0", "symfony/messenger": "^4.4|^5.0|^6.0", "symfony/doctrine-messenger": "^5.1|^6.0", @@ -56,7 +56,7 @@ "doctrine/orm": "<2.7.4", "symfony/cache": "<5.4", "symfony/dependency-injection": "<4.4", - "symfony/form": "<5.4.21|>=6,<6.2.7", + "symfony/form": "<5.4.38|>=6,<6.4.6", "symfony/http-kernel": "<5", "symfony/messenger": "<4.4", "symfony/property-info": "<5", diff --git a/src/Symfony/Component/Form/Tests/Extension/Core/Type/BaseTypeTestCase.php b/src/Symfony/Component/Form/Tests/Extension/Core/Type/BaseTypeTestCase.php index e86bf9e41ed13..5238e2fd88098 100644 --- a/src/Symfony/Component/Form/Tests/Extension/Core/Type/BaseTypeTestCase.php +++ b/src/Symfony/Component/Form/Tests/Extension/Core/Type/BaseTypeTestCase.php @@ -40,16 +40,6 @@ public function testPassIdAndNameToView() $this->assertEquals('name', $view->vars['full_name']); } - public function testStripLeadingUnderscoresAndDigitsFromId() - { - $view = $this->factory->createNamed('_09name', $this->getTestedType(), null, $this->getTestOptions()) - ->createView(); - - $this->assertEquals('name', $view->vars['id']); - $this->assertEquals('_09name', $view->vars['name']); - $this->assertEquals('_09name', $view->vars['full_name']); - } - public function testPassIdAndNameToViewWithParent() { $view = $this->factory->createNamedBuilder('parent', FormTypeTest::TESTED_TYPE) From bb6975c07078a0d71d8be8c2cb997eb6daff82e4 Mon Sep 17 00:00:00 2001 From: Christian Flothmann Date: Tue, 19 Mar 2024 10:28:31 +0100 Subject: [PATCH 55/81] fix constraint --- src/Symfony/Bridge/Doctrine/composer.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Symfony/Bridge/Doctrine/composer.json b/src/Symfony/Bridge/Doctrine/composer.json index 7cea3001070c4..c5412dd71ba58 100644 --- a/src/Symfony/Bridge/Doctrine/composer.json +++ b/src/Symfony/Bridge/Doctrine/composer.json @@ -30,7 +30,7 @@ "symfony/dependency-injection": "^6.2|^7.0", "symfony/doctrine-messenger": "^5.4|^6.0|^7.0", "symfony/expression-language": "^5.4|^6.0|^7.0", - "symfony/form": "^5.4.38|^6.4.6|^7.0", + "symfony/form": "^5.4.38|^6.4.6|^7.0.6", "symfony/http-kernel": "^6.3|^7.0", "symfony/lock": "^6.3|^7.0", "symfony/messenger": "^5.4|^6.0|^7.0", @@ -55,7 +55,7 @@ "doctrine/orm": "<2.15", "symfony/cache": "<5.4", "symfony/dependency-injection": "<6.2", - "symfony/form": "<5.4.38|>=6,<6.4.6", + "symfony/form": "<5.4.38|>=6,<6.4.6|>=7,<7.0.6", "symfony/http-foundation": "<6.3", "symfony/http-kernel": "<6.2", "symfony/lock": "<6.3", From e8fbd7d9883ed0fbb97b0db7a323ae47388290fd Mon Sep 17 00:00:00 2001 From: Christian Flothmann Date: Tue, 19 Mar 2024 10:40:14 +0100 Subject: [PATCH 56/81] fix merge --- .../Serializer/Tests/Normalizer/ObjectNormalizerTest.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Symfony/Component/Serializer/Tests/Normalizer/ObjectNormalizerTest.php b/src/Symfony/Component/Serializer/Tests/Normalizer/ObjectNormalizerTest.php index 21e91310379cf..8285dd88ee22b 100644 --- a/src/Symfony/Component/Serializer/Tests/Normalizer/ObjectNormalizerTest.php +++ b/src/Symfony/Component/Serializer/Tests/Normalizer/ObjectNormalizerTest.php @@ -854,7 +854,7 @@ public function testSamePropertyAsMethod() public function testSamePropertyAsMethodWithPropertySerializedName() { - $classMetadataFactory = new ClassMetadataFactory(new AnnotationLoader(new AnnotationReader())); + $classMetadataFactory = new ClassMetadataFactory(new AttributeLoader()); $this->normalizer = new ObjectNormalizer($classMetadataFactory, new MetadataAwareNameConverter($classMetadataFactory)); $this->normalizer->setSerializer($this->serializer); @@ -871,7 +871,7 @@ public function testSamePropertyAsMethodWithPropertySerializedName() public function testSamePropertyAsMethodWithMethodSerializedName() { - $classMetadataFactory = new ClassMetadataFactory(new AnnotationLoader(new AnnotationReader())); + $classMetadataFactory = new ClassMetadataFactory(new AttributeLoader()); $this->normalizer = new ObjectNormalizer($classMetadataFactory, new MetadataAwareNameConverter($classMetadataFactory)); $this->normalizer->setSerializer($this->serializer); From 73d769ec55ba178ca79ab90bcdd19390b1529f24 Mon Sep 17 00:00:00 2001 From: Nicolas Grekas Date: Tue, 19 Mar 2024 11:13:26 +0100 Subject: [PATCH 57/81] Make more nullable types explicit --- .../Tests/LazyProxy/PhpDumper/Fixtures/proxy-implem.php | 2 +- .../Tests/Fixtures/ClassWithAnnotatedParameters.php | 4 ++-- src/Symfony/Component/HttpFoundation/ParameterBag.php | 2 +- src/Symfony/Component/Mailer/Transport.php | 6 +++--- .../Messenger/Command/AbstractFailedMessagesCommand.php | 2 +- .../Component/Messenger/Handler/BatchHandlerInterface.php | 2 +- .../Component/Messenger/Retry/RetryStrategyInterface.php | 4 ++-- src/Symfony/Component/Notifier/Bridge/Esendex/CHANGELOG.md | 4 ++-- .../Component/Notifier/Bridge/GoogleChat/CHANGELOG.md | 4 ++-- .../Component/Notifier/Bridge/Mattermost/CHANGELOG.md | 4 ++-- .../PropertyInfo/Extractor/ReflectionExtractor.php | 2 +- .../Authentication/AuthenticationTrustResolverInterface.php | 2 +- .../Security/Core/Authorization/AccessDecisionManager.php | 2 +- .../Component/Security/Http/Firewall/ChannelListener.php | 2 +- src/Symfony/Component/VarDumper/Caster/ReflectionCaster.php | 2 +- .../Component/VarDumper/Tests/Caster/StubCasterTest.php | 2 +- .../Component/VarDumper/Tests/Dumper/CliDumperTest.php | 2 +- .../Component/VarDumper/Tests/Dumper/HtmlDumperTest.php | 2 +- .../functions/dump_data_collector_with_spl_array.phpt | 4 ++-- 19 files changed, 27 insertions(+), 27 deletions(-) diff --git a/src/Symfony/Bridge/ProxyManager/Tests/LazyProxy/PhpDumper/Fixtures/proxy-implem.php b/src/Symfony/Bridge/ProxyManager/Tests/LazyProxy/PhpDumper/Fixtures/proxy-implem.php index 19a9bdd5125d3..c12f1150b6986 100644 --- a/src/Symfony/Bridge/ProxyManager/Tests/LazyProxy/PhpDumper/Fixtures/proxy-implem.php +++ b/src/Symfony/Bridge/ProxyManager/Tests/LazyProxy/PhpDumper/Fixtures/proxy-implem.php @@ -200,7 +200,7 @@ public function __wakeup() { } - public function setProxyInitializer(\Closure $initializer = null)%S + public function setProxyInitializer(%S\Closure $initializer = null)%S { $this->initializer%s = $initializer; } diff --git a/src/Symfony/Component/ErrorHandler/Tests/Fixtures/ClassWithAnnotatedParameters.php b/src/Symfony/Component/ErrorHandler/Tests/Fixtures/ClassWithAnnotatedParameters.php index 2bac262ddb49d..a9cf0dfcb4d2b 100644 --- a/src/Symfony/Component/ErrorHandler/Tests/Fixtures/ClassWithAnnotatedParameters.php +++ b/src/Symfony/Component/ErrorHandler/Tests/Fixtures/ClassWithAnnotatedParameters.php @@ -14,14 +14,14 @@ public function fooMethod(string $foo) /** * @param string $bar parameter not implemented yet */ - public function barMethod(/* string $bar = null */) + public function barMethod(/* ?string $bar = null */) { } /** * @param Quz $quz parameter not implemented yet */ - public function quzMethod(/* Quz $quz = null */) + public function quzMethod(/* ?Quz $quz = null */) { } diff --git a/src/Symfony/Component/HttpFoundation/ParameterBag.php b/src/Symfony/Component/HttpFoundation/ParameterBag.php index e1f89d69ea5e6..b542292bc8bf5 100644 --- a/src/Symfony/Component/HttpFoundation/ParameterBag.php +++ b/src/Symfony/Component/HttpFoundation/ParameterBag.php @@ -39,7 +39,7 @@ public function __construct(array $parameters = []) * * @return array */ - public function all(/* string $key = null */) + public function all(/* ?string $key = null */) { $key = \func_num_args() > 0 ? func_get_arg(0) : null; diff --git a/src/Symfony/Component/Mailer/Transport.php b/src/Symfony/Component/Mailer/Transport.php index ab7b67e4669a0..294442e9261a3 100644 --- a/src/Symfony/Component/Mailer/Transport.php +++ b/src/Symfony/Component/Mailer/Transport.php @@ -63,7 +63,7 @@ class Transport * @param HttpClientInterface|null $client * @param LoggerInterface|null $logger */ - public static function fromDsn(string $dsn/* , EventDispatcherInterface $dispatcher = null, HttpClientInterface $client = null, LoggerInterface $logger = null */): TransportInterface + public static function fromDsn(string $dsn/* , ?EventDispatcherInterface $dispatcher = null, ?HttpClientInterface $client = null, ?LoggerInterface $logger = null */): TransportInterface { $dispatcher = 2 <= \func_num_args() ? func_get_arg(1) : null; $client = 3 <= \func_num_args() ? func_get_arg(2) : null; @@ -79,7 +79,7 @@ public static function fromDsn(string $dsn/* , EventDispatcherInterface $dispatc * @param HttpClientInterface|null $client * @param LoggerInterface|null $logger */ - public static function fromDsns(array $dsns/* , EventDispatcherInterface $dispatcher = null, HttpClientInterface $client = null, LoggerInterface $logger = null */): TransportInterface + public static function fromDsns(array $dsns/* , ?EventDispatcherInterface $dispatcher = null, ?HttpClientInterface $client = null, ?LoggerInterface $logger = null */): TransportInterface { $dispatcher = 2 <= \func_num_args() ? func_get_arg(1) : null; $client = 3 <= \func_num_args() ? func_get_arg(2) : null; @@ -183,7 +183,7 @@ public function fromDsnObject(Dsn $dsn): TransportInterface * * @return \Traversable */ - public static function getDefaultFactories(/* EventDispatcherInterface $dispatcher = null, HttpClientInterface $client = null, LoggerInterface $logger = null */): iterable + public static function getDefaultFactories(/* ?EventDispatcherInterface $dispatcher = null, ?HttpClientInterface $client = null, ?LoggerInterface $logger = null */): iterable { $dispatcher = 1 <= \func_num_args() ? func_get_arg(0) : null; $client = 2 <= \func_num_args() ? func_get_arg(1) : null; diff --git a/src/Symfony/Component/Messenger/Command/AbstractFailedMessagesCommand.php b/src/Symfony/Component/Messenger/Command/AbstractFailedMessagesCommand.php index 7a6fc212a48af..43ad833728d3d 100644 --- a/src/Symfony/Component/Messenger/Command/AbstractFailedMessagesCommand.php +++ b/src/Symfony/Component/Messenger/Command/AbstractFailedMessagesCommand.php @@ -185,7 +185,7 @@ protected function printPendingMessagesMessage(ReceiverInterface $receiver, Symf /** * @param string|null $name */ - protected function getReceiver(/* string $name = null */): ReceiverInterface + protected function getReceiver(/* ?string $name = null */): ReceiverInterface { if (1 > \func_num_args() && __CLASS__ !== static::class && __CLASS__ !== (new \ReflectionMethod($this, __FUNCTION__))->getDeclaringClass()->getName() && !$this instanceof \PHPUnit\Framework\MockObject\MockObject && !$this instanceof \Prophecy\Prophecy\ProphecySubjectInterface && !$this instanceof \Mockery\MockInterface) { trigger_deprecation('symfony/messenger', '5.3', 'The "%s()" method will have a new "string $name" argument in version 6.0, not defining it is deprecated.', __METHOD__); diff --git a/src/Symfony/Component/Messenger/Handler/BatchHandlerInterface.php b/src/Symfony/Component/Messenger/Handler/BatchHandlerInterface.php index a2fce4e1bb1e2..42a8590ee70a8 100644 --- a/src/Symfony/Component/Messenger/Handler/BatchHandlerInterface.php +++ b/src/Symfony/Component/Messenger/Handler/BatchHandlerInterface.php @@ -23,7 +23,7 @@ interface BatchHandlerInterface * @return mixed The number of pending messages in the batch if $ack is not null, * the result from handling the message otherwise */ - // public function __invoke(object $message, Acknowledger $ack = null): mixed; + // public function __invoke(object $message, ?Acknowledger $ack = null): mixed; /** * Flushes any pending buffers. diff --git a/src/Symfony/Component/Messenger/Retry/RetryStrategyInterface.php b/src/Symfony/Component/Messenger/Retry/RetryStrategyInterface.php index 52c294bee2c66..7abce0df41477 100644 --- a/src/Symfony/Component/Messenger/Retry/RetryStrategyInterface.php +++ b/src/Symfony/Component/Messenger/Retry/RetryStrategyInterface.php @@ -23,12 +23,12 @@ interface RetryStrategyInterface /** * @param \Throwable|null $throwable The cause of the failed handling */ - public function isRetryable(Envelope $message/* , \Throwable $throwable = null */): bool; + public function isRetryable(Envelope $message/* , ?\Throwable $throwable = null */): bool; /** * @param \Throwable|null $throwable The cause of the failed handling * * @return int The time to delay/wait in milliseconds */ - public function getWaitingTime(Envelope $message/* , \Throwable $throwable = null */): int; + public function getWaitingTime(Envelope $message/* , ?\Throwable $throwable = null */): int; } diff --git a/src/Symfony/Component/Notifier/Bridge/Esendex/CHANGELOG.md b/src/Symfony/Component/Notifier/Bridge/Esendex/CHANGELOG.md index 5dd9b64036de1..de5e5458ed697 100644 --- a/src/Symfony/Component/Notifier/Bridge/Esendex/CHANGELOG.md +++ b/src/Symfony/Component/Notifier/Bridge/Esendex/CHANGELOG.md @@ -11,9 +11,9 @@ CHANGELOG * The bridge is not marked as `@experimental` anymore * [BC BREAK] Change signature of `EsendexTransport::__construct()` method from: - `public function __construct(string $token, string $accountReference, string $from, HttpClientInterface $client = null, EventDispatcherInterface $dispatcher = null)` + `public function __construct(string $token, string $accountReference, string $from, ?HttpClientInterface $client = null, ?EventDispatcherInterface $dispatcher = null)` to: - `public function __construct(string $email, string $password, string $accountReference, string $from, HttpClientInterface $client = null, EventDispatcherInterface $dispatcher = null)` + `public function __construct(string $email, string $password, string $accountReference, string $from, ?HttpClientInterface $client = null, ?EventDispatcherInterface $dispatcher = null)` 5.2.0 ----- diff --git a/src/Symfony/Component/Notifier/Bridge/GoogleChat/CHANGELOG.md b/src/Symfony/Component/Notifier/Bridge/GoogleChat/CHANGELOG.md index 5759f578770fe..9209c3c30650e 100644 --- a/src/Symfony/Component/Notifier/Bridge/GoogleChat/CHANGELOG.md +++ b/src/Symfony/Component/Notifier/Bridge/GoogleChat/CHANGELOG.md @@ -7,9 +7,9 @@ CHANGELOG * The bridge is not marked as `@experimental` anymore * [BC BREAK] Remove `GoogleChatTransport::setThreadKey()` method, this parameter should now be provided via the constructor, which has changed from: - `__construct(string $space, string $accessKey, string $accessToken, HttpClientInterface $client = null, EventDispatcherInterface $dispatcher = null)` + `__construct(string $space, string $accessKey, string $accessToken, ?HttpClientInterface $client = null, ?EventDispatcherInterface $dispatcher = null)` to: - `__construct(string $space, string $accessKey, string $accessToken, string $threadKey = null, HttpClientInterface $client = null, EventDispatcherInterface $dispatcher = null)` + `__construct(string $space, string $accessKey, string $accessToken, ?string $threadKey = null, ?HttpClientInterface $client = null, ?EventDispatcherInterface $dispatcher = null)` * [BC BREAK] Rename the parameter `threadKey` to `thread_key` in DSN 5.2.0 diff --git a/src/Symfony/Component/Notifier/Bridge/Mattermost/CHANGELOG.md b/src/Symfony/Component/Notifier/Bridge/Mattermost/CHANGELOG.md index 8e154d13f0b85..39bc172f8cb7b 100644 --- a/src/Symfony/Component/Notifier/Bridge/Mattermost/CHANGELOG.md +++ b/src/Symfony/Component/Notifier/Bridge/Mattermost/CHANGELOG.md @@ -6,9 +6,9 @@ CHANGELOG * The bridge is not marked as `@experimental` anymore * [BC BREAK] Change signature of `MattermostTransport::__construct()` method from: - `public function __construct(string $token, string $channel, HttpClientInterface $client = null, EventDispatcherInterface $dispatcher = null, string $path = null)` + `public function __construct(string $token, string $channel, ?HttpClientInterface $client = null, ?EventDispatcherInterface $dispatcher = null, ?string $path = null)` to: - `public function __construct(string $token, string $channel, ?string $path = null, HttpClientInterface $client = null, EventDispatcherInterface $dispatcher = null)` + `public function __construct(string $token, string $channel, ?string $path = null, ?HttpClientInterface $client = null, ?EventDispatcherInterface $dispatcher = null)` 5.1.0 ----- diff --git a/src/Symfony/Component/PropertyInfo/Extractor/ReflectionExtractor.php b/src/Symfony/Component/PropertyInfo/Extractor/ReflectionExtractor.php index 29a91f904041f..a4f2cc9f5e028 100644 --- a/src/Symfony/Component/PropertyInfo/Extractor/ReflectionExtractor.php +++ b/src/Symfony/Component/PropertyInfo/Extractor/ReflectionExtractor.php @@ -681,7 +681,7 @@ private function getMutatorMethod(string $class, string $property): ?array continue; } - // Parameter can be optional to allow things like: method(array $foo = null) + // Parameter can be optional to allow things like: method(?array $foo = null) if ($reflectionMethod->getNumberOfParameters() >= 1) { return [$reflectionMethod, $prefix]; } diff --git a/src/Symfony/Component/Security/Core/Authentication/AuthenticationTrustResolverInterface.php b/src/Symfony/Component/Security/Core/Authentication/AuthenticationTrustResolverInterface.php index ccacbe9df8214..0e63d2fa0620c 100644 --- a/src/Symfony/Component/Security/Core/Authentication/AuthenticationTrustResolverInterface.php +++ b/src/Symfony/Component/Security/Core/Authentication/AuthenticationTrustResolverInterface.php @@ -18,7 +18,7 @@ * * @author Johannes M. Schmitt * - * @method bool isAuthenticated(TokenInterface $token = null) + * @method bool isAuthenticated(?TokenInterface $token = null) */ interface AuthenticationTrustResolverInterface { diff --git a/src/Symfony/Component/Security/Core/Authorization/AccessDecisionManager.php b/src/Symfony/Component/Security/Core/Authorization/AccessDecisionManager.php index cdb2bc2f9e633..cc59035bc2533 100644 --- a/src/Symfony/Component/Security/Core/Authorization/AccessDecisionManager.php +++ b/src/Symfony/Component/Security/Core/Authorization/AccessDecisionManager.php @@ -68,7 +68,7 @@ class AccessDecisionManager implements AccessDecisionManagerInterface * * @throws \InvalidArgumentException */ - public function __construct(iterable $voters = [], /* AccessDecisionStrategyInterface */ $strategy = null) + public function __construct(iterable $voters = [], /* ?AccessDecisionStrategyInterface */ $strategy = null) { $this->voters = $voters; if (\is_string($strategy)) { diff --git a/src/Symfony/Component/Security/Http/Firewall/ChannelListener.php b/src/Symfony/Component/Security/Http/Firewall/ChannelListener.php index 986f213ce9a65..5ee144b29563d 100644 --- a/src/Symfony/Component/Security/Http/Firewall/ChannelListener.php +++ b/src/Symfony/Component/Security/Http/Firewall/ChannelListener.php @@ -34,7 +34,7 @@ class ChannelListener extends AbstractListener private $httpPort; private $httpsPort; - public function __construct(AccessMapInterface $map, /* LoggerInterface */ $logger = null, /* int */ $httpPort = 80, /* int */ $httpsPort = 443) + public function __construct(AccessMapInterface $map, /* ?LoggerInterface */ $logger = null, /* int */ $httpPort = 80, /* int */ $httpsPort = 443) { if ($logger instanceof AuthenticationEntryPointInterface) { trigger_deprecation('symfony/security-http', '5.4', 'The "$authenticationEntryPoint" argument of "%s()" is deprecated.', __METHOD__); diff --git a/src/Symfony/Component/VarDumper/Caster/ReflectionCaster.php b/src/Symfony/Component/VarDumper/Caster/ReflectionCaster.php index b373a6fa5fad6..6f1b8f2f25a5e 100644 --- a/src/Symfony/Component/VarDumper/Caster/ReflectionCaster.php +++ b/src/Symfony/Component/VarDumper/Caster/ReflectionCaster.php @@ -368,7 +368,7 @@ public static function getSignature(array $a) if (!$type instanceof \ReflectionNamedType) { $signature .= $type.' '; } else { - if (!$param->isOptional() && $param->allowsNull() && 'mixed' !== $type->getName()) { + if ($param->allowsNull() && 'mixed' !== $type->getName()) { $signature .= '?'; } $signature .= substr(strrchr('\\'.$type->getName(), '\\'), 1).' '; diff --git a/src/Symfony/Component/VarDumper/Tests/Caster/StubCasterTest.php b/src/Symfony/Component/VarDumper/Tests/Caster/StubCasterTest.php index cd6876cdff22f..04d22816bb3ec 100644 --- a/src/Symfony/Component/VarDumper/Tests/Caster/StubCasterTest.php +++ b/src/Symfony/Component/VarDumper/Tests/Caster/StubCasterTest.php @@ -141,7 +141,7 @@ public function testClassStub() $expectedDump = <<<'EODUMP' array:1 [ - 0 => "hello(?stdClass $a, stdClass $b = null)" + 0 => "hello(?stdClass $a, ?stdClass $b = null)" ] EODUMP; diff --git a/src/Symfony/Component/VarDumper/Tests/Dumper/CliDumperTest.php b/src/Symfony/Component/VarDumper/Tests/Dumper/CliDumperTest.php index dba799c55cfe3..918f5f73d8757 100644 --- a/src/Symfony/Component/VarDumper/Tests/Dumper/CliDumperTest.php +++ b/src/Symfony/Component/VarDumper/Tests/Dumper/CliDumperTest.php @@ -87,7 +87,7 @@ public function testGet() +foo: ""…3 +"bar": "bar" } - "closure" => Closure(\$a, PDO &\$b = null) {#%d + "closure" => Closure(\$a, ?PDO &\$b = null) {#%d class: "Symfony\Component\VarDumper\Tests\Dumper\CliDumperTest" this: Symfony\Component\VarDumper\Tests\Dumper\CliDumperTest {#%d …} file: "%s%eTests%eFixtures%edumb-var.php" diff --git a/src/Symfony/Component/VarDumper/Tests/Dumper/HtmlDumperTest.php b/src/Symfony/Component/VarDumper/Tests/Dumper/HtmlDumperTest.php index 8c9592e47b304..5f827c45fe765 100644 --- a/src/Symfony/Component/VarDumper/Tests/Dumper/HtmlDumperTest.php +++ b/src/Symfony/Component/VarDumper/Tests/Dumper/HtmlDumperTest.php @@ -83,7 +83,7 @@ public function testGet() +foo: "foo" +"bar": "bar" } - "closure" => Closure(\$a, PDO &\$b = null) {#%d + "closure" => Closure(\$a, ?PDO &\$b = null) {#%d class: "Symfony\Component\VarDumper\Tests\Dumper\HtmlDumperTest" this: Date: Tue, 19 Mar 2024 13:22:59 +0100 Subject: [PATCH 60/81] [Serializer] Fix merge --- ...ertyAsMethodWithMethodSerializedNameDummy.php | 16 ++++------------ ...tyAsMethodWithPropertySerializedNameDummy.php | 16 ++++------------ .../Tests/Normalizer/ObjectNormalizerTest.php | 4 ++-- 3 files changed, 10 insertions(+), 26 deletions(-) diff --git a/src/Symfony/Component/Serializer/Tests/Fixtures/SamePropertyAsMethodWithMethodSerializedNameDummy.php b/src/Symfony/Component/Serializer/Tests/Fixtures/SamePropertyAsMethodWithMethodSerializedNameDummy.php index b4cf205fd57c8..203118885853e 100644 --- a/src/Symfony/Component/Serializer/Tests/Fixtures/SamePropertyAsMethodWithMethodSerializedNameDummy.php +++ b/src/Symfony/Component/Serializer/Tests/Fixtures/SamePropertyAsMethodWithMethodSerializedNameDummy.php @@ -28,33 +28,25 @@ public function __construct($freeTrial, $hasSubscribe, $getReady, $isActive) $this->isActive = $isActive; } - /** - * @SerializedName("free_trial_method") - */ + #[SerializedName('free_trial_method')] public function getFreeTrial() { return $this->freeTrial; } - /** - * @SerializedName("has_subscribe_method") - */ + #[SerializedName('has_subscribe_method')] public function hasSubscribe() { return $this->hasSubscribe; } - /** - * @SerializedName("get_ready_method") - */ + #[SerializedName('get_ready_method')] public function getReady() { return $this->getReady; } - /** - * @SerializedName("is_active_method") - */ + #[SerializedName('is_active_method')] public function isActive() { return $this->isActive; diff --git a/src/Symfony/Component/Serializer/Tests/Fixtures/SamePropertyAsMethodWithPropertySerializedNameDummy.php b/src/Symfony/Component/Serializer/Tests/Fixtures/SamePropertyAsMethodWithPropertySerializedNameDummy.php index 04dc64a3c71c0..0b681934f2fab 100644 --- a/src/Symfony/Component/Serializer/Tests/Fixtures/SamePropertyAsMethodWithPropertySerializedNameDummy.php +++ b/src/Symfony/Component/Serializer/Tests/Fixtures/SamePropertyAsMethodWithPropertySerializedNameDummy.php @@ -15,24 +15,16 @@ class SamePropertyAsMethodWithPropertySerializedNameDummy { - /** - * @SerializedName("free_trial_property") - */ + #[SerializedName('free_trial_property')] private $freeTrial; - /** - * @SerializedName("has_subscribe_property") - */ + #[SerializedName('has_subscribe_property')] private $hasSubscribe; - /** - * @SerializedName("get_ready_property") - */ + #[SerializedName('get_ready_property')] private $getReady; - /** - * @SerializedName("is_active_property") - */ + #[SerializedName('is_active_property')] private $isActive; public function __construct($freeTrial, $hasSubscribe, $getReady, $isActive) diff --git a/src/Symfony/Component/Serializer/Tests/Normalizer/ObjectNormalizerTest.php b/src/Symfony/Component/Serializer/Tests/Normalizer/ObjectNormalizerTest.php index 496d76a2a945b..10b8b3c96d1b4 100644 --- a/src/Symfony/Component/Serializer/Tests/Normalizer/ObjectNormalizerTest.php +++ b/src/Symfony/Component/Serializer/Tests/Normalizer/ObjectNormalizerTest.php @@ -869,7 +869,7 @@ public function testSamePropertyAsMethod() public function testSamePropertyAsMethodWithPropertySerializedName() { - $classMetadataFactory = new ClassMetadataFactory(new AnnotationLoader(new AnnotationReader())); + $classMetadataFactory = new ClassMetadataFactory(new AttributeLoader()); $this->normalizer = new ObjectNormalizer($classMetadataFactory, new MetadataAwareNameConverter($classMetadataFactory)); $this->normalizer->setSerializer($this->serializer); @@ -886,7 +886,7 @@ public function testSamePropertyAsMethodWithPropertySerializedName() public function testSamePropertyAsMethodWithMethodSerializedName() { - $classMetadataFactory = new ClassMetadataFactory(new AnnotationLoader(new AnnotationReader())); + $classMetadataFactory = new ClassMetadataFactory(new AttributeLoader()); $this->normalizer = new ObjectNormalizer($classMetadataFactory, new MetadataAwareNameConverter($classMetadataFactory)); $this->normalizer->setSerializer($this->serializer); From e8e26269fc2671753215c9834b76e3600287848a Mon Sep 17 00:00:00 2001 From: Nicolas Grekas Date: Wed, 20 Mar 2024 15:00:29 +0100 Subject: [PATCH 61/81] [HttpClient] Test with guzzle promises v2 --- composer.json | 2 +- src/Symfony/Component/HttpClient/composer.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/composer.json b/composer.json index f9bc553e63b86..9bc012d6cee49 100644 --- a/composer.json +++ b/composer.json @@ -130,7 +130,7 @@ "doctrine/data-fixtures": "^1.1", "doctrine/dbal": "^2.13.1|^3.0", "doctrine/orm": "^2.7.4", - "guzzlehttp/promises": "^1.4", + "guzzlehttp/promises": "^1.4|^2.0", "masterminds/html5": "^2.6", "monolog/monolog": "^1.25.1|^2", "nyholm/psr7": "^1.0", diff --git a/src/Symfony/Component/HttpClient/composer.json b/src/Symfony/Component/HttpClient/composer.json index 7f546b3a23981..735d69a3afd64 100644 --- a/src/Symfony/Component/HttpClient/composer.json +++ b/src/Symfony/Component/HttpClient/composer.json @@ -35,7 +35,7 @@ "amphp/http-client": "^4.2.1", "amphp/http-tunnel": "^1.0", "amphp/socket": "^1.1", - "guzzlehttp/promises": "^1.4", + "guzzlehttp/promises": "^1.4|^2.0", "nyholm/psr7": "^1.0", "php-http/httplug": "^1.0|^2.0", "php-http/message-factory": "^1.0", From ec8d2fbfe98334d7c98c1af9ba6f87afc700bba9 Mon Sep 17 00:00:00 2001 From: Christian Flothmann Date: Wed, 20 Mar 2024 21:53:38 +0100 Subject: [PATCH 62/81] fix tests --- src/Symfony/Component/VarExporter/composer.json | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/Symfony/Component/VarExporter/composer.json b/src/Symfony/Component/VarExporter/composer.json index 3498d15cc33c3..e7b0fb03922d9 100644 --- a/src/Symfony/Component/VarExporter/composer.json +++ b/src/Symfony/Component/VarExporter/composer.json @@ -20,6 +20,8 @@ "symfony/deprecation-contracts": "^2.5|^3" }, "require-dev": { + "symfony/property-access": "^6.4|^7.0", + "symfony/serializer": "^6.4|^7.0", "symfony/var-dumper": "^5.4|^6.0|^7.0" }, "autoload": { From 7d8f1950695ef023b4fec6d35c36879b84b69e64 Mon Sep 17 00:00:00 2001 From: Christian Flothmann Date: Thu, 21 Mar 2024 08:10:33 +0100 Subject: [PATCH 63/81] use local PHP web server to test HTTP stream wrappers --- .../Component/Mime/Tests/Fixtures/web/index.php | 1 + .../Tests/Fixtures/web/logo_symfony_header.png | Bin 0 -> 1613 bytes .../Component/Mime/Tests/Part/DataPartTest.php | 16 ++++++++++++---- src/Symfony/Component/Mime/composer.json | 1 + 4 files changed, 14 insertions(+), 4 deletions(-) create mode 100644 src/Symfony/Component/Mime/Tests/Fixtures/web/index.php create mode 100644 src/Symfony/Component/Mime/Tests/Fixtures/web/logo_symfony_header.png diff --git a/src/Symfony/Component/Mime/Tests/Fixtures/web/index.php b/src/Symfony/Component/Mime/Tests/Fixtures/web/index.php new file mode 100644 index 0000000000000..b3d9bbc7f3711 --- /dev/null +++ b/src/Symfony/Component/Mime/Tests/Fixtures/web/index.php @@ -0,0 +1 @@ +P+)L?kDsr<&)@GO8iI-d00p^8L_t(|+TEM!dZRiFh9%=g7;pD~ zwI}6ZzB(8;nKJD&yuYTMVCl0KFQjyi)<#6Mp6LE4>r(;ITc-QME|w#UrF)|0T>4~T zx*aTKKz4L9bSh)wM0a8?U*qUDa4fIjneM@q%4{5WD0L7g3u)_D4#1)Wz1Bk z#1XoAW&(90lBP>34+4R|-LX)PxvY3eXH}Xo370YbN`T`@Q%ir}H(l%KTI8s4771lT zpB1?|`u1-KPNgMGL`v7AaX>?QV);h}Po-tvx??a?toF9PET!S#o2BuuZ6+^5=z~p|JQ9!92I2 zVF)gI9S-Ad))Rrad6S=ea-9Rrkl$>&(h!J%)bLcQ*Q(6|yL~q10x~xOr49#F=YSI# zf?Xpcb5(&5tGbiuh`?+GIPTfx(ZaO3lN`4@L)UKTn4rdM;{QF3A5U5)6RW>YMEv?8 zd7$^8C#y)=P!(6fAES7~HR*k|KBK@k>$(>;+h(nPKqi!D`g>_y=W?6VY4d~xyHhye z8S`d4O-q_Gas_fWvzp+0rY(0<6Od)M2N+LPYg2eoI;j4Fj?=5(K81`n_~06PM2-mu zH-8k&8G7NNf?(4WlCIXL&lznyn<#0{6Y!yjrWQ2Hz>o7BNdP0H;9>yv^7R)DIQq`u_J7Wn&DcA&Iq?J&Aio0P|C%2Cpoi{U9``ryk z5KQk27W$0TU!g!S0@l;G`ym~{1`TBQ*_1P=3mRqZHLAv1T`5?97A#%Cwi;EiPR)vh zY&82*b2%Z=8E61pb9zQfUKwFG5)A9oHc#wf_hM%B)L2dkbOL`lZXL zy#8~>{^@POh>Ll)5osV8trGQA>ls9BBQq@Z$kYefhOAl*o9_s=C?b5WxUU4yjde^y zmoUy~KfapD%@!Ix?hgf1>g=U6j|9Vd8y+{TQ7LDb@g0gZ7r0m|-xrJ@Fo=T-L%|eV z>%$o8;aiw=Sc!rdt<9X8(>bP0eM2xbCed2Egd7_RMmVRhFXHn!z_zp301@&O?oz%b zn517*W5L`Bk2VT?L`H{K z15CyzjG#L20J#yIpo7{93;0j{d`ZSGRU6VAJ{E2T2Zm#vZ9nHWuD*uQm3MYoN;?sw zxw{Qn=o*v}5i@=BjhsPz_q;cwJx5mbBDk&mB^0c8k{ahoKhXPz`?%ZrEu{ZiGa|w? zrFB(tFNR3j<*Kh~sRb$VV~njs z@oR+F_1X~e>f@(@bwyn`6mUuXD%{!r0{rzcR?3)nzY?eMO75qD^{l`11@WNXtDq3V zVwo=Edh3$QImy!fU`W2XT+m&UyrCPzW)1~}8ES8g(*JX>zgGGWdRYnkHtkA|00000 LNkvXXu0mjf1C89g literal 0 HcmV?d00001 diff --git a/src/Symfony/Component/Mime/Tests/Part/DataPartTest.php b/src/Symfony/Component/Mime/Tests/Part/DataPartTest.php index 34a379c2a983f..d0a692761fdf7 100644 --- a/src/Symfony/Component/Mime/Tests/Part/DataPartTest.php +++ b/src/Symfony/Component/Mime/Tests/Part/DataPartTest.php @@ -18,6 +18,8 @@ use Symfony\Component\Mime\Header\ParameterizedHeader; use Symfony\Component\Mime\Header\UnstructuredHeader; use Symfony\Component\Mime\Part\DataPart; +use Symfony\Component\Process\PhpExecutableFinder; +use Symfony\Component\Process\Process; class DataPartTest extends TestCase { @@ -134,16 +136,22 @@ public function testFromPathWithNotAFile() DataPart::fromPath(__DIR__.'/../Fixtures/mimetypes/'); } - /** - * @group network - */ public function testFromPathWithUrl() { if (!\in_array('https', stream_get_wrappers())) { $this->markTestSkipped('"https" stream wrapper is not enabled.'); } - $p = DataPart::fromPath($file = 'https://symfony.com/images/common/logo/logo_symfony_header.png'); + $finder = new PhpExecutableFinder(); + $process = new Process(array_merge([$finder->find(false)], $finder->findArguments(), ['-dopcache.enable=0', '-dvariables_order=EGPCS', '-S', '127.0.0.1:8057'])); + $process->setWorkingDirectory(__DIR__.'/../Fixtures/web'); + $process->start(); + + do { + usleep(50000); + } while (!@fopen('http://127.0.0.1:8057', 'r')); + + $p = DataPart::fromPath($file = 'http://localhost:8057/logo_symfony_header.png'); $content = file_get_contents($file); $this->assertEquals($content, $p->getBody()); $maxLineLength = 76; diff --git a/src/Symfony/Component/Mime/composer.json b/src/Symfony/Component/Mime/composer.json index 11823efc347dd..3bb609558274b 100644 --- a/src/Symfony/Component/Mime/composer.json +++ b/src/Symfony/Component/Mime/composer.json @@ -26,6 +26,7 @@ "egulias/email-validator": "^2.1.10|^3.1|^4", "phpdocumentor/reflection-docblock": "^3.0|^4.0|^5.0", "symfony/dependency-injection": "^4.4|^5.0|^6.0", + "symfony/process": "^5.4|^6.4", "symfony/property-access": "^4.4|^5.1|^6.0", "symfony/property-info": "^4.4|^5.1|^6.0", "symfony/serializer": "^5.4.35|~6.3.12|^6.4.3" From ab92485dc945fd0d80477d92d8897ce2e8b825fd Mon Sep 17 00:00:00 2001 From: Christian Flothmann Date: Thu, 21 Mar 2024 08:20:43 +0100 Subject: [PATCH 64/81] add test using deprecated reflection doc block feature to legacy group --- .../Tests/Extractor/PhpDocExtractorTest.php | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/src/Symfony/Component/PropertyInfo/Tests/Extractor/PhpDocExtractorTest.php b/src/Symfony/Component/PropertyInfo/Tests/Extractor/PhpDocExtractorTest.php index 8ec2a567e984a..f71664d5a3547 100644 --- a/src/Symfony/Component/PropertyInfo/Tests/Extractor/PhpDocExtractorTest.php +++ b/src/Symfony/Component/PropertyInfo/Tests/Extractor/PhpDocExtractorTest.php @@ -58,7 +58,6 @@ public static function invalidTypesProvider() return [ 'pub' => ['pub', null, null], 'stat' => ['stat', null, null], - 'foo' => ['foo', self::isPhpDocumentorV5() ? 'Foo.' : null, null], 'bar' => ['bar', self::isPhpDocumentorV5() ? 'Bar.' : null, null], ]; } @@ -73,6 +72,16 @@ public function testInvalid($property, $shortDescription, $longDescription) $this->assertSame($longDescription, $this->extractor->getLongDescription('Symfony\Component\PropertyInfo\Tests\Fixtures\InvalidDummy', $property)); } + /** + * @group legacy + */ + public function testEmptyParamAnnotation() + { + $this->assertNull($this->extractor->getTypes('Symfony\Component\PropertyInfo\Tests\Fixtures\InvalidDummy', 'foo')); + $this->assertSame(self::isPhpDocumentorV5() ? 'Foo.' : null, $this->extractor->getShortDescription('Symfony\Component\PropertyInfo\Tests\Fixtures\InvalidDummy', 'foo')); + $this->assertNull($this->extractor->getLongDescription('Symfony\Component\PropertyInfo\Tests\Fixtures\InvalidDummy', 'foo')); + } + /** * @dataProvider typesWithNoPrefixesProvider */ From d232026d5dfc52ee71bf708c17d65f1af189ecc1 Mon Sep 17 00:00:00 2001 From: Christian Flothmann Date: Thu, 21 Mar 2024 08:49:09 +0100 Subject: [PATCH 65/81] preserve the file modification time when mirroring directories --- src/Symfony/Component/Filesystem/Filesystem.php | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/Symfony/Component/Filesystem/Filesystem.php b/src/Symfony/Component/Filesystem/Filesystem.php index 4df06aed115db..909810f98a959 100644 --- a/src/Symfony/Component/Filesystem/Filesystem.php +++ b/src/Symfony/Component/Filesystem/Filesystem.php @@ -72,6 +72,9 @@ public function copy(string $originFile, string $targetFile, bool $overwriteNewe // Like `cp`, preserve executable permission bits self::box('chmod', $targetFile, fileperms($targetFile) | (fileperms($originFile) & 0111)); + // Like `cp`, preserve the file modification time + self::box('touch', $targetFile, filemtime($originFile)); + if ($bytesCopied !== $bytesOrigin = filesize($originFile)) { throw new IOException(sprintf('Failed to copy the whole content of "%s" to "%s" (%g of %g bytes copied).', $originFile, $targetFile, $bytesCopied, $bytesOrigin), 0, null, $originFile); } From fd95a8f0159ba229f3099259933633a2c83dcce6 Mon Sep 17 00:00:00 2001 From: Tac Tacelosky Date: Mon, 18 Mar 2024 16:14:32 -0600 Subject: [PATCH 66/81] [Yaml] prefix examples with # --- .../Config/Definition/Dumper/YamlReferenceDumper.php | 9 +++++---- .../Tests/Definition/Dumper/YamlReferenceDumperTest.php | 4 ++-- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/src/Symfony/Component/Config/Definition/Dumper/YamlReferenceDumper.php b/src/Symfony/Component/Config/Definition/Dumper/YamlReferenceDumper.php index 4f720aa97f9f4..c6b08a53616eb 100644 --- a/src/Symfony/Component/Config/Definition/Dumper/YamlReferenceDumper.php +++ b/src/Symfony/Component/Config/Definition/Dumper/YamlReferenceDumper.php @@ -170,7 +170,7 @@ private function writeNode(NodeInterface $node, ?NodeInterface $parentNode = nul $this->writeLine('# '.$message.':', $depth * 4 + 4); - $this->writeArray(array_map(Inline::dump(...), $example), $depth + 1); + $this->writeArray(array_map(Inline::dump(...), $example), $depth + 1, true); } if ($children) { @@ -191,7 +191,7 @@ private function writeLine(string $text, int $indent = 0): void $this->reference .= sprintf($format, $text)."\n"; } - private function writeArray(array $array, int $depth): void + private function writeArray(array $array, int $depth, bool $asComment = false): void { $isIndexed = array_is_list($array); @@ -201,11 +201,12 @@ private function writeArray(array $array, int $depth): void } else { $val = $value; } + $prefix = $asComment ? '# ' : ''; if ($isIndexed) { - $this->writeLine('- '.$val, $depth * 4); + $this->writeLine($prefix.'- '.$val, $depth * 4); } else { - $this->writeLine(sprintf('%-20s %s', $key.':', $val), $depth * 4); + $this->writeLine($prefix.sprintf('%-20s %s', $key.':', $val), $depth * 4); } if (\is_array($value)) { diff --git a/src/Symfony/Component/Config/Tests/Definition/Dumper/YamlReferenceDumperTest.php b/src/Symfony/Component/Config/Tests/Definition/Dumper/YamlReferenceDumperTest.php index 18ad445c3ef5d..6083cefc35263 100644 --- a/src/Symfony/Component/Config/Tests/Definition/Dumper/YamlReferenceDumperTest.php +++ b/src/Symfony/Component/Config/Tests/Definition/Dumper/YamlReferenceDumperTest.php @@ -117,8 +117,8 @@ enum: ~ # One of "this"; "that"; Symfony\Component\Config\Tests\ variable: # Examples: - - foo - - bar + # - foo + # - bar parameters: # Prototype: Parameter name From 4d4b552b79d353820746a3d15a25f147a62168a1 Mon Sep 17 00:00:00 2001 From: MatTheCat Date: Fri, 22 Mar 2024 10:44:23 +0100 Subject: [PATCH 67/81] [Config] Fix `YamlReferenceDumper` handling of array examples --- .../Definition/Dumper/YamlReferenceDumper.php | 24 +++++++------------ .../Dumper/XmlReferenceDumperTest.php | 2 ++ .../Dumper/YamlReferenceDumperTest.php | 11 ++++++--- .../Configuration/ExampleConfiguration.php | 3 +++ 4 files changed, 22 insertions(+), 18 deletions(-) diff --git a/src/Symfony/Component/Config/Definition/Dumper/YamlReferenceDumper.php b/src/Symfony/Component/Config/Definition/Dumper/YamlReferenceDumper.php index 718a1ae539ccd..c762e22a05d86 100644 --- a/src/Symfony/Component/Config/Definition/Dumper/YamlReferenceDumper.php +++ b/src/Symfony/Component/Config/Definition/Dumper/YamlReferenceDumper.php @@ -18,7 +18,6 @@ use Symfony\Component\Config\Definition\NodeInterface; use Symfony\Component\Config\Definition\PrototypedArrayNode; use Symfony\Component\Config\Definition\ScalarNode; -use Symfony\Component\Config\Definition\VariableNode; use Symfony\Component\Yaml\Inline; /** @@ -90,19 +89,12 @@ private function writeNode(NodeInterface $node, ?NodeInterface $parentNode = nul $children = $this->getPrototypeChildren($node); } - if (!$children) { - if ($node->hasDefaultValue() && \count($defaultArray = $node->getDefaultValue())) { - $default = ''; - } elseif (!\is_array($example)) { - $default = '[]'; - } + if (!$children && !($node->hasDefaultValue() && \count($defaultArray = $node->getDefaultValue()))) { + $default = '[]'; } } elseif ($node instanceof EnumNode) { $comments[] = 'One of '.implode('; ', array_map('json_encode', $node->getValues())); $default = $node->hasDefaultValue() ? Inline::dump($node->getDefaultValue()) : '~'; - } elseif (VariableNode::class === \get_class($node) && \is_array($example)) { - // If there is an array example, we are sure we dont need to print a default value - $default = ''; } else { $default = '~'; @@ -170,7 +162,7 @@ private function writeNode(NodeInterface $node, ?NodeInterface $parentNode = nul $this->writeLine('# '.$message.':', $depth * 4 + 4); - $this->writeArray(array_map([Inline::class, 'dump'], $example), $depth + 1); + $this->writeArray(array_map([Inline::class, 'dump'], $example), $depth + 1, true); } if ($children) { @@ -191,7 +183,7 @@ private function writeLine(string $text, int $indent = 0) $this->reference .= sprintf($format, $text)."\n"; } - private function writeArray(array $array, int $depth) + private function writeArray(array $array, int $depth, bool $asComment = false) { $isIndexed = array_values($array) === $array; @@ -202,14 +194,16 @@ private function writeArray(array $array, int $depth) $val = $value; } + $prefix = $asComment ? '# ' : ''; + if ($isIndexed) { - $this->writeLine('- '.$val, $depth * 4); + $this->writeLine($prefix.'- '.$val, $depth * 4); } else { - $this->writeLine(sprintf('%-20s %s', $key.':', $val), $depth * 4); + $this->writeLine(sprintf('%s%-20s %s', $prefix, $key.':', $val), $depth * 4); } if (\is_array($value)) { - $this->writeArray($value, $depth + 1); + $this->writeArray($value, $depth + 1, $asComment); } } } diff --git a/src/Symfony/Component/Config/Tests/Definition/Dumper/XmlReferenceDumperTest.php b/src/Symfony/Component/Config/Tests/Definition/Dumper/XmlReferenceDumperTest.php index 520d25666a1c0..67ecb3bf71210 100644 --- a/src/Symfony/Component/Config/Tests/Definition/Dumper/XmlReferenceDumperTest.php +++ b/src/Symfony/Component/Config/Tests/Definition/Dumper/XmlReferenceDumperTest.php @@ -109,6 +109,8 @@ enum="" + + EOL diff --git a/src/Symfony/Component/Config/Tests/Definition/Dumper/YamlReferenceDumperTest.php b/src/Symfony/Component/Config/Tests/Definition/Dumper/YamlReferenceDumperTest.php index 3f198ca9d6607..b2a45ae9ded73 100644 --- a/src/Symfony/Component/Config/Tests/Definition/Dumper/YamlReferenceDumperTest.php +++ b/src/Symfony/Component/Config/Tests/Definition/Dumper/YamlReferenceDumperTest.php @@ -114,11 +114,11 @@ enum: ~ # One of "this"; "that" # which should be indented child3: ~ # Example: 'example setting' scalar_prototyped: [] - variable: + variable: ~ # Examples: - - foo - - bar + # - foo + # - bar parameters: # Prototype: Parameter name @@ -142,6 +142,11 @@ enum: ~ # One of "this"; "that" # Prototype name: [] + array_with_array_example_and_no_default_value: [] + + # Examples: + # - foo + # - bar custom_node: true EOL; diff --git a/src/Symfony/Component/Config/Tests/Fixtures/Configuration/ExampleConfiguration.php b/src/Symfony/Component/Config/Tests/Fixtures/Configuration/ExampleConfiguration.php index 126008831796a..512150afd5235 100644 --- a/src/Symfony/Component/Config/Tests/Fixtures/Configuration/ExampleConfiguration.php +++ b/src/Symfony/Component/Config/Tests/Fixtures/Configuration/ExampleConfiguration.php @@ -96,6 +96,9 @@ public function getConfigTreeBuilder(): TreeBuilder ->end() ->end() ->end() + ->arrayNode('array_with_array_example_and_no_default_value') + ->example(['foo', 'bar']) + ->end() ->append(new CustomNodeDefinition('acme')) ->end() ; From 42fde94d1458abede4ceff5c9607f45777f9586e Mon Sep 17 00:00:00 2001 From: Indra Gunawan Date: Mon, 18 Mar 2024 01:10:56 +0800 Subject: [PATCH 68/81] [Serializer] Fixed BackedEnumNormalizer priority for translatable enum --- .../Resources/config/serializer.php | 2 +- .../Tests/Fixtures/TranslatableBackedEnum.php | 27 +++++++++++++++++++ .../Tests/Functional/SerializerTest.php | 11 ++++++++ 3 files changed, 39 insertions(+), 1 deletion(-) create mode 100644 src/Symfony/Bundle/FrameworkBundle/Tests/Fixtures/TranslatableBackedEnum.php diff --git a/src/Symfony/Bundle/FrameworkBundle/Resources/config/serializer.php b/src/Symfony/Bundle/FrameworkBundle/Resources/config/serializer.php index 2311df0fcf36e..f70d60429e90f 100644 --- a/src/Symfony/Bundle/FrameworkBundle/Resources/config/serializer.php +++ b/src/Symfony/Bundle/FrameworkBundle/Resources/config/serializer.php @@ -219,6 +219,6 @@ ]) ->set('serializer.normalizer.backed_enum', BackedEnumNormalizer::class) - ->tag('serializer.normalizer', ['priority' => -915]) + ->tag('serializer.normalizer', ['priority' => -880]) ; }; diff --git a/src/Symfony/Bundle/FrameworkBundle/Tests/Fixtures/TranslatableBackedEnum.php b/src/Symfony/Bundle/FrameworkBundle/Tests/Fixtures/TranslatableBackedEnum.php new file mode 100644 index 0000000000000..775276d84a87d --- /dev/null +++ b/src/Symfony/Bundle/FrameworkBundle/Tests/Fixtures/TranslatableBackedEnum.php @@ -0,0 +1,27 @@ + + * + * For the full copyright and license information, please view the LICENSE + * file that was distributed with this source code. + */ + +namespace Symfony\Bundle\FrameworkBundle\Tests\Fixtures; + +use Symfony\Contracts\Translation\TranslatableInterface; +use Symfony\Contracts\Translation\TranslatorInterface; + +enum TranslatableBackedEnum: string implements TranslatableInterface +{ + case Get = 'GET'; + + public function trans(TranslatorInterface $translator, ?string $locale = null): string + { + return match ($this) { + self::Get => 'custom_get_string', + }; + } +} diff --git a/src/Symfony/Bundle/FrameworkBundle/Tests/Functional/SerializerTest.php b/src/Symfony/Bundle/FrameworkBundle/Tests/Functional/SerializerTest.php index 630bfb7cd3004..2856816d187a1 100644 --- a/src/Symfony/Bundle/FrameworkBundle/Tests/Functional/SerializerTest.php +++ b/src/Symfony/Bundle/FrameworkBundle/Tests/Functional/SerializerTest.php @@ -11,6 +11,8 @@ namespace Symfony\Bundle\FrameworkBundle\Tests\Functional; +use Symfony\Bundle\FrameworkBundle\Tests\Fixtures\TranslatableBackedEnum; + /** * @author Kévin Dunglas */ @@ -67,6 +69,15 @@ public static function provideNormalizersAndEncodersWithDefaultContextOption(): ['serializer.encoder.csv.alias'], ]; } + + public function testSerializeTranslatableBackedEnum() + { + static::bootKernel(['test_case' => 'Serializer']); + + $serializer = static::getContainer()->get('serializer.alias'); + + $this->assertEquals('GET', $serializer->serialize(TranslatableBackedEnum::Get, 'yaml')); + } } class Foo From 36345e077e2142131ab9714052a33b5515736a49 Mon Sep 17 00:00:00 2001 From: Christian Flothmann Date: Tue, 26 Mar 2024 11:11:58 +0100 Subject: [PATCH 69/81] stop all server processes after tests have run --- .../Tests/DataCollector/HttpClientDataCollectorTest.php | 5 +++++ .../Component/HttpClient/Tests/HttplugClientTest.php | 5 +++++ src/Symfony/Component/HttpClient/Tests/Psr18ClientTest.php | 5 +++++ .../Component/HttpClient/Tests/RetryableHttpClientTest.php | 5 +++++ .../Component/HttpClient/Tests/TraceableHttpClientTest.php | 5 +++++ src/Symfony/Component/HttpClient/composer.json | 2 +- .../Contracts/HttpClient/Test/HttpClientTestCase.php | 6 ++++++ src/Symfony/Contracts/HttpClient/Test/TestHttpServer.php | 7 +++++++ src/Symfony/Contracts/composer.json | 2 +- 9 files changed, 40 insertions(+), 2 deletions(-) diff --git a/src/Symfony/Component/HttpClient/Tests/DataCollector/HttpClientDataCollectorTest.php b/src/Symfony/Component/HttpClient/Tests/DataCollector/HttpClientDataCollectorTest.php index 15a3136da6b73..54e160b5c5240 100644 --- a/src/Symfony/Component/HttpClient/Tests/DataCollector/HttpClientDataCollectorTest.php +++ b/src/Symfony/Component/HttpClient/Tests/DataCollector/HttpClientDataCollectorTest.php @@ -24,6 +24,11 @@ public static function setUpBeforeClass(): void TestHttpServer::start(); } + public static function tearDownAfterClass(): void + { + TestHttpServer::stop(); + } + public function testItCollectsRequestCount() { $httpClient1 = $this->httpClientThatHasTracedRequests([ diff --git a/src/Symfony/Component/HttpClient/Tests/HttplugClientTest.php b/src/Symfony/Component/HttpClient/Tests/HttplugClientTest.php index 48dabb635ef25..0e62425b6b698 100644 --- a/src/Symfony/Component/HttpClient/Tests/HttplugClientTest.php +++ b/src/Symfony/Component/HttpClient/Tests/HttplugClientTest.php @@ -32,6 +32,11 @@ public static function setUpBeforeClass(): void TestHttpServer::start(); } + public static function tearDownAfterClass(): void + { + TestHttpServer::stop(); + } + public function testSendRequest() { $client = new HttplugClient(new NativeHttpClient()); diff --git a/src/Symfony/Component/HttpClient/Tests/Psr18ClientTest.php b/src/Symfony/Component/HttpClient/Tests/Psr18ClientTest.php index d4bae3ab5c4a3..d1f4deb03a006 100644 --- a/src/Symfony/Component/HttpClient/Tests/Psr18ClientTest.php +++ b/src/Symfony/Component/HttpClient/Tests/Psr18ClientTest.php @@ -28,6 +28,11 @@ public static function setUpBeforeClass(): void TestHttpServer::start(); } + public static function tearDownAfterClass(): void + { + TestHttpServer::stop(); + } + public function testSendRequest() { $factory = new Psr17Factory(); diff --git a/src/Symfony/Component/HttpClient/Tests/RetryableHttpClientTest.php b/src/Symfony/Component/HttpClient/Tests/RetryableHttpClientTest.php index 9edf41318555e..c15b0d2a4e0ad 100644 --- a/src/Symfony/Component/HttpClient/Tests/RetryableHttpClientTest.php +++ b/src/Symfony/Component/HttpClient/Tests/RetryableHttpClientTest.php @@ -27,6 +27,11 @@ class RetryableHttpClientTest extends TestCase { + public static function tearDownAfterClass(): void + { + TestHttpServer::stop(); + } + public function testRetryOnError() { $client = new RetryableHttpClient( diff --git a/src/Symfony/Component/HttpClient/Tests/TraceableHttpClientTest.php b/src/Symfony/Component/HttpClient/Tests/TraceableHttpClientTest.php index 5f20e1989dfa1..052400bb3cf96 100644 --- a/src/Symfony/Component/HttpClient/Tests/TraceableHttpClientTest.php +++ b/src/Symfony/Component/HttpClient/Tests/TraceableHttpClientTest.php @@ -29,6 +29,11 @@ public static function setUpBeforeClass(): void TestHttpServer::start(); } + public static function tearDownAfterClass(): void + { + TestHttpServer::stop(); + } + public function testItTracesRequest() { $httpClient = $this->createMock(HttpClientInterface::class); diff --git a/src/Symfony/Component/HttpClient/composer.json b/src/Symfony/Component/HttpClient/composer.json index 735d69a3afd64..2326e9f4b758a 100644 --- a/src/Symfony/Component/HttpClient/composer.json +++ b/src/Symfony/Component/HttpClient/composer.json @@ -25,7 +25,7 @@ "php": ">=7.2.5", "psr/log": "^1|^2|^3", "symfony/deprecation-contracts": "^2.1|^3", - "symfony/http-client-contracts": "^2.4", + "symfony/http-client-contracts": "^2.6", "symfony/polyfill-php73": "^1.11", "symfony/polyfill-php80": "^1.16", "symfony/service-contracts": "^1.0|^2|^3" diff --git a/src/Symfony/Contracts/HttpClient/Test/HttpClientTestCase.php b/src/Symfony/Contracts/HttpClient/Test/HttpClientTestCase.php index 78b02786a8857..994e92621ff25 100644 --- a/src/Symfony/Contracts/HttpClient/Test/HttpClientTestCase.php +++ b/src/Symfony/Contracts/HttpClient/Test/HttpClientTestCase.php @@ -28,6 +28,12 @@ public static function setUpBeforeClass(): void TestHttpServer::start(); } + public static function tearDownAfterClass(): void + { + TestHttpServer::stop(8067); + TestHttpServer::stop(8077); + } + abstract protected function getHttpClient(string $testCase): HttpClientInterface; public function testGetRequest() diff --git a/src/Symfony/Contracts/HttpClient/Test/TestHttpServer.php b/src/Symfony/Contracts/HttpClient/Test/TestHttpServer.php index 55a744aef4332..463b4b75c60ad 100644 --- a/src/Symfony/Contracts/HttpClient/Test/TestHttpServer.php +++ b/src/Symfony/Contracts/HttpClient/Test/TestHttpServer.php @@ -43,4 +43,11 @@ public static function start(int $port = 8057) return $process; } + + public static function stop(int $port = 8057) + { + if (isset(self::$process[$port])) { + self::$process[$port]->stop(); + } + } } diff --git a/src/Symfony/Contracts/composer.json b/src/Symfony/Contracts/composer.json index f70b8b7dc55a4..151b85bda7647 100644 --- a/src/Symfony/Contracts/composer.json +++ b/src/Symfony/Contracts/composer.json @@ -52,7 +52,7 @@ "minimum-stability": "dev", "extra": { "branch-alias": { - "dev-main": "2.5-dev" + "dev-main": "2.6-dev" } } } From adfe8df59bb752cb19b265076285d7d5bac8b908 Mon Sep 17 00:00:00 2001 From: Pierre Ambroise Date: Wed, 27 Mar 2024 10:54:01 +0100 Subject: [PATCH 70/81] Fix TypeError on ProgressBar --- src/Symfony/Component/Console/Helper/ProgressBar.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Symfony/Component/Console/Helper/ProgressBar.php b/src/Symfony/Component/Console/Helper/ProgressBar.php index f4eec051c19a7..b406292b44b3a 100644 --- a/src/Symfony/Component/Console/Helper/ProgressBar.php +++ b/src/Symfony/Component/Console/Helper/ProgressBar.php @@ -183,9 +183,9 @@ public function setMessage(string $message, string $name = 'message'): void $this->messages[$name] = $message; } - public function getMessage(string $name = 'message'): string + public function getMessage(string $name = 'message'): ?string { - return $this->messages[$name]; + return $this->messages[$name] ?? null; } public function getStartTime(): int From bc22326c67fd767ba817dc33dbf142ca2f96c038 Mon Sep 17 00:00:00 2001 From: Christian Flothmann Date: Tue, 26 Mar 2024 20:58:23 +0100 Subject: [PATCH 71/81] synchronize Redis proxy traits for different versions --- .../Cache/Tests/Traits/RedisProxiesTest.php | 32 ++++++------ .../Component/Cache/Traits/Redis6Proxy.php | 16 +----- .../Cache/Traits/Redis6ProxyTrait.php | 51 +++++++++++++++++++ .../Cache/Traits/RedisCluster6Proxy.php | 11 +--- .../Cache/Traits/RedisCluster6ProxyTrait.php | 41 +++++++++++++++ 5 files changed, 109 insertions(+), 42 deletions(-) create mode 100644 src/Symfony/Component/Cache/Traits/Redis6ProxyTrait.php create mode 100644 src/Symfony/Component/Cache/Traits/RedisCluster6ProxyTrait.php diff --git a/src/Symfony/Component/Cache/Tests/Traits/RedisProxiesTest.php b/src/Symfony/Component/Cache/Tests/Traits/RedisProxiesTest.php index 8d315ffd2c519..0e3f2de0b5ec3 100644 --- a/src/Symfony/Component/Cache/Tests/Traits/RedisProxiesTest.php +++ b/src/Symfony/Component/Cache/Tests/Traits/RedisProxiesTest.php @@ -86,32 +86,31 @@ public function testRelayProxy() */ public function testRedis6Proxy($class, $stub) { - $stub = file_get_contents("https://raw.githubusercontent.com/phpredis/phpredis/develop/{$stub}.stub.php"); + if (version_compare(phpversion('redis'), '6.0.2', '>')) { + $stub = file_get_contents("https://raw.githubusercontent.com/phpredis/phpredis/develop/{$stub}.stub.php"); + } else { + $stub = file_get_contents("https://raw.githubusercontent.com/phpredis/phpredis/6.0.2/{$stub}.stub.php"); + } + $stub = preg_replace('/^class /m', 'return; \0', $stub); $stub = preg_replace('/^return; class ([a-zA-Z]++)/m', 'interface \1StubInterface', $stub, 1); $stub = preg_replace('/^ public const .*/m', '', $stub); eval(substr($stub, 5)); - $r = new \ReflectionClass($class.'StubInterface'); - $proxy = file_get_contents(\dirname(__DIR__, 2)."/Traits/{$class}6Proxy.php"); - $proxy = substr($proxy, 0, 4 + strpos($proxy, '[];')); + $this->assertEquals(self::dumpMethods(new \ReflectionClass($class.'StubInterface')), self::dumpMethods(new \ReflectionClass(sprintf('Symfony\Component\Cache\Traits\%s6Proxy', $class)))); + } + + private static function dumpMethods(\ReflectionClass $class): string + { $methods = []; - foreach ($r->getMethods() as $method) { + foreach ($class->getMethods() as $method) { if ('reset' === $method->name || method_exists(LazyProxyTrait::class, $method->name)) { continue; } + $return = $method->getReturnType() instanceof \ReflectionNamedType && 'void' === (string) $method->getReturnType() ? '' : 'return '; $signature = ProxyHelper::exportSignature($method, false, $args); - - if ('Redis' === $class && 'mget' === $method->name) { - $signature = str_replace(': \Redis|array|false', ': \Redis|array', $signature); - } - - if ('RedisCluster' === $class && 'publish' === $method->name) { - $signature = str_replace(': \RedisCluster|bool|int', ': \RedisCluster|bool', $signature); - } - $methods[] = "\n ".str_replace('timeout = 0.0', 'timeout = 0', $signature)."\n".<<lazyObjectState->realInstance ??= (\$this->lazyObjectState->initializer)())->{$method->name}({$args}); @@ -120,9 +119,8 @@ public function testRedis6Proxy($class, $stub) EOPHP; } - uksort($methods, 'strnatcmp'); - $proxy .= implode('', $methods)."}\n"; + usort($methods, 'strnatcmp'); - $this->assertStringEqualsFile(\dirname(__DIR__, 2)."/Traits/{$class}6Proxy.php", $proxy); + return implode("\n", $methods); } } diff --git a/src/Symfony/Component/Cache/Traits/Redis6Proxy.php b/src/Symfony/Component/Cache/Traits/Redis6Proxy.php index 59ab11b0f3c55..e41c0d10cc030 100644 --- a/src/Symfony/Component/Cache/Traits/Redis6Proxy.php +++ b/src/Symfony/Component/Cache/Traits/Redis6Proxy.php @@ -28,6 +28,7 @@ class Redis6Proxy extends \Redis implements ResetInterface, LazyObjectInterface use LazyProxyTrait { resetLazyObject as reset; } + use Redis6ProxyTrait; private const LAZY_OBJECT_PROPERTY_SCOPES = []; @@ -96,11 +97,6 @@ public function bgrewriteaof(): \Redis|bool return ($this->lazyObjectState->realInstance ??= ($this->lazyObjectState->initializer)())->bgrewriteaof(...\func_get_args()); } - public function waitaof($numlocal, $numreplicas, $timeout): \Redis|array|false - { - return ($this->lazyObjectState->realInstance ??= ($this->lazyObjectState->initializer)())->waitaof(...\func_get_args()); - } - public function bitcount($key, $start = 0, $end = -1, $bybit = false): \Redis|false|int { return ($this->lazyObjectState->realInstance ??= ($this->lazyObjectState->initializer)())->bitcount(...\func_get_args()); @@ -231,11 +227,6 @@ public function discard(): \Redis|bool return ($this->lazyObjectState->realInstance ??= ($this->lazyObjectState->initializer)())->discard(...\func_get_args()); } - public function dump($key): \Redis|string - { - return ($this->lazyObjectState->realInstance ??= ($this->lazyObjectState->initializer)())->dump(...\func_get_args()); - } - public function echo($str): \Redis|false|string { return ($this->lazyObjectState->realInstance ??= ($this->lazyObjectState->initializer)())->echo(...\func_get_args()); @@ -656,11 +647,6 @@ public function ltrim($key, $start, $end): \Redis|bool return ($this->lazyObjectState->realInstance ??= ($this->lazyObjectState->initializer)())->ltrim(...\func_get_args()); } - public function mget($keys): \Redis|array - { - return ($this->lazyObjectState->realInstance ??= ($this->lazyObjectState->initializer)())->mget(...\func_get_args()); - } - public function migrate($host, $port, $key, $dstdb, $timeout, $copy = false, $replace = false, #[\SensitiveParameter] $credentials = null): \Redis|bool { return ($this->lazyObjectState->realInstance ??= ($this->lazyObjectState->initializer)())->migrate(...\func_get_args()); diff --git a/src/Symfony/Component/Cache/Traits/Redis6ProxyTrait.php b/src/Symfony/Component/Cache/Traits/Redis6ProxyTrait.php new file mode 100644 index 0000000000000..d086d5b3e8a09 --- /dev/null +++ b/src/Symfony/Component/Cache/Traits/Redis6ProxyTrait.php @@ -0,0 +1,51 @@ + + * + * For the full copyright and license information, please view the LICENSE + * file that was distributed with this source code. + */ + +namespace Symfony\Component\Cache\Traits; + +if (version_compare(phpversion('redis'), '6.0.2', '>')) { + /** + * @internal + */ + trait Redis6ProxyTrait + { + public function dump($key): \Redis|false|string + { + return ($this->lazyObjectState->realInstance ??= ($this->lazyObjectState->initializer)())->dump(...\func_get_args()); + } + + public function mget($keys): \Redis|array|false + { + return ($this->lazyObjectState->realInstance ??= ($this->lazyObjectState->initializer)())->mget(...\func_get_args()); + } + + public function waitaof($numlocal, $numreplicas, $timeout): \Redis|array|false + { + return ($this->lazyObjectState->realInstance ??= ($this->lazyObjectState->initializer)())->waitaof(...\func_get_args()); + } + } +} else { + /** + * @internal + */ + trait Redis6ProxyTrait + { + public function dump($key): \Redis|string + { + return ($this->lazyObjectState->realInstance ??= ($this->lazyObjectState->initializer)())->dump(...\func_get_args()); + } + + public function mget($keys): \Redis|array + { + return ($this->lazyObjectState->realInstance ??= ($this->lazyObjectState->initializer)())->mget(...\func_get_args()); + } + } +} diff --git a/src/Symfony/Component/Cache/Traits/RedisCluster6Proxy.php b/src/Symfony/Component/Cache/Traits/RedisCluster6Proxy.php index da6526b6eb5d1..6e06b075f27d7 100644 --- a/src/Symfony/Component/Cache/Traits/RedisCluster6Proxy.php +++ b/src/Symfony/Component/Cache/Traits/RedisCluster6Proxy.php @@ -28,6 +28,7 @@ class RedisCluster6Proxy extends \RedisCluster implements ResetInterface, LazyOb use LazyProxyTrait { resetLazyObject as reset; } + use RedisCluster6ProxyTrait; private const LAZY_OBJECT_PROPERTY_SCOPES = []; @@ -96,11 +97,6 @@ public function bgrewriteaof($key_or_address): \RedisCluster|bool return ($this->lazyObjectState->realInstance ??= ($this->lazyObjectState->initializer)())->bgrewriteaof(...\func_get_args()); } - public function waitaof($key_or_address, $numlocal, $numreplicas, $timeout): \RedisCluster|array|false - { - return ($this->lazyObjectState->realInstance ??= ($this->lazyObjectState->initializer)())->waitaof(...\func_get_args()); - } - public function bgsave($key_or_address): \RedisCluster|bool { return ($this->lazyObjectState->realInstance ??= ($this->lazyObjectState->initializer)())->bgsave(...\func_get_args()); @@ -661,11 +657,6 @@ public function pttl($key): \RedisCluster|false|int return ($this->lazyObjectState->realInstance ??= ($this->lazyObjectState->initializer)())->pttl(...\func_get_args()); } - public function publish($channel, $message): \RedisCluster|bool - { - return ($this->lazyObjectState->realInstance ??= ($this->lazyObjectState->initializer)())->publish(...\func_get_args()); - } - public function pubsub($key_or_address, ...$values): mixed { return ($this->lazyObjectState->realInstance ??= ($this->lazyObjectState->initializer)())->pubsub(...\func_get_args()); diff --git a/src/Symfony/Component/Cache/Traits/RedisCluster6ProxyTrait.php b/src/Symfony/Component/Cache/Traits/RedisCluster6ProxyTrait.php new file mode 100644 index 0000000000000..389c6e1adf347 --- /dev/null +++ b/src/Symfony/Component/Cache/Traits/RedisCluster6ProxyTrait.php @@ -0,0 +1,41 @@ + + * + * For the full copyright and license information, please view the LICENSE + * file that was distributed with this source code. + */ + +namespace Symfony\Component\Cache\Traits; + +if (version_compare(phpversion('redis'), '6.0.2', '>')) { + /** + * @internal + */ + trait RedisCluster6ProxyTrait + { + public function publish($channel, $message): \RedisCluster|bool|int + { + return ($this->lazyObjectState->realInstance ??= ($this->lazyObjectState->initializer)())->publish(...\func_get_args()); + } + + public function waitaof($key_or_address, $numlocal, $numreplicas, $timeout): \RedisCluster|array|false + { + return ($this->lazyObjectState->realInstance ??= ($this->lazyObjectState->initializer)())->waitaof(...\func_get_args()); + } + } +} else { + /** + * @internal + */ + trait RedisCluster6ProxyTrait + { + public function publish($channel, $message): \RedisCluster|bool + { + return ($this->lazyObjectState->realInstance ??= ($this->lazyObjectState->initializer)())->publish(...\func_get_args()); + } + } +} From 4b62275a5489b6be06f32eaca4103a7744fa903c Mon Sep 17 00:00:00 2001 From: Jan Rosier Date: Wed, 27 Mar 2024 21:05:04 +0100 Subject: [PATCH 72/81] Remove whitespaces from block form_help --- .../Resources/views/Form/bootstrap_5_layout.html.twig | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/Symfony/Bridge/Twig/Resources/views/Form/bootstrap_5_layout.html.twig b/src/Symfony/Bridge/Twig/Resources/views/Form/bootstrap_5_layout.html.twig index 22555ed88f4a8..852335ea1adab 100644 --- a/src/Symfony/Bridge/Twig/Resources/views/Form/bootstrap_5_layout.html.twig +++ b/src/Symfony/Bridge/Twig/Resources/views/Form/bootstrap_5_layout.html.twig @@ -361,12 +361,12 @@ {# Help #} {%- block form_help -%} - {% set row_class = row_attr.class|default('') %} - {% set help_class = ' form-text' %} - {% if 'input-group' in row_class %} + {%- set row_class = row_attr.class|default('') -%} + {%- set help_class = ' form-text' -%} + {%- if 'input-group' in row_class -%} {#- Hack to properly display help with input group -#} - {% set help_class = ' input-group-text' %} - {% endif %} + {%- set help_class = ' input-group-text' -%} + {%- endif -%} {%- if help is not empty -%} {%- set help_attr = help_attr|merge({class: (help_attr.class|default('') ~ help_class ~ ' mb-0')|trim}) -%} {%- endif -%} From a6fda75cb9b6ce4be9cde5c31625314e7e68522b Mon Sep 17 00:00:00 2001 From: Christian Flothmann Date: Fri, 16 Feb 2024 14:08:31 +0100 Subject: [PATCH 73/81] include message id provided by the MTA when dispatching the SentMessageEvent --- .../Tests/Transport/Smtp/DummyStream.php | 2 +- .../Transport/Smtp/SmtpTransportTest.php | 34 +++++++++++++++++++ .../Mailer/Transport/Smtp/SmtpTransport.php | 11 +++--- 3 files changed, 40 insertions(+), 7 deletions(-) diff --git a/src/Symfony/Component/Mailer/Tests/Transport/Smtp/DummyStream.php b/src/Symfony/Component/Mailer/Tests/Transport/Smtp/DummyStream.php index 407c90810b78b..d67671ea10762 100644 --- a/src/Symfony/Component/Mailer/Tests/Transport/Smtp/DummyStream.php +++ b/src/Symfony/Component/Mailer/Tests/Transport/Smtp/DummyStream.php @@ -77,7 +77,7 @@ public function write(string $bytes, $debug = true): void } elseif (str_starts_with($bytes, 'QUIT')) { $this->nextResponse = '221 Goodbye'; } else { - $this->nextResponse = '250 OK'; + $this->nextResponse = '250 OK queued as 000501c4054c'; } } diff --git a/src/Symfony/Component/Mailer/Tests/Transport/Smtp/SmtpTransportTest.php b/src/Symfony/Component/Mailer/Tests/Transport/Smtp/SmtpTransportTest.php index 6900320506053..a8d3540a115f9 100644 --- a/src/Symfony/Component/Mailer/Tests/Transport/Smtp/SmtpTransportTest.php +++ b/src/Symfony/Component/Mailer/Tests/Transport/Smtp/SmtpTransportTest.php @@ -13,6 +13,8 @@ use PHPUnit\Framework\TestCase; use Symfony\Component\Mailer\Envelope; +use Symfony\Component\Mailer\Event\MessageEvent; +use Symfony\Component\Mailer\Event\SentMessageEvent; use Symfony\Component\Mailer\Exception\LogicException; use Symfony\Component\Mailer\Exception\TransportException; use Symfony\Component\Mailer\Transport\Smtp\SmtpTransport; @@ -24,6 +26,7 @@ use Symfony\Component\Mime\Part\DataPart; use Symfony\Component\Mime\Part\File; use Symfony\Component\Mime\RawMessage; +use Symfony\Contracts\EventDispatcher\EventDispatcherInterface; /** * @group time-sensitive @@ -137,6 +140,37 @@ public function testWriteEncodedRecipientAndSenderAddresses() $this->assertContains("RCPT TO:\r\n", $stream->getCommands()); } + public function testMessageIdFromServerIsEmbeddedInSentMessageEvent() + { + $calls = 0; + $eventDispatcher = $this->createMock(EventDispatcherInterface::class); + $eventDispatcher->expects($this->any()) + ->method('dispatch') + ->with($this->callback(static function ($event) use (&$calls): bool { + ++$calls; + + if (1 === $calls && $event instanceof MessageEvent) { + return true; + } + + if (2 === $calls && $event instanceof SentMessageEvent && '000501c4054c' === $event->getMessage()->getMessageId()) { + return true; + } + + return false; + })); + $transport = new SmtpTransport(new DummyStream(), $eventDispatcher); + + $email = new Email(); + $email->from('sender@example.com'); + $email->to('recipient@example.com'); + $email->text('.'); + + $transport->send($email); + + $this->assertSame(2, $calls); + } + public function testAssertResponseCodeNoCodes() { $this->expectException(LogicException::class); diff --git a/src/Symfony/Component/Mailer/Transport/Smtp/SmtpTransport.php b/src/Symfony/Component/Mailer/Transport/Smtp/SmtpTransport.php index e05e347919d27..0de38fb2ed690 100644 --- a/src/Symfony/Component/Mailer/Transport/Smtp/SmtpTransport.php +++ b/src/Symfony/Component/Mailer/Transport/Smtp/SmtpTransport.php @@ -39,7 +39,6 @@ class SmtpTransport extends AbstractTransport private int $pingThreshold = 100; private float $lastMessageTime = 0; private AbstractStream $stream; - private string $mtaResult = ''; private string $domain = '[127.0.0.1]'; public function __construct(?AbstractStream $stream = null, ?EventDispatcherInterface $dispatcher = null, ?LoggerInterface $logger = null) @@ -148,10 +147,6 @@ public function send(RawMessage $message, ?Envelope $envelope = null): ?SentMess throw $e; } - if ($this->mtaResult && $messageId = $this->parseMessageId($this->mtaResult)) { - $message->setMessageId($messageId); - } - $this->checkRestartThreshold(); return $message; @@ -235,9 +230,13 @@ protected function doSend(SentMessage $message): void $this->getLogger()->debug(sprintf('Email transport "%s" stopped', __CLASS__)); throw $e; } - $this->mtaResult = $this->executeCommand("\r\n.\r\n", [250]); + $mtaResult = $this->executeCommand("\r\n.\r\n", [250]); $message->appendDebug($this->stream->getDebug()); $this->lastMessageTime = microtime(true); + + if ($mtaResult && $messageId = $this->parseMessageId($mtaResult)) { + $message->setMessageId($messageId); + } } catch (TransportExceptionInterface $e) { $e->appendDebug($this->stream->getDebug()); $this->lastMessageTime = 0; From e44545acc7b5150b32686d06d101b734fb845416 Mon Sep 17 00:00:00 2001 From: Christian Flothmann Date: Wed, 27 Mar 2024 22:24:38 +0100 Subject: [PATCH 74/81] stop marking parameters implicitly as nullable --- .../PsrHttpMessage/Tests/Fixtures/ServerRequest.php | 4 ++-- .../LazyProxy/PhpDumper/DumperInterface.php | 4 ++-- .../Tests/Fixtures/includes/autowiring_classes.php | 2 +- .../Fixtures/includes/autowiring_classes_80.php | 2 +- .../Tests/Fixtures/includes/classes.php | 2 +- .../Form/Tests/Fixtures/TranslatableTextAlign.php | 2 +- .../Tests/Extractor/PhpDocExtractorTest.php | 6 +++--- .../Tests/Extractor/PhpStanExtractorTest.php | 12 ++++++------ .../Tests/Fixtures/TraceableAttributeClassLoader.php | 2 +- .../Tests/Fixtures/FooInterfaceDummyDenormalizer.php | 4 ++-- .../Fixtures/FormatAndContextAwareNormalizer.php | 2 +- .../Tests/Fixtures/StaticConstructorNormalizer.php | 6 +++--- .../Fixtures/ConstraintWithRequiredArgument.php | 2 +- 13 files changed, 25 insertions(+), 25 deletions(-) diff --git a/src/Symfony/Bridge/PsrHttpMessage/Tests/Fixtures/ServerRequest.php b/src/Symfony/Bridge/PsrHttpMessage/Tests/Fixtures/ServerRequest.php index 0bd7d5918983b..99b7abbee3f1b 100644 --- a/src/Symfony/Bridge/PsrHttpMessage/Tests/Fixtures/ServerRequest.php +++ b/src/Symfony/Bridge/PsrHttpMessage/Tests/Fixtures/ServerRequest.php @@ -26,10 +26,10 @@ class ServerRequest extends Message implements ServerRequestInterface public function __construct( string $version = '1.1', array $headers = [], - StreamInterface $body = null, + ?StreamInterface $body = null, private readonly string $requestTarget = '/', private readonly string $method = 'GET', - UriInterface|string $uri = null, + UriInterface|string|null $uri = null, private readonly array $server = [], private readonly array $cookies = [], private readonly array $query = [], diff --git a/src/Symfony/Component/DependencyInjection/LazyProxy/PhpDumper/DumperInterface.php b/src/Symfony/Component/DependencyInjection/LazyProxy/PhpDumper/DumperInterface.php index 520977763f3ad..b8f31ee41e94e 100644 --- a/src/Symfony/Component/DependencyInjection/LazyProxy/PhpDumper/DumperInterface.php +++ b/src/Symfony/Component/DependencyInjection/LazyProxy/PhpDumper/DumperInterface.php @@ -26,7 +26,7 @@ interface DumperInterface * @param bool|null &$asGhostObject Set to true after the call if the proxy is a ghost object * @param string|null $id */ - public function isProxyCandidate(Definition $definition/* , bool &$asGhostObject = null, string $id = null */): bool; + public function isProxyCandidate(Definition $definition/* , ?bool &$asGhostObject = null, ?string $id = null */): bool; /** * Generates the code to be used to instantiate a proxy in the dumped factory code. @@ -38,5 +38,5 @@ public function getProxyFactoryCode(Definition $definition, string $id, string $ * * @param string|null $id */ - public function getProxyCode(Definition $definition/* , string $id = null */): string; + public function getProxyCode(Definition $definition/* , ?string $id = null */): string; } diff --git a/src/Symfony/Component/DependencyInjection/Tests/Fixtures/includes/autowiring_classes.php b/src/Symfony/Component/DependencyInjection/Tests/Fixtures/includes/autowiring_classes.php index 69f19c3657c65..a9ac5c0bff430 100644 --- a/src/Symfony/Component/DependencyInjection/Tests/Fixtures/includes/autowiring_classes.php +++ b/src/Symfony/Component/DependencyInjection/Tests/Fixtures/includes/autowiring_classes.php @@ -30,7 +30,7 @@ class Foo public static int $counter = 0; #[Required] - public function cloneFoo(\stdClass $bar = null): static + public function cloneFoo(?\stdClass $bar = null): static { ++self::$counter; diff --git a/src/Symfony/Component/DependencyInjection/Tests/Fixtures/includes/autowiring_classes_80.php b/src/Symfony/Component/DependencyInjection/Tests/Fixtures/includes/autowiring_classes_80.php index 69ca09218812c..0c7cc2a7b7baf 100644 --- a/src/Symfony/Component/DependencyInjection/Tests/Fixtures/includes/autowiring_classes_80.php +++ b/src/Symfony/Component/DependencyInjection/Tests/Fixtures/includes/autowiring_classes_80.php @@ -107,7 +107,7 @@ public function __construct(string $arg1, #[AutowireDecorated] AsDecoratorInterf #[AsDecorator(decorates: \NonExistent::class, onInvalid: ContainerInterface::NULL_ON_INVALID_REFERENCE)] class AsDecoratorBaz implements AsDecoratorInterface { - public function __construct(#[AutowireDecorated] AsDecoratorInterface $inner = null) + public function __construct(#[AutowireDecorated] ?AsDecoratorInterface $inner = null) { } } diff --git a/src/Symfony/Component/DependencyInjection/Tests/Fixtures/includes/classes.php b/src/Symfony/Component/DependencyInjection/Tests/Fixtures/includes/classes.php index 846c8fe64797b..6084c42c77dd4 100644 --- a/src/Symfony/Component/DependencyInjection/Tests/Fixtures/includes/classes.php +++ b/src/Symfony/Component/DependencyInjection/Tests/Fixtures/includes/classes.php @@ -83,7 +83,7 @@ public function callPassed() class DummyProxyDumper implements DumperInterface { - public function isProxyCandidate(Definition $definition, bool &$asGhostObject = null, string $id = null): bool + public function isProxyCandidate(Definition $definition, ?bool &$asGhostObject = null, ?string $id = null): bool { $asGhostObject = false; diff --git a/src/Symfony/Component/Form/Tests/Fixtures/TranslatableTextAlign.php b/src/Symfony/Component/Form/Tests/Fixtures/TranslatableTextAlign.php index 7a5d5cdff68e7..4464088c78103 100644 --- a/src/Symfony/Component/Form/Tests/Fixtures/TranslatableTextAlign.php +++ b/src/Symfony/Component/Form/Tests/Fixtures/TranslatableTextAlign.php @@ -20,7 +20,7 @@ enum TranslatableTextAlign implements TranslatableInterface case Center; case Right; - public function trans(TranslatorInterface $translator, string $locale = null): string + public function trans(TranslatorInterface $translator, ?string $locale = null): string { return $translator->trans($this->name, locale: $locale); } diff --git a/src/Symfony/Component/PropertyInfo/Tests/Extractor/PhpDocExtractorTest.php b/src/Symfony/Component/PropertyInfo/Tests/Extractor/PhpDocExtractorTest.php index b0ca5cbe65b87..252df9914f683 100644 --- a/src/Symfony/Component/PropertyInfo/Tests/Extractor/PhpDocExtractorTest.php +++ b/src/Symfony/Component/PropertyInfo/Tests/Extractor/PhpDocExtractorTest.php @@ -80,7 +80,7 @@ public function testEmptyParamAnnotation() /** * @dataProvider typesWithNoPrefixesProvider */ - public function testExtractTypesWithNoPrefixes($property, array $type = null) + public function testExtractTypesWithNoPrefixes($property, ?array $type = null) { $noPrefixExtractor = new PhpDocExtractor(null, [], [], []); @@ -202,7 +202,7 @@ public static function provideCollectionTypes() /** * @dataProvider typesWithCustomPrefixesProvider */ - public function testExtractTypesWithCustomPrefixes($property, array $type = null) + public function testExtractTypesWithCustomPrefixes($property, ?array $type = null) { $customExtractor = new PhpDocExtractor(null, ['add', 'remove'], ['is', 'can']); @@ -401,7 +401,7 @@ public function testUnknownPseudoType() /** * @dataProvider constructorTypesProvider */ - public function testExtractConstructorTypes($property, array $type = null) + public function testExtractConstructorTypes($property, ?array $type = null) { $this->assertEquals($type, $this->extractor->getTypesFromConstructor('Symfony\Component\PropertyInfo\Tests\Fixtures\ConstructorDummy', $property)); } diff --git a/src/Symfony/Component/PropertyInfo/Tests/Extractor/PhpStanExtractorTest.php b/src/Symfony/Component/PropertyInfo/Tests/Extractor/PhpStanExtractorTest.php index fdd90c7b43c80..3c32c84d14fd8 100644 --- a/src/Symfony/Component/PropertyInfo/Tests/Extractor/PhpStanExtractorTest.php +++ b/src/Symfony/Component/PropertyInfo/Tests/Extractor/PhpStanExtractorTest.php @@ -44,7 +44,7 @@ protected function setUp(): void /** * @dataProvider typesProvider */ - public function testExtract($property, array $type = null) + public function testExtract($property, ?array $type = null) { $this->assertEquals($type, $this->extractor->getTypes('Symfony\Component\PropertyInfo\Tests\Fixtures\Dummy', $property)); } @@ -75,7 +75,7 @@ public function testInvalid($property) /** * @dataProvider typesWithNoPrefixesProvider */ - public function testExtractTypesWithNoPrefixes($property, array $type = null) + public function testExtractTypesWithNoPrefixes($property, ?array $type = null) { $noPrefixExtractor = new PhpStanExtractor([], [], []); @@ -130,7 +130,7 @@ public static function typesProvider() /** * @dataProvider provideCollectionTypes */ - public function testExtractCollection($property, array $type = null) + public function testExtractCollection($property, ?array $type = null) { $this->testExtract($property, $type); } @@ -186,7 +186,7 @@ public static function provideCollectionTypes() /** * @dataProvider typesWithCustomPrefixesProvider */ - public function testExtractTypesWithCustomPrefixes($property, array $type = null) + public function testExtractTypesWithCustomPrefixes($property, ?array $type = null) { $customExtractor = new PhpStanExtractor(['add', 'remove'], ['is', 'can']); @@ -344,7 +344,7 @@ public static function propertiesParentTypeProvider(): array /** * @dataProvider constructorTypesProvider */ - public function testExtractConstructorTypes($property, array $type = null) + public function testExtractConstructorTypes($property, ?array $type = null) { $this->assertEquals($type, $this->extractor->getTypesFromConstructor('Symfony\Component\PropertyInfo\Tests\Fixtures\ConstructorDummy', $property)); } @@ -459,7 +459,7 @@ public static function intRangeTypeProvider(): array /** * @dataProvider php80TypesProvider */ - public function testExtractPhp80Type(string $class, $property, array $type = null) + public function testExtractPhp80Type(string $class, $property, ?array $type = null) { $this->assertEquals($type, $this->extractor->getTypes($class, $property, [])); } diff --git a/src/Symfony/Component/Routing/Tests/Fixtures/TraceableAttributeClassLoader.php b/src/Symfony/Component/Routing/Tests/Fixtures/TraceableAttributeClassLoader.php index 1e2a2637dee8c..36b7619c7df6d 100644 --- a/src/Symfony/Component/Routing/Tests/Fixtures/TraceableAttributeClassLoader.php +++ b/src/Symfony/Component/Routing/Tests/Fixtures/TraceableAttributeClassLoader.php @@ -20,7 +20,7 @@ final class TraceableAttributeClassLoader extends AttributeClassLoader /** @var list */ public array $foundClasses = []; - public function load(mixed $class, string $type = null): RouteCollection + public function load(mixed $class, ?string $type = null): RouteCollection { if (!is_string($class)) { throw new \InvalidArgumentException(sprintf('Expected string, got "%s"', get_debug_type($class))); diff --git a/src/Symfony/Component/Serializer/Tests/Fixtures/FooInterfaceDummyDenormalizer.php b/src/Symfony/Component/Serializer/Tests/Fixtures/FooInterfaceDummyDenormalizer.php index a8c45373b70ee..0fa3c8202ac95 100644 --- a/src/Symfony/Component/Serializer/Tests/Fixtures/FooInterfaceDummyDenormalizer.php +++ b/src/Symfony/Component/Serializer/Tests/Fixtures/FooInterfaceDummyDenormalizer.php @@ -15,7 +15,7 @@ final class FooInterfaceDummyDenormalizer implements DenormalizerInterface { - public function denormalize(mixed $data, string $type, string $format = null, array $context = []): array + public function denormalize(mixed $data, string $type, ?string $format = null, array $context = []): array { $result = []; foreach ($data as $foo) { @@ -27,7 +27,7 @@ public function denormalize(mixed $data, string $type, string $format = null, ar return $result; } - public function supportsDenormalization(mixed $data, string $type, string $format = null, array $context = []): bool + public function supportsDenormalization(mixed $data, string $type, ?string $format = null, array $context = []): bool { if (str_ends_with($type, '[]')) { $className = substr($type, 0, -2); diff --git a/src/Symfony/Component/Serializer/Tests/Fixtures/FormatAndContextAwareNormalizer.php b/src/Symfony/Component/Serializer/Tests/Fixtures/FormatAndContextAwareNormalizer.php index 4042288450637..428c618a9ddd9 100644 --- a/src/Symfony/Component/Serializer/Tests/Fixtures/FormatAndContextAwareNormalizer.php +++ b/src/Symfony/Component/Serializer/Tests/Fixtures/FormatAndContextAwareNormalizer.php @@ -15,7 +15,7 @@ class FormatAndContextAwareNormalizer extends ObjectNormalizer { - protected function isAllowedAttribute($classOrObject, string $attribute, string $format = null, array $context = []): bool + protected function isAllowedAttribute($classOrObject, string $attribute, ?string $format = null, array $context = []): bool { return \in_array($attribute, ['foo', 'bar']) && 'foo_and_bar_included' === $format; } diff --git a/src/Symfony/Component/Serializer/Tests/Fixtures/StaticConstructorNormalizer.php b/src/Symfony/Component/Serializer/Tests/Fixtures/StaticConstructorNormalizer.php index c2e77aa4baf50..1ba6884bde1d0 100644 --- a/src/Symfony/Component/Serializer/Tests/Fixtures/StaticConstructorNormalizer.php +++ b/src/Symfony/Component/Serializer/Tests/Fixtures/StaticConstructorNormalizer.php @@ -23,17 +23,17 @@ public function getSupportedTypes(?string $format): array return [StaticConstructorDummy::class]; } - protected function extractAttributes(object $object, string $format = null, array $context = []): array + protected function extractAttributes(object $object, ?string $format = null, array $context = []): array { return get_object_vars($object); } - protected function getAttributeValue(object $object, string $attribute, string $format = null, array $context = []): mixed + protected function getAttributeValue(object $object, string $attribute, ?string $format = null, array $context = []): mixed { return $object->$attribute; } - protected function setAttributeValue(object $object, string $attribute, mixed $value, string $format = null, array $context = []): void + protected function setAttributeValue(object $object, string $attribute, mixed $value, ?string $format = null, array $context = []): void { $object->$attribute = $value; } diff --git a/src/Symfony/Component/Validator/Tests/Fixtures/ConstraintWithRequiredArgument.php b/src/Symfony/Component/Validator/Tests/Fixtures/ConstraintWithRequiredArgument.php index 3048ae5ce1b99..f8abc8a563f52 100644 --- a/src/Symfony/Component/Validator/Tests/Fixtures/ConstraintWithRequiredArgument.php +++ b/src/Symfony/Component/Validator/Tests/Fixtures/ConstraintWithRequiredArgument.php @@ -20,7 +20,7 @@ final class ConstraintWithRequiredArgument extends Constraint public string $requiredArg; #[HasNamedArguments] - public function __construct(string $requiredArg, array $groups = null, mixed $payload = null) + public function __construct(string $requiredArg, ?array $groups = null, mixed $payload = null) { parent::__construct([], $groups, $payload); From a308acff1f4288824333328b96e73c2ea83a3084 Mon Sep 17 00:00:00 2001 From: Kerian Montes-Morin Date: Thu, 28 Mar 2024 14:28:49 +0100 Subject: [PATCH 75/81] Fix implicit nullable parameters --- .../Routing/Tests/Fixtures/AttributeFixtures/ExtendedRoute.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Symfony/Component/Routing/Tests/Fixtures/AttributeFixtures/ExtendedRoute.php b/src/Symfony/Component/Routing/Tests/Fixtures/AttributeFixtures/ExtendedRoute.php index 72232cbf6d50a..dca36a7ea2a56 100644 --- a/src/Symfony/Component/Routing/Tests/Fixtures/AttributeFixtures/ExtendedRoute.php +++ b/src/Symfony/Component/Routing/Tests/Fixtures/AttributeFixtures/ExtendedRoute.php @@ -7,7 +7,7 @@ #[\Attribute(\Attribute::IS_REPEATABLE | \Attribute::TARGET_CLASS | \Attribute::TARGET_METHOD)] class ExtendedRoute extends Route { - public function __construct(array|string $path = null, ?string $name = null, array $defaults = []) + public function __construct(array|string|null $path = null, ?string $name = null, array $defaults = []) { parent::__construct("/{section<(foo|bar|baz)>}" . $path, $name, [], [], array_merge(['section' => 'foo'], $defaults)); } From a98a616482c83d8723d9324540b0bc8b441da2e3 Mon Sep 17 00:00:00 2001 From: Christian Flothmann Date: Fri, 29 Mar 2024 00:13:55 +0100 Subject: [PATCH 76/81] respect multi-byte characters when rendering vertical-style tables --- .../Component/Console/Helper/Table.php | 5 +++-- .../Console/Tests/Helper/TableTest.php | 22 +++++++++++++++++++ 2 files changed, 25 insertions(+), 2 deletions(-) diff --git a/src/Symfony/Component/Console/Helper/Table.php b/src/Symfony/Component/Console/Helper/Table.php index 6aad9e95b8c68..1f026dc504adb 100644 --- a/src/Symfony/Component/Console/Helper/Table.php +++ b/src/Symfony/Component/Console/Helper/Table.php @@ -371,8 +371,9 @@ public function render() if ($headers && !$containsColspan) { if (0 === $idx) { $rows[] = [sprintf( - '%s: %s', - str_pad($headers[$i] ?? '', $maxHeaderLength, ' ', \STR_PAD_LEFT), + '%s%s: %s', + str_repeat(' ', $maxHeaderLength - Helper::width(Helper::removeDecoration($formatter, $headers[$i] ?? ''))), + $headers[$i] ?? '', $part )]; } else { diff --git a/src/Symfony/Component/Console/Tests/Helper/TableTest.php b/src/Symfony/Component/Console/Tests/Helper/TableTest.php index 728ea847f031f..4af12e34c0680 100644 --- a/src/Symfony/Component/Console/Tests/Helper/TableTest.php +++ b/src/Symfony/Component/Console/Tests/Helper/TableTest.php @@ -1649,6 +1649,28 @@ public static function provideRenderVerticalTests(): \Traversable $books, ]; + yield 'With multibyte characters in some headers (the "í" in "Títle") and cells (the "í" in "Dívíne")' => [ + << [ << Date: Mon, 1 Apr 2024 20:50:03 +0200 Subject: [PATCH 77/81] Revert bumping contract version --- src/Symfony/Component/HttpClient/composer.json | 2 +- src/Symfony/Contracts/composer.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Symfony/Component/HttpClient/composer.json b/src/Symfony/Component/HttpClient/composer.json index 2326e9f4b758a..72cc2329e2852 100644 --- a/src/Symfony/Component/HttpClient/composer.json +++ b/src/Symfony/Component/HttpClient/composer.json @@ -25,7 +25,7 @@ "php": ">=7.2.5", "psr/log": "^1|^2|^3", "symfony/deprecation-contracts": "^2.1|^3", - "symfony/http-client-contracts": "^2.6", + "symfony/http-client-contracts": "^2.5", "symfony/polyfill-php73": "^1.11", "symfony/polyfill-php80": "^1.16", "symfony/service-contracts": "^1.0|^2|^3" diff --git a/src/Symfony/Contracts/composer.json b/src/Symfony/Contracts/composer.json index 151b85bda7647..f70b8b7dc55a4 100644 --- a/src/Symfony/Contracts/composer.json +++ b/src/Symfony/Contracts/composer.json @@ -52,7 +52,7 @@ "minimum-stability": "dev", "extra": { "branch-alias": { - "dev-main": "2.6-dev" + "dev-main": "2.5-dev" } } } From 5a3a72fa9c9a124abca60be5cd4ecd8f5ee55b5e Mon Sep 17 00:00:00 2001 From: Fabien Potencier Date: Mon, 1 Apr 2024 20:54:44 +0200 Subject: [PATCH 78/81] Fix tests --- src/Symfony/Component/HttpClient/composer.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Symfony/Component/HttpClient/composer.json b/src/Symfony/Component/HttpClient/composer.json index 72cc2329e2852..c340d209a5633 100644 --- a/src/Symfony/Component/HttpClient/composer.json +++ b/src/Symfony/Component/HttpClient/composer.json @@ -25,7 +25,7 @@ "php": ">=7.2.5", "psr/log": "^1|^2|^3", "symfony/deprecation-contracts": "^2.1|^3", - "symfony/http-client-contracts": "^2.5", + "symfony/http-client-contracts": "^2.5.3", "symfony/polyfill-php73": "^1.11", "symfony/polyfill-php80": "^1.16", "symfony/service-contracts": "^1.0|^2|^3" From 8b4521a7fe173900c0a08e2f5174a4c9eb427066 Mon Sep 17 00:00:00 2001 From: Christian Flothmann Date: Mon, 1 Apr 2024 22:35:36 +0200 Subject: [PATCH 79/81] fix contracts constraint --- src/Symfony/Component/HttpClient/composer.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Symfony/Component/HttpClient/composer.json b/src/Symfony/Component/HttpClient/composer.json index 84aae6b35fb67..ef456a603763c 100644 --- a/src/Symfony/Component/HttpClient/composer.json +++ b/src/Symfony/Component/HttpClient/composer.json @@ -25,8 +25,8 @@ "php": ">=8.1", "psr/log": "^1|^2|^3", "symfony/deprecation-contracts": "^2.5|^3", - "symfony/http-client-contracts": "^3", - "symfony/service-contracts": "^2.5.3|^3.4.2" + "symfony/http-client-contracts": "^3.4.1", + "symfony/service-contracts": "^2.5|^3" }, "require-dev": { "amphp/amp": "^2.5", From b1d866967f6b667d6094c65ecbe7ba076487f7ee Mon Sep 17 00:00:00 2001 From: Fabien Potencier Date: Wed, 3 Apr 2024 08:12:22 +0200 Subject: [PATCH 80/81] Update CHANGELOG for 7.0.6 --- CHANGELOG-7.0.md | 37 +++++++++++++++++++++++++++++++++++++ 1 file changed, 37 insertions(+) diff --git a/CHANGELOG-7.0.md b/CHANGELOG-7.0.md index 2dd0c8b206cc2..394009335f611 100644 --- a/CHANGELOG-7.0.md +++ b/CHANGELOG-7.0.md @@ -7,6 +7,43 @@ in 7.0 minor versions. To get the diff for a specific change, go to https://github.com/symfony/symfony/commit/XXX where XXX is the change hash To get the diff between two versions, go to https://github.com/symfony/symfony/compare/v7.0.0...v7.0.1 +* 7.0.6 (2024-04-03) + + * bug #54400 [HttpClient] stop all server processes after tests have run (xabbuh) + * bug #54435 [Console] respect multi-byte characters when rendering vertical-style tables (xabbuh) + * bug #54419 Fix TypeError on ProgressBar (Fan2Shrek) + * bug #54425 [TwigBridge] Remove whitespaces from block form_help output (rosier) + * bug #53969 [Mailer] include message id provided by the MTA when dispatching the `SentMessageEvent` (xabbuh) + * bug #54315 [Serializer] Fixed BackedEnumNormalizer priority for translatable enum (IndraGunawan) + * bug #54372 [Config] Fix `YamlReferenceDumper` handling of array examples (MatTheCat) + * bug #54362 [Filesystem] preserve the file modification time when mirroring directories (xabbuh) + * bug #54333 [HttpFoundation] Allow array style callable setting for Request setFactory method (simbera) + * bug #54121 [Messenger] Catch TableNotFoundException in MySQL delete (acbramley) + * bug #54271 [DoctrineBridge] Fix deprecation warning with ORM 3 when guessing field lengths (eltharin) + * bug #54306 Throw TransformationFailedException when there is a null bytes injection (sormes) + * bug #54148 [Serializer] Fix object normalizer when properties has the same name as their accessor (NeilPeyssard) + * bug #54305 [Cache][Lock] Identify missing table in pgsql correctly and address failing integration tests (arifszn) + * bug #54199 [Mailer] [Brevo] Check that tags is present in payload before calling setTags (palgalik) + * bug #54292 [FrameworkBundle] Fix mailer config with XML (lyrixx) + * bug #54298 [Filesystem] Fix str_contains deprecation (NeilPeyssard) + * bug #54248 [Security] Correctly initialize the voter property (aschempp) + * bug #54273 [DependencyInjection] fix XmlDumper when a tag contains also a 'name' property (lyrixx) + * bug #54191 [Validator] add missing invalid extension error entry (xabbuh) + * bug #54194 [PropertyAccess] Fix checking for missing properties (nicolas-grekas) + * bug #54201 [Lock] Check the correct SQLSTATE error code for MySQL (edomato) + * bug #54252 [Lock] compatiblity with redis cluster 7 (bastnic) + * bug #54265 [VarDumper] prevent error in value to Typed property must not be accessed before initialization (shakaran) + * bug #54124 [Messenger] trigger retry logic when message is a redelivery (nikophil) + * bug #54254 [HttpKernel] Fix creating `ReflectionMethod` with only one argument (alexandre-daubois) + * bug #54219 [Validator] Allow BICs’ first four characters to be digits (MatTheCat) + * bug #54239 [Mailer] Fix sendmail transport not handling failure (aboks) + * bug #54207 [HttpClient] Lazily initialize CurlClientState (arjenm) + * bug #53865 [Workflow]Fix Marking when it must contains more than one tokens (lyrixx) + * bug #54137 [Validator] UniqueValidator - normalize before reducing keys (Brajk19) + * bug #54187 [FrameworkBundle] Fix PHP 8.4 deprecation on `ReflectionMethod` (alexandre-daubois) + * bug #54167 [Messenger] [Amqp] Handle AMQPConnectionException when publishing a message. (jwage) + * bug #54146 [HttpClient] Preserve float in JsonMockResponse (Jibbarth) + * 7.0.5 (2024-03-04) * bug #54113 [AssetMapper] Throw exception in Javascript compiler when PCRE error (smnandre) From 87a9702a055e1b8a5de3ce5faffec81daa92bde8 Mon Sep 17 00:00:00 2001 From: Fabien Potencier Date: Wed, 3 Apr 2024 08:12:25 +0200 Subject: [PATCH 81/81] Update VERSION for 7.0.6 --- src/Symfony/Component/HttpKernel/Kernel.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Symfony/Component/HttpKernel/Kernel.php b/src/Symfony/Component/HttpKernel/Kernel.php index 4e48507e60393..31bbe239be275 100644 --- a/src/Symfony/Component/HttpKernel/Kernel.php +++ b/src/Symfony/Component/HttpKernel/Kernel.php @@ -76,12 +76,12 @@ abstract class Kernel implements KernelInterface, RebootableInterface, Terminabl */ private static array $freshCache = []; - public const VERSION = '7.0.6-DEV'; + public const VERSION = '7.0.6'; public const VERSION_ID = 70006; public const MAJOR_VERSION = 7; public const MINOR_VERSION = 0; public const RELEASE_VERSION = 6; - public const EXTRA_VERSION = 'DEV'; + public const EXTRA_VERSION = ''; public const END_OF_MAINTENANCE = '07/2024'; public const END_OF_LIFE = '07/2024';