Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit ffdc46c

Browse filesBrowse files
minor #39975 [Serializer] Fix tests wrongly marked as incomplete (chalasr)
This PR was merged into the 4.4 branch. Discussion ---------- [Serializer] Fix tests wrongly marked as incomplete | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - #30907 has been merged meanwhile. Commits ------- e632302 [Serializer] Fix tests marked as incomplete
2 parents 4b8983a + e632302 commit ffdc46c
Copy full SHA for ffdc46c

File tree

1 file changed

+0
-2
lines changed
Filter options

1 file changed

+0
-2
lines changed

‎src/Symfony/Component/Serializer/Tests/Normalizer/Features/IgnoredAttributesTestTrait.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/Serializer/Tests/Normalizer/Features/IgnoredAttributesTestTrait.php
-2Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,6 @@ public function testIgnoredAttributesNormalize()
3838
$normalizer->normalize($objectOuter, null, $context)
3939
);
4040

41-
$this->markTestIncomplete('AbstractObjectNormalizer::getAttributes caches attributes by class instead of by class+context, reusing the normalizer with different config therefore fails. This is being fixed in https://github.com/symfony/symfony/pull/30907');
42-
4341
$context = ['ignored_attributes' => ['foo', 'inner']];
4442
$this->assertEquals(
4543
[

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.