Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit fe6cf73

Browse filesBrowse files
nicolas-grekasnicolas-grekas
committed
Merge branch '3.4'
* 3.4: [Serializer] Remove a useless legacy annotation Fixed extra semi-colon fix docblock position [DependencyInjection] remove unused variable [PhpUnitBridge] add changelog entries for #21140 [DI] Remove dead service_container checks
2 parents 88cddb8 + 98a2d3c commit fe6cf73
Copy full SHA for fe6cf73

File tree

Expand file treeCollapse file tree

7 files changed

+13
-16
lines changed
Filter options
Expand file treeCollapse file tree

7 files changed

+13
-16
lines changed

‎src/Symfony/Bridge/PhpUnit/CHANGELOG.md

Copy file name to clipboardExpand all lines: src/Symfony/Bridge/PhpUnit/CHANGELOG.md
+8Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,3 +11,11 @@ CHANGELOG
1111
* support for passing an array of mocked namespaces not indexed by the mock
1212
feature to the constructor of the `SymfonyTestsListenerTrait` class was
1313
dropped
14+
15+
3.3.0
16+
-----
17+
18+
* using the `testLegacy` prefix in method names to mark a test as legacy is
19+
deprecated, use the `@group legacy` notation instead
20+
* using the `Legacy` prefix in class names to mark a test as legacy is deprecated,
21+
use the `@group legacy` notation instead

‎src/Symfony/Bundle/FrameworkBundle/Console/Descriptor/Descriptor.php

Copy file name to clipboardExpand all lines: src/Symfony/Bundle/FrameworkBundle/Console/Descriptor/Descriptor.php
-4Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -258,10 +258,6 @@ protected function resolveServiceDefinition(ContainerBuilder $builder, $serviceI
258258
return $builder->getAlias($serviceId);
259259
}
260260

261-
if ('service_container' === $serviceId) {
262-
return $builder;
263-
}
264-
265261
// the service has been injected in some special way, just return the service
266262
return $builder->get($serviceId);
267263
}

‎src/Symfony/Component/DependencyInjection/Compiler/AutowirePass.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/DependencyInjection/Compiler/AutowirePass.php
-1Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,6 @@ private function doProcessValue($value, $isRoot = false)
161161
*/
162162
private function getMethodsToAutowire(\ReflectionClass $reflectionClass)
163163
{
164-
$found = array();
165164
$methodsToAutowire = array();
166165

167166
foreach ($reflectionClass->getMethods() as $reflectionMethod) {

‎src/Symfony/Component/DependencyInjection/Dumper/GraphvizDumper.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/DependencyInjection/Dumper/GraphvizDumper.php
+1-2Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -192,8 +192,7 @@ private function findNodes()
192192
}
193193

194194
if (!$container->hasDefinition($id)) {
195-
$class = get_class('service_container' === $id ? $this->container : $container->get($id));
196-
$nodes[$id] = array('class' => str_replace('\\', '\\\\', $class), 'attributes' => $this->options['node.instance']);
195+
$nodes[$id] = array('class' => str_replace('\\', '\\\\', get_class($container->get($id))), 'attributes' => $this->options['node.instance']);
197196
}
198197
}
199198

‎src/Symfony/Component/Serializer/Tests/Normalizer/AbstractObjectNormalizerTest.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/Serializer/Tests/Normalizer/AbstractObjectNormalizerTest.php
-3Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,6 @@ public function testDenormalize()
2626
$this->assertSame('baz', $normalizedData->baz);
2727
}
2828

29-
/**
30-
* @group legacy
31-
*/
3229
public function testInstantiateObjectDenormalizer()
3330
{
3431
$data = array('foo' => 'foo', 'bar' => 'bar', 'baz' => 'baz');

‎src/Symfony/Component/Translation/Translator.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/Translation/Translator.php
+4-5Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -74,11 +74,10 @@ class Translator implements TranslatorInterface, TranslatorBagInterface
7474
/**
7575
* Constructor.
7676
*
77-
* @param string $locale The locale
78-
* @param MessageSelector|null $selector The message selector for pluralization
79-
* @param string $defaultLocale
80-
* @param string|null $cacheDir The directory to use for the cache
81-
* @param bool $debug Use cache in debug mode ?
77+
* @param string $locale The locale
78+
* @param MessageSelector|null $selector The message selector for pluralization
79+
* @param string|null $cacheDir The directory to use for the cache
80+
* @param bool $debug Use cache in debug mode ?
8281
*
8382
* @throws InvalidArgumentException If a locale contains invalid characters
8483
*/

‎src/Symfony/Component/VarDumper/Caster/ReflectionCaster.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/VarDumper/Caster/ReflectionCaster.php
-1Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,6 @@ public static function castClosure(\Closure $c, array $a, Stub $stub, $isNested,
5151
unset($v->value['position'], $v->value['isVariadic'], $v->value['byReference'], $v);
5252
}
5353
}
54-
;
5554

5655
if (!($filter & Caster::EXCLUDE_VERBOSE) && $f = $c->getFileName()) {
5756
$a[$prefix.'file'] = new LinkStub($f, $c->getStartLine());

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.