Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit fdc9e09

Browse filesBrowse files
fabpotfabpot
committed
minor #28829 Translation commands should not tell about the old app/ directory (e-moe)
This PR was merged into the 3.4 branch. Discussion ---------- Translation commands should not tell about the old app/ directory Fixes #28816 Translation commands should not talk about the old "app/" directory since 3.4 | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #28816 | License | MIT | Doc PR | n/a Commits ------- 5fcc0b4 Fixes 28816 Translation commands should not talk about the old app/ directory since 3.4
2 parents dc11f7b + 5fcc0b4 commit fdc9e09
Copy full SHA for fdc9e09

File tree

Expand file treeCollapse file tree

2 files changed

+7
-7
lines changed
Filter options
Expand file treeCollapse file tree

2 files changed

+7
-7
lines changed

‎src/Symfony/Bundle/FrameworkBundle/Command/TranslationDebugCommand.php

Copy file name to clipboardExpand all lines: src/Symfony/Bundle/FrameworkBundle/Command/TranslationDebugCommand.php
+3-3Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ protected function configure()
7676
$this
7777
->setDefinition(array(
7878
new InputArgument('locale', InputArgument::REQUIRED, 'The locale'),
79-
new InputArgument('bundle', InputArgument::OPTIONAL, 'The bundle name or directory where to load the messages, defaults to app/Resources folder'),
79+
new InputArgument('bundle', InputArgument::OPTIONAL, 'The bundle name or directory where to load the messages'),
8080
new InputOption('domain', null, InputOption::VALUE_OPTIONAL, 'The messages domain'),
8181
new InputOption('only-missing', null, InputOption::VALUE_NONE, 'Displays only missing messages'),
8282
new InputOption('only-unused', null, InputOption::VALUE_NONE, 'Displays only unused messages'),
@@ -86,7 +86,7 @@ protected function configure()
8686
->setHelp(<<<'EOF'
8787
The <info>%command.name%</info> command helps finding unused or missing translation
8888
messages and comparing them with the fallback ones by inspecting the
89-
templates and translation files of a given bundle or the app folder.
89+
templates and translation files of a given bundle or the default translations directory.
9090
9191
You can display information about bundle translations in a specific locale:
9292
@@ -104,7 +104,7 @@ protected function configure()
104104
105105
<info>php %command.full_name% --only-unused en AcmeDemoBundle</info>
106106
107-
You can display information about app translations in a specific locale:
107+
You can display information about application translations in a specific locale:
108108
109109
<info>php %command.full_name% en</info>
110110

‎src/Symfony/Bundle/FrameworkBundle/Command/TranslationUpdateCommand.php

Copy file name to clipboardExpand all lines: src/Symfony/Bundle/FrameworkBundle/Command/TranslationUpdateCommand.php
+4-4Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ protected function configure()
8080
$this
8181
->setDefinition(array(
8282
new InputArgument('locale', InputArgument::REQUIRED, 'The locale'),
83-
new InputArgument('bundle', InputArgument::OPTIONAL, 'The bundle name or directory where to load the messages, defaults to app/Resources folder'),
83+
new InputArgument('bundle', InputArgument::OPTIONAL, 'The bundle name or directory where to load the messages'),
8484
new InputOption('prefix', null, InputOption::VALUE_OPTIONAL, 'Override the default prefix', '__'),
8585
new InputOption('no-prefix', null, InputOption::VALUE_NONE, '[DEPRECATED] If set, no prefix is added to the translations'),
8686
new InputOption('output-format', null, InputOption::VALUE_OPTIONAL, 'Override the default output format', 'yml'),
@@ -93,7 +93,7 @@ protected function configure()
9393
->setDescription('Updates the translation file')
9494
->setHelp(<<<'EOF'
9595
The <info>%command.name%</info> command extracts translation strings from templates
96-
of a given bundle or the app folder. It can display them or merge the new ones into the translation files.
96+
of a given bundle or the default translations directory. It can display them or merge the new ones into the translation files.
9797
9898
When new translation strings are found it can automatically add a prefix to the translation
9999
message.
@@ -102,7 +102,7 @@ protected function configure()
102102
<info>php %command.full_name% --dump-messages en AcmeBundle</info>
103103
<info>php %command.full_name% --force --prefix="new_" fr AcmeBundle</info>
104104
105-
Example running against app messages (app/Resources folder)
105+
Example running against default messages directory
106106
<info>php %command.full_name% --dump-messages en</info>
107107
<info>php %command.full_name% --force --prefix="new_" fr</info>
108108
EOF
@@ -171,7 +171,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
171171
if ($this->defaultViewsPath) {
172172
$viewsPaths[] = $this->defaultViewsPath;
173173
}
174-
$currentName = 'app folder';
174+
$currentName = 'default directory';
175175

176176
// Override with provided Bundle info
177177
if (null !== $input->getArgument('bundle')) {

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.