Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit fc9c551

Browse filesBrowse files
committed
Revert "[Messenger] Add call to gc_collect_cycles() after each message is handled"
This reverts commit b0df65a.
1 parent d5376fc commit fc9c551
Copy full SHA for fc9c551

File tree

2 files changed

+0
-21
lines changed
Filter options

2 files changed

+0
-21
lines changed

‎src/Symfony/Component/Messenger/Tests/WorkerTest.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/Messenger/Tests/WorkerTest.php
-19
Original file line numberDiff line numberDiff line change
@@ -584,25 +584,6 @@ public function testFlushBatchOnStop()
584584

585585
$this->assertSame($expectedMessages, $handler->processedMessages);
586586
}
587-
588-
public function testGcCollectCyclesIsCalledOnMessageHandle()
589-
{
590-
$apiMessage = new DummyMessage('API');
591-
592-
$receiver = new DummyReceiver([[new Envelope($apiMessage)]]);
593-
594-
$bus = $this->createMock(MessageBusInterface::class);
595-
596-
$dispatcher = new EventDispatcher();
597-
$dispatcher->addSubscriber(new StopWorkerOnMessageLimitListener(1));
598-
599-
$worker = new Worker(['transport' => $receiver], $bus, $dispatcher);
600-
$worker->run();
601-
602-
$gcStatus = gc_status();
603-
604-
$this->assertGreaterThan(0, $gcStatus['runs']);
605-
}
606587
}
607588

608589
class DummyQueueReceiver extends DummyReceiver implements QueueReceiverInterface

‎src/Symfony/Component/Messenger/Worker.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/Messenger/Worker.php
-2
Original file line numberDiff line numberDiff line change
@@ -117,8 +117,6 @@ public function run(array $options = []): void
117117
// this should prevent multiple lower priority receivers from
118118
// blocking too long before the higher priority are checked
119119
if ($envelopeHandled) {
120-
gc_collect_cycles();
121-
122120
break;
123121
}
124122
}

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.