Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit fc30e61

Browse filesBrowse files
feature #33315 [WebProfiler] Improve HttpClient Panel (ismail1432)
This PR was merged into the 5.1-dev branch. Discussion ---------- [WebProfiler] Improve HttpClient Panel | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | np <!-- please add some, will be required by reviewers --> | Fixed tickets | #33311 <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | ? Wishlist from issue : - [x] the panel UI could be improved I suppose, e.g. a tooltip on hover in the toolbar - [ ] putting requests in the "Performance" tab would be great (all timings are already in the collected "info") - [ ] ~response bodies are not collected yet~ #33315 (comment) - [ ] when a transport error occurs, (ie the "error" info is populated) we should maybe have a better display too? - [x] add a copy-as-curl button next to each request **[EDIT 07 oct 19]** This PR contains : - Display a tooltip in Toolbar - Add a link only for GET Request in profiler panel ![image](https://user-images.githubusercontent.com/13260307/66316799-389be480-e910-11e9-888e-7703c87c7b10.png) Commits ------- e2e6bd0 [WebProfiler] Improve HttpClient Panel
2 parents fafe576 + e2e6bd0 commit fc30e61
Copy full SHA for fc30e61

File tree

1 file changed

+11
-0
lines changed
Filter options

1 file changed

+11
-0
lines changed

‎src/Symfony/Bundle/WebProfilerBundle/Resources/views/Collector/http_client.html.twig

Copy file name to clipboardExpand all lines: src/Symfony/Bundle/WebProfilerBundle/Resources/views/Collector/http_client.html.twig
+11Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,17 @@
88
<span class="sf-toolbar-value">{{ collector.requestCount }}</span>
99
{% endset %}
1010

11+
{% set text %}
12+
<div class="sf-toolbar-info-piece">
13+
<b>Total requests</b>
14+
<span>{{ collector.requestCount }}</span>
15+
</div>
16+
<div class="sf-toolbar-info-piece">
17+
<b>HTTP errors</b>
18+
<span class="sf-toolbar-status sf-toolbar-status-red">{{ collector.errorCount }}</span>
19+
</div>
20+
{% endset %}
21+
1122
{{ include('@WebProfiler/Profiler/toolbar_item.html.twig', { link: profiler_url, status: status_color }) }}
1223
{% endif %}
1324
{% endblock %}

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.