Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit fb65bd6

Browse filesBrowse files
fabpotfabpot
committed
minor #21766 [DI] Remove experimental status from service-locator argument type (chalasr)
This PR was merged into the 3.3-dev branch. Discussion ---------- [DI] Remove experimental status from service-locator argument type | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #21625 (comment), #21625 (comment), #21710 | License | MIT The `service-locator` argument type is not controversial to me. We know its scope, nothing really surprising, just a map of services to be lazily loaded like `iterator` is (which is not experimental) but keyed. About its api, it's just PSR-11 restricted to objects, nothing that can't be changed safely in the future. As stated in #21625 (comment), it proven its usefulness already. I think what we were looking for by flagging it experimental is just to see it in action, we've 3 opened PRs for that (#21625, #21690, #21730). This allows introducing deprecations for making use of the feature in the core, thus unlocks #21625 and #21690. Commits ------- 46dc47a [DI] Remove experimental status from service-locator argument type
2 parents 43e32b8 + 46dc47a commit fb65bd6
Copy full SHA for fb65bd6

File tree

3 files changed

+1
-5
lines changed
Filter options

3 files changed

+1
-5
lines changed

‎src/Symfony/Component/DependencyInjection/Argument/ServiceLocatorArgument.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/DependencyInjection/Argument/ServiceLocatorArgument.php
-2Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,6 @@
1818
* Represents a service locator able to lazy load a given range of services.
1919
*
2020
* @author Robin Chalas <robin.chalas@gmail.com>
21-
*
22-
* @experimental in version 3.3
2321
*/
2422
class ServiceLocatorArgument implements ArgumentInterface
2523
{

‎src/Symfony/Component/DependencyInjection/CHANGELOG.md

Copy file name to clipboardExpand all lines: src/Symfony/Component/DependencyInjection/CHANGELOG.md
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ CHANGELOG
55
-----
66

77
* [EXPERIMENTAL] added "instanceof" section for local interface-defined configs
8-
* [EXPERIMENTAL] added "service-locator" argument for lazy loading a set of identified values and services
8+
* added "service-locator" argument for lazy loading a set of identified values and services
99
* [EXPERIMENTAL] added prototype services for PSR4-based discovery and registration
1010
* added `ContainerBuilder::getReflectionClass()` for retrieving and tracking reflection class info
1111
* deprecated `ContainerBuilder::getClassResource()`, use `ContainerBuilder::getReflectionClass()` or `ContainerBuilder::addObjectResource()` instead

‎src/Symfony/Component/DependencyInjection/ServiceLocator.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/DependencyInjection/ServiceLocator.php
-2Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,6 @@
1818
/**
1919
* @author Robin Chalas <robin.chalas@gmail.com>
2020
* @author Nicolas Grekas <p@tchwork.com>
21-
*
22-
* @experimental in version 3.3
2321
*/
2422
class ServiceLocator implements PsrContainerInterface
2523
{

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.