symfony
diff --git a/‎src/Symfony/Bundle/FrameworkBundle/Controller/ControllerNameParser.php
Copy file name to clipboardExpand all lines: src/Symfony/Bundle/FrameworkBundle/Controller/ControllerNameParser.php
+6-1Lines changed: 6 additions & 1 deletion b/‎src/Symfony/Bundle/FrameworkBundle/Controller/ControllerNameParser.php
Copy file name to clipboardExpand all lines: src/Symfony/Bundle/FrameworkBundle/Controller/ControllerNameParser.php
+6-1Lines changed: 6 additions & 1 deletion
@@ -47,7 +47,12 @@ public function __construct(KernelInterface $kernel)
     public function parse($controller)
     {
         $originalController = $controller;
-        if (3 !== count($parts = explode(':', $controller))) {
+        $parts = explode(':', $controller);
+
+        // The second condition is for cases when this method is called with the
+        // class::method string instead of a:b:c. It's important to fail early in this
+        // case because calling findAlternative needlessly is bad for performance.
+        if (3 !== count($parts) || $parts[1] === '') {
             throw new \InvalidArgumentException(sprintf('The "%s" controller is not a valid "a:b:c" controller string.', $controller));
         }
Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,12 @@ public function __construct(KernelInterface $kernel)`
`47`	`47`	`public function parse($controller)`
`48`	`48`	`{`
`49`	`49`	`$originalController = $controller;`
`50`		`- if (3 !== count($parts = explode(':', $controller))) {`
	`50`	`+ $parts = explode(':', $controller);`
	`51`	`+`
	`52`	`+ // The second condition is for cases when this method is called with the`
	`53`	`+ // class::method string instead of a:b:c. It's important to fail early in this`
	`54`	`+ // case because calling findAlternative needlessly is bad for performance.`
	`55`	`+ if (3 !== count($parts) \|\| $parts[1] === '') {`
`51`	`56`	`throw new \InvalidArgumentException(sprintf('The "%s" controller is not a valid "a:b:c" controller string.', $controller));`
`52`	`57`	`}`
`53`	`58`