Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit f4b774f

Browse filesBrowse files
bug #52096 [Notifier] [Brevo] Handle error responses without a message key (stof)
This PR was merged into the 6.4 branch. Discussion ---------- [Notifier] [Brevo] Handle error responses without a message key | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | | License | MIT During their outage yesterday where the endpoint returned errors with status code 500, there was no message key in the json response. This avoids a notice when the key does not exist. Instead, it uses the full response content, as done when the decoding fails. This is the same change than #52095 but for the new Brevo bridge Commits ------- 517ceae Handle Brevo error responses without a message key
2 parents 7bdb13d + 517ceae commit f4b774f
Copy full SHA for f4b774f

File tree

2 files changed

+2
-2
lines changed
Filter options

2 files changed

+2
-2
lines changed

‎src/Symfony/Component/Mailer/Bridge/Brevo/Transport/BrevoApiTransport.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/Mailer/Bridge/Brevo/Transport/BrevoApiTransport.php
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ protected function doSendApi(SentMessage $sentMessage, Email $email, Envelope $e
6565
}
6666

6767
if (201 !== $statusCode) {
68-
throw new HttpTransportException('Unable to send an email: '.$result['message'].sprintf(' (code %d).', $statusCode), $response);
68+
throw new HttpTransportException('Unable to send an email: '.($result['message'] ?? $response->getContent(false)).sprintf(' (code %d).', $statusCode), $response);
6969
}
7070

7171
$sentMessage->setMessageId($result['messageId']);

‎src/Symfony/Component/Notifier/Bridge/Brevo/BrevoTransport.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/Notifier/Bridge/Brevo/BrevoTransport.php
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ protected function doSend(MessageInterface $message): SentMessage
7575
if (201 !== $statusCode) {
7676
$error = $response->toArray(false);
7777

78-
throw new TransportException('Unable to send the SMS: '.$error['message'], $response);
78+
throw new TransportException('Unable to send the SMS: '.($error['message'] ?? $response->getContent(false)), $response);
7979
}
8080

8181
$success = $response->toArray(false);

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.