Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit f436cc8

Browse filesBrowse files
fabpotfabpot
committed
minor #33530 Remove Google references when not needed (fabpot)
This PR was merged into the 3.4 branch. Discussion ---------- Remove Google references when not needed | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | n/a | License | MIT | Doc PR | n/a No need to promote Google. Commits ------- 9665d76 Remove Google references when not needed
2 parents 6f332ce + 9665d76 commit f436cc8
Copy full SHA for f436cc8

File tree

6 files changed

+30
-30
lines changed
Filter options

6 files changed

+30
-30
lines changed

‎src/Symfony/Bridge/Twig/Tests/Extension/AbstractBootstrap3LayoutTest.php

Copy file name to clipboardExpand all lines: src/Symfony/Bridge/Twig/Tests/Extension/AbstractBootstrap3LayoutTest.php
+4-4Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2396,31 +2396,31 @@ public function testTimezoneWithPlaceholder()
23962396

23972397
public function testUrlWithDefaultProtocol()
23982398
{
2399-
$url = 'http://www.google.com?foo1=bar1&foo2=bar2';
2399+
$url = 'http://www.example.com?foo1=bar1&foo2=bar2';
24002400
$form = $this->factory->createNamed('name', 'Symfony\Component\Form\Extension\Core\Type\UrlType', $url, ['default_protocol' => 'http']);
24012401

24022402
$this->assertWidgetMatchesXpath($form->createView(), ['attr' => ['class' => 'my&class']],
24032403
'/input
24042404
[@type="text"]
24052405
[@name="name"]
24062406
[@class="my&class form-control"]
2407-
[@value="http://www.google.com?foo1=bar1&foo2=bar2"]
2407+
[@value="http://www.example.com?foo1=bar1&foo2=bar2"]
24082408
[@inputmode="url"]
24092409
'
24102410
);
24112411
}
24122412

24132413
public function testUrlWithoutDefaultProtocol()
24142414
{
2415-
$url = 'http://www.google.com?foo1=bar1&foo2=bar2';
2415+
$url = 'http://www.example.com?foo1=bar1&foo2=bar2';
24162416
$form = $this->factory->createNamed('name', 'Symfony\Component\Form\Extension\Core\Type\UrlType', $url, ['default_protocol' => null]);
24172417

24182418
$this->assertWidgetMatchesXpath($form->createView(), ['attr' => ['class' => 'my&class']],
24192419
'/input
24202420
[@type="url"]
24212421
[@name="name"]
24222422
[@class="my&class form-control"]
2423-
[@value="http://www.google.com?foo1=bar1&foo2=bar2"]
2423+
[@value="http://www.example.com?foo1=bar1&foo2=bar2"]
24242424
'
24252425
);
24262426
}

‎src/Symfony/Component/BrowserKit/Tests/CookieTest.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/BrowserKit/Tests/CookieTest.php
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,10 +44,10 @@ public function getTestsForToFromString()
4444
return [
4545
['foo=bar; path=/'],
4646
['foo=bar; path=/foo'],
47-
['foo=bar; domain=google.com; path=/'],
47+
['foo=bar; domain=example.com; path=/'],
4848
['foo=bar; domain=example.com; path=/; secure', 'https://example.com/'],
4949
['foo=bar; path=/; httponly'],
50-
['foo=bar; domain=google.com; path=/foo; secure; httponly', 'https://google.com/'],
50+
['foo=bar; domain=example.com; path=/foo; secure; httponly', 'https://example.com/'],
5151
['foo=bar=baz; path=/'],
5252
['foo=bar%3Dbaz; path=/'],
5353
];

‎src/Symfony/Component/Form/Tests/AbstractLayoutTest.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/Form/Tests/AbstractLayoutTest.php
+4-4Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2189,29 +2189,29 @@ public function testTimezoneWithPlaceholder()
21892189

21902190
public function testUrlWithDefaultProtocol()
21912191
{
2192-
$url = 'http://www.google.com?foo1=bar1&foo2=bar2';
2192+
$url = 'http://www.example.com?foo1=bar1&foo2=bar2';
21932193
$form = $this->factory->createNamed('name', 'Symfony\Component\Form\Extension\Core\Type\UrlType', $url, ['default_protocol' => 'http']);
21942194

21952195
$this->assertWidgetMatchesXpath($form->createView(), [],
21962196
'/input
21972197
[@type="text"]
21982198
[@name="name"]
2199-
[@value="http://www.google.com?foo1=bar1&foo2=bar2"]
2199+
[@value="http://www.example.com?foo1=bar1&foo2=bar2"]
22002200
[@inputmode="url"]
22012201
'
22022202
);
22032203
}
22042204

22052205
public function testUrlWithoutDefaultProtocol()
22062206
{
2207-
$url = 'http://www.google.com?foo1=bar1&foo2=bar2';
2207+
$url = 'http://www.example.com?foo1=bar1&foo2=bar2';
22082208
$form = $this->factory->createNamed('name', 'Symfony\Component\Form\Extension\Core\Type\UrlType', $url, ['default_protocol' => null]);
22092209

22102210
$this->assertWidgetMatchesXpath($form->createView(), [],
22112211
'/input
22122212
[@type="url"]
22132213
[@name="name"]
2214-
[@value="http://www.google.com?foo1=bar1&foo2=bar2"]
2214+
[@value="http://www.example.com?foo1=bar1&foo2=bar2"]
22152215
'
22162216
);
22172217
}

‎src/Symfony/Component/HttpKernel/Tests/ClientTest.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/HttpKernel/Tests/ClientTest.php
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,8 @@ public function testDoRequest()
3939
$this->assertEquals('Request: /', $client->getResponse()->getContent(), '->doRequest() uses the request handler to make the request');
4040
$this->assertEquals('www.example.com', $client->getRequest()->getHost(), '->doRequest() uses the request handler to make the request');
4141

42-
$client->request('GET', 'http://www.example.com/?parameter=http://google.com');
43-
$this->assertEquals('http://www.example.com/?parameter='.urlencode('http://google.com'), $client->getRequest()->getUri(), '->doRequest() uses the request handler to make the request');
42+
$client->request('GET', 'http://www.example.com/?parameter=http://example.com');
43+
$this->assertEquals('http://www.example.com/?parameter='.urlencode('http://example.com'), $client->getRequest()->getUri(), '->doRequest() uses the request handler to make the request');
4444
}
4545

4646
public function testGetScript()

‎src/Symfony/Component/Validator/Tests/Constraints/UrlValidatorTest.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/Validator/Tests/Constraints/UrlValidatorTest.php
+15-15Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -67,11 +67,11 @@ public function getValidUrls()
6767
{
6868
return [
6969
['http://a.pl'],
70-
['http://www.google.com'],
71-
['http://www.google.com.'],
72-
['http://www.google.museum'],
73-
['https://google.com/'],
74-
['https://google.com:80/'],
70+
['http://www.example.com'],
71+
['http://www.example.com.'],
72+
['http://www.example.museum'],
73+
['https://example.com/'],
74+
['https://example.com:80/'],
7575
['http://www.example.coop/'],
7676
['http://www.test-example.com/'],
7777
['http://www.symfony.com/'],
@@ -148,15 +148,15 @@ public function testInvalidUrls($url)
148148
public function getInvalidUrls()
149149
{
150150
return [
151-
['google.com'],
152-
['://google.com'],
153-
['http ://google.com'],
154-
['http:/google.com'],
155-
['http://goog_le.com'],
156-
['http://google.com::aa'],
157-
['http://google.com:aa'],
158-
['ftp://google.fr'],
159-
['faked://google.fr'],
151+
['example.com'],
152+
['://example.com'],
153+
['http ://example.com'],
154+
['http:/example.com'],
155+
['http://examp_le.com'],
156+
['http://example.com::aa'],
157+
['http://example.com:aa'],
158+
['ftp://example.fr'],
159+
['faked://example.fr'],
160160
['http://127.0.0.1:aa/'],
161161
['ftp://[::1]/'],
162162
['http://[::1'],
@@ -189,7 +189,7 @@ public function testCustomProtocolIsValid($url)
189189
public function getValidCustomUrls()
190190
{
191191
return [
192-
['ftp://google.com'],
192+
['ftp://example.com'],
193193
['file://127.0.0.1'],
194194
['git://[::1]/'],
195195
];

‎src/Symfony/Component/VarDumper/Tests/Caster/SplCasterTest.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/VarDumper/Tests/Caster/SplCasterTest.php
+3-3Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -50,12 +50,12 @@ public function getCastFileInfoTests()
5050
%A}
5151
EOTXT
5252
],
53-
['https://google.com/about', <<<'EOTXT'
53+
['https://example.com/about', <<<'EOTXT'
5454
SplFileInfo {
55-
%Apath: "https://google.com"
55+
%Apath: "https://example.com"
5656
filename: "about"
5757
basename: "about"
58-
pathname: "https://google.com/about"
58+
pathname: "https://example.com/about"
5959
extension: ""
6060
realPath: false
6161
%A}

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.